From nobody Mon Feb 9 11:12:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1553691170627786.6584472653562; Wed, 27 Mar 2019 05:52:50 -0700 (PDT) Received: from localhost ([127.0.0.1]:47294 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h982t-0008AX-Jp for importer@patchew.org; Wed, 27 Mar 2019 08:52:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h97p9-00046E-Qt for qemu-devel@nongnu.org; Wed, 27 Mar 2019 08:38:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h97p7-0002ds-Lj for qemu-devel@nongnu.org; Wed, 27 Mar 2019 08:38:31 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:40825) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h97p7-0002d7-Cx for qemu-devel@nongnu.org; Wed, 27 Mar 2019 08:38:29 -0400 Received: by mail-wm1-x336.google.com with SMTP id z24so13388168wmi.5 for ; Wed, 27 Mar 2019 05:38:28 -0700 (PDT) Received: from 640k.localdomain ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id c20sm27722863wre.28.2019.03.27.05.38.26 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 05:38:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=kKT0/3MIJJRIyGZ5lW5LX9NPFoZ9i6uVujq59b8DJKI=; b=axavsLo3yjI4c0v5G+7K6sHfAo8uQTjikMYeBahf9fl2W9a8kQIRc/k6HTU4ywJw3h PAFzWvBSQwB1EbSJ4OmEI/N+5ml07oi83T3I2ZGcczePszfIZPF2uj6pI1eqmAxCnFnX URGyBhgYdCq/iKvOb9fZsItf47lRo+fzLfZ98ypiCM0uCbTHZ0lKXLuUykb5kcOVbU/N dcJN/hHrfFsvnp9X6tIp7LzMnwIqOuJl9YtmqoenEvpv3GDOZ1o0Q55ALbZnBwV8Ic5e 2FhvZ4RpSHMuC5muZw2NxuOV5+UqkabeaW1Rp4e+O9GNeV2AioAQMAQqqVX+AftgCCHg 5Sfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=kKT0/3MIJJRIyGZ5lW5LX9NPFoZ9i6uVujq59b8DJKI=; b=R0/8evzGK1Rz6YtzuKOe60C2plLVaxYyTkd0y4hDI7yqt6fYYG2pyF1gyKWIBskUxj N4pELHmAizyMiDLc7vT0CtmZ+VJ6VeWr2QDlpCkjMDoP3QAVL/JGZSqUxH2Ko6tGAt2u Wqt2MyL8JV/h4+R5mmxH2SF1Vx6hEmROv0ehkoVP31mg/80J55OXpbI3shR15TQWgZXh xfjeDhQh4Z2i22EEA9chTlbw2QcrVctJJYS5wvkcsIe2ZyXZj2RJ+Ddh4J9odorvtJmI 6IVpZtGRfW6AKtVE4LKUTARkLkG3v5xtuv8/Okua5XCr5XqlPNzTEAttlj2hgkJWDAi2 /jFQ== X-Gm-Message-State: APjAAAUwZzD7nW8mZvvZDH9/SjGU9j1QwK70A1IQfzPtg5k70YttmFtF lCAAr1goP/2yg4+eI3NPc724r6P6 X-Google-Smtp-Source: APXvYqw8RvX0LKd+2Mg7MMvb4DCirXTt3N0p4QXsgH7qne2LGGpKJpSpimk9YyCe5FPulwfNNZL+vg== X-Received: by 2002:a1c:f205:: with SMTP id s5mr12697608wmc.124.1553690307684; Wed, 27 Mar 2019 05:38:27 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 27 Mar 2019 13:38:01 +0100 Message-Id: <1553690281-81854-24-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1553690281-81854-1-git-send-email-pbonzini@redhat.com> References: <1553690281-81854-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::336 Subject: [Qemu-devel] [PULL 23/23] virtio-vga: only enable for specific boards X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When virtio-vga was added, the intention was to only support it for those machines where the firmware does not know about virtio-gpu, and supported VGA legacy hardware before virtio-{gpu,vga} were introduced. The Kconfig switch however enabled virtio-vga for all machines with a PCI bus, and libvirt then prefers it even on hardware where virtio-gpu would be preferrable. At least for now, only enable virtio-vga for PC, hppa and pSeries machines, as was the case before Kconfig dependencies were introduced. Reported-by: Laszlo Ersek Reviewed-by: Thomas Huth Signed-off-by: Paolo Bonzini --- hw/display/Kconfig | 2 +- hw/hppa/Kconfig | 1 + hw/i386/Kconfig | 1 + hw/ppc/Kconfig | 1 + 4 files changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/display/Kconfig b/hw/display/Kconfig index 86c1d54..72be57a 100644 --- a/hw/display/Kconfig +++ b/hw/display/Kconfig @@ -100,7 +100,7 @@ config VIRTIO_GPU =20 config VIRTIO_VGA bool - default y if PCI_DEVICES + # defaults to "N", enabled by specific boards depends on VIRTIO_PCI select VGA =20 diff --git a/hw/hppa/Kconfig b/hw/hppa/Kconfig index 7334f57..6e5d74a 100644 --- a/hw/hppa/Kconfig +++ b/hw/hppa/Kconfig @@ -2,6 +2,7 @@ config DINO bool imply PCI_DEVICES imply E1000_PCI + imply VIRTIO_VGA select PCI select SERIAL select ISA_BUS diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index 8e8444d..a6aed7c 100644 --- a/hw/i386/Kconfig +++ b/hw/i386/Kconfig @@ -19,6 +19,7 @@ config PC imply TPM_CRB imply TPM_TIS imply VGA_PCI + imply VIRTIO_VGA select FDC select I8259 select I8254 diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index ae07b4d..a346515 100644 --- a/hw/ppc/Kconfig +++ b/hw/ppc/Kconfig @@ -2,6 +2,7 @@ config PSERIES bool imply PCI_DEVICES imply TEST_DEVICES + imply VIRTIO_VGA select DIMM select PCI select SPAPR_VSCSI --=20 1.8.3.1