From nobody Tue Feb 10 03:37:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1553690583414712.904951411608; Wed, 27 Mar 2019 05:43:03 -0700 (PDT) Received: from localhost ([127.0.0.1]:47155 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h97tN-0007WX-Bp for importer@patchew.org; Wed, 27 Mar 2019 08:42:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h97ol-0003hi-0D for qemu-devel@nongnu.org; Wed, 27 Mar 2019 08:38:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h97oj-0002SN-Ml for qemu-devel@nongnu.org; Wed, 27 Mar 2019 08:38:06 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:44773) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h97oj-0002S9-Dk for qemu-devel@nongnu.org; Wed, 27 Mar 2019 08:38:05 -0400 Received: by mail-wr1-x431.google.com with SMTP id y7so14249340wrn.11 for ; Wed, 27 Mar 2019 05:38:05 -0700 (PDT) Received: from 640k.localdomain ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id c20sm27722863wre.28.2019.03.27.05.38.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 05:38:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=jNLJBzxaQQ5hlWAxWUD1d7BS7waGC/dkG+C9AtTyfyc=; b=rjuvu0UkNUa2NYK9z7/EJ3qMCp8nYhWQFHHVMTZ5sshjXf2M5msWvbO1at6QbJ+Scr v/yyEfQnijJuaM1U9ywWWaNuqeBFCbKvSOG4ozakhF1/hMBE3uh8IodH295d24tFYcKN 7GQcCUgf9q2hAZrFvoeITyZRgyesNbNWS11N/5aWoVpRHSl7ynE7puY9jVknazgYZiKW I6RleSthWc1iBqSznk0k0WFyTsIOT1tORzI1W9+Yl5zfXYRJydjKYxuTJp1Efbl4G9p5 U/qsNVvVqWgp6fh2UuXjl6r/4x3AFaNpfhMuBHY/jkN3tuK3OhnoeyH+63qQw34hzV05 YU9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=jNLJBzxaQQ5hlWAxWUD1d7BS7waGC/dkG+C9AtTyfyc=; b=aodfgQChc1HO/4crfAodi5YZjMMMNw3z288IfgnOEtX7eDynPLwEypoOMZOlkToDvY Dd8waJbfz+Rqm1ZDuh0CufxfHYeT9E9x9NPLbfxtSgr4EhcHdfs9GtxMS06VpoC5GPDM AkTb1kpv4asnelHXGacQeGg2LJtQMosDtZs3+cLLb3hjVBOwro12J+8TWtpR3k5pFUSo XtRl/3zgHWRxZFGb1nzheNYOLrSCbTh8lBBaLIkLCgiDL+GDob7shWz2OBxRZRXC6vkS 2QAmvmEwMjnZA+LOLNSbENJAmmarZndCASx7w2UG0CPJ/5eg17dhbv7jpOueSOeY3j2B m5zQ== X-Gm-Message-State: APjAAAVkjGHAj1d6YssHZ6CLFBd2vH9mbTnaS3jvk2EAYbWs7UkifvGK Md7w4Whz3lWw6R1qaOJxd9EfjyX2 X-Google-Smtp-Source: APXvYqx+jSvx2P/eNa5VBRYMpIxdSKgQs0QQFeaQO7Q7yRoy8uaZ6Pbn5bNUEKSxE6kVBs+6DR5bQQ== X-Received: by 2002:adf:cd90:: with SMTP id q16mr22583700wrj.75.1553690284133; Wed, 27 Mar 2019 05:38:04 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 27 Mar 2019 13:37:39 +0100 Message-Id: <1553690281-81854-2-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1553690281-81854-1-git-send-email-pbonzini@redhat.com> References: <1553690281-81854-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::431 Subject: [Qemu-devel] [PULL 01/23] riscv: plic: Set msi_nonbroken as true X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair Francis Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Alistair Francis Set msi_nonbroken as true for the PLIC. According to the comment located here: https://git.qemu.org/?p=3Dqemu.git;a=3Dblob;f=3Dhw/pci/msi.c;h=3D47d2b0f33c= 664533b8dbd5cb17faa8e6a01afe1f;hb=3DHEAD#l38 the msi_nonbroken variable should be set to true even if they don't support MSI. In this case that is what we are doing as we don't support MSI. Signed-off-by: Alistair Francis Reported-by: Andrea Bolognani Reported-by: David Abdurachmanov Message-Id: <256afbb2da005dc62c159b0f4a4fc0d95c050660.1552679970.git.alista= ir.francis@wdc.com> Signed-off-by: Paolo Bonzini --- hw/riscv/sifive_plic.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/riscv/sifive_plic.c b/hw/riscv/sifive_plic.c index d12ec3f..4b0537c 100644 --- a/hw/riscv/sifive_plic.c +++ b/hw/riscv/sifive_plic.c @@ -22,6 +22,7 @@ #include "qemu/log.h" #include "qemu/error-report.h" #include "hw/sysbus.h" +#include "hw/pci/msi.h" #include "target/riscv/cpu.h" #include "hw/riscv/sifive_plic.h" =20 @@ -443,6 +444,8 @@ static void sifive_plic_realize(DeviceState *dev, Error= **errp) plic->enable =3D g_new0(uint32_t, plic->bitfield_words * plic->num_add= rs); sysbus_init_mmio(SYS_BUS_DEVICE(dev), &plic->mmio); qdev_init_gpio_in(dev, sifive_plic_irq_request, plic->num_sources); + + msi_nonbroken =3D true; } =20 static void sifive_plic_class_init(ObjectClass *klass, void *data) --=20 1.8.3.1