From nobody Mon Feb 9 21:21:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 155232485735724.93723337308677; Mon, 11 Mar 2019 10:20:57 -0700 (PDT) Received: from localhost ([127.0.0.1]:37182 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3Obd-0002fn-9b for importer@patchew.org; Mon, 11 Mar 2019 13:20:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3ODS-0006yR-Hs for qemu-devel@nongnu.org; Mon, 11 Mar 2019 12:55:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3ODQ-0002xV-Eu for qemu-devel@nongnu.org; Mon, 11 Mar 2019 12:55:54 -0400 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:33172) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h3ODM-0002tR-SY for qemu-devel@nongnu.org; Mon, 11 Mar 2019 12:55:50 -0400 Received: by mail-wm1-x343.google.com with SMTP id c13so210224wmb.0 for ; Mon, 11 Mar 2019 09:55:48 -0700 (PDT) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id e12sm6484836wrs.91.2019.03.11.09.55.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Mar 2019 09:55:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Rs5/+NgdokfbYHIEtUIcTaT50tKdB7Md/8HCTEhRyDw=; b=eksJAZ1OWYbqcuvnLDFbxZm4bJSsMthGuCEXLXv7cZB5YlMI9V4wlWKGh1IinlDjJ8 B4cinT62Og44l8HJZzLL9QRMFPnwE9DNpF3Kj3/pn5W0fn4pzxRptfvMN1oVPq6F4ylB TcxvD8Oo6/u9D1aj+K3XRoFd0Hhng7egERDoY/qUtBKiSx59mzFfb6yZhxWfZBWm3iSA O/mw7MoZ5ZIuwtdtriLRU6G10K9fAybp+KsHksU6G7eaubCWIiwgnhIPe2JXaYnHqr/V Mem9/o4HYJNrZycAqZeovamvi2OAcSwim0ofEZ68sfkB+OHyFtMmPmA3Qjj5LhKlQSsl c+BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Rs5/+NgdokfbYHIEtUIcTaT50tKdB7Md/8HCTEhRyDw=; b=DVi0BH/LafBrrXBE5uouFRxFMaMSEIooHTxVyOtDi8+JJ9kwCyWAcFhFQbLPcPZsNS RflWrV2qiDDslUq1TIEJLe2ObkLp9I26hi0RY1qTWonJTk7/N6etDTGx/Z5HDGvlsMwz D8SXYczH8+pd5+JMwtpm5LbNBCtNyoQg3y35o5gBV90S5X+zECrNtSXx9HkuKPzS0CEA Z0o4nqQirhkoRsuPiexD5vwBq39MYqTom7dBi2r//MBYaX9mTVjBXPSTMK/hYfX+9r+L YMudFFjARaRvZO63hJAP1q9WQyEYtRvDdMJKNTEJIIxUrzf5kUKPG22Du6aMrJxP/0Mo xJHw== X-Gm-Message-State: APjAAAU0lUgJLL/VPSjhwYS7f15IOZ+70LtapYrg+C0rxuFCuezKFgrP jDB30Bqa2i893NOffrKPQ5ps6Cnj X-Google-Smtp-Source: APXvYqxo6Oj36V0tjrfcCTsH3UNU/+CCTaT9ngxGg+4TPtG7DG13/BlB1N6ZUCqGgLLJt6ZgWnLZPg== X-Received: by 2002:a1c:f901:: with SMTP id x1mr4651wmh.51.1552323347384; Mon, 11 Mar 2019 09:55:47 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 11 Mar 2019 17:55:12 +0100 Message-Id: <1552323335-46779-9-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1552323335-46779-1-git-send-email-pbonzini@redhat.com> References: <1552323335-46779-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::343 Subject: [Qemu-devel] [PULL v2 08/31] configure: Enable werror for git worktrees X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexey Kardashevskiy Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Alexey Kardashevskiy The configure script checks multiple times whether it works in a git repository and it does this by "test -e "${source_path}/.git" in 4 cases but in one case where it tries to enable werror "-d" is used there which fails on git worktrees as .git is a file then and not a directory. This changes the test to "-e" as other occurrences. Signed-off-by: Alexey Kardashevskiy Message-Id: <20190228043503.68494-1-aik@ozlabs.ru> Signed-off-by: Paolo Bonzini --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index b354e74..fa83e21 100755 --- a/configure +++ b/configure @@ -1836,7 +1836,7 @@ fi # Consult white-list to determine whether to enable werror # by default. Only enable by default for git builds if test -z "$werror" ; then - if test -d "$source_path/.git" && \ + if test -e "$source_path/.git" && \ { test "$linux" =3D "yes" || test "$mingw32" =3D "yes"; }; then werror=3D"yes" else --=20 1.8.3.1