From nobody Tue Feb 10 01:16:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552324629104219.53384251257035; Mon, 11 Mar 2019 10:17:09 -0700 (PDT) Received: from localhost ([127.0.0.1]:37118 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3OXs-00085D-3a for importer@patchew.org; Mon, 11 Mar 2019 13:17:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3ODS-0006yQ-Ho for qemu-devel@nongnu.org; Mon, 11 Mar 2019 12:55:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3ODQ-0002xd-Fe for qemu-devel@nongnu.org; Mon, 11 Mar 2019 12:55:54 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:44027) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h3ODM-0002t1-Rb for qemu-devel@nongnu.org; Mon, 11 Mar 2019 12:55:50 -0400 Received: by mail-wr1-x42a.google.com with SMTP id d17so5927533wre.10 for ; Mon, 11 Mar 2019 09:55:47 -0700 (PDT) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id e12sm6484836wrs.91.2019.03.11.09.55.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Mar 2019 09:55:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=EbLP00A4BLiP9DapEqSnouNkDQH3tjoU/b+1XsA4uo8=; b=tpjHknsd95G7M4dmP+ZJAoaZZZUknccADbsO9Z4uREQE+Yyx3LlTRkNblXAKDucltg muzffyknGKVgszRm8M9fUXOMlFdkFXWLuF5N+1S62WQKO7S2EDZRsnu3w4tCRyAyRAc8 4MU+/8qqF9duMUpDqHmh4vUYC4dH52JPi6kfmtTS57cgrKyT+QpJjUuz+msyPINDz7Dn R8I+LWCXCrbpTvRfOXVIKGnMwj9rNWJoL/8v19q9bSWmausxMJxUYKUDjodOPxM/ZXji aqSmV7xlT3Y+wZGr/ARUi0XLP+AuyMkR2mHgMQTwNUt0IK+SHRv3x1soZiKQit5pTo2C sY3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=EbLP00A4BLiP9DapEqSnouNkDQH3tjoU/b+1XsA4uo8=; b=jMIYlUAkhhKtTFYtZVINqE1+VW1wx3pm3LV2xS23D76fFILQS9FZ5zBME6Oki5n5BH mGXLrrbOjKTvjM/BPtAnP5/bB/6K3OEfUgUCR50O8u9ENTkwJg6gEaWps10eUGbGvlP2 auU/n507qpW1f5ED+3845uNckVAVpLvXl+rwzSAoSV496vFErwdgDSNFvjdy8jZpPcQ5 KGK039cfXQO6UaieqiKvjjgwWrew5p+3znf9j4VqGLvxn0dWzr4hMhU0d065D658j2xn qnfuLxdAPqEB+dOkVelaFcw1WCNfAXYdoD9SkbdkshQQhbCMgqt0BY4/zWgkTCZ4h+ah lixQ== X-Gm-Message-State: APjAAAV1wC6/DTJ0dzh9p9yFRr0VIhpvIdySj4DbHF7+YVLKhEBXT4UC hZurTRLKayqDM1BGbM42XS6Bcb8U X-Google-Smtp-Source: APXvYqxBO5f2QRdw8GtX/GJ6y0rncZphURYaF8zDQWBslY9/mcuz7JVdzQiufpQEo/t0pGIBfSeLeQ== X-Received: by 2002:a05:6000:1152:: with SMTP id d18mr21820699wrx.128.1552323346264; Mon, 11 Mar 2019 09:55:46 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 11 Mar 2019 17:55:11 +0100 Message-Id: <1552323335-46779-8-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1552323335-46779-1-git-send-email-pbonzini@redhat.com> References: <1552323335-46779-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42a Subject: [Qemu-devel] [PULL v2 07/31] contrib/elf2dmp: add kernel start address checking X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Viktor Prutyanov Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Viktor Prutyanov Before this patch, if elf2dmp failed to find NT kernel PE magic in allowed virtual address range, then it assumes NULL as NT kernel address and cause segfault. This patch fix the problem described above by checking NT kernel address before futher processing. Signed-off-by: Viktor Prutyanov Message-Id: <20190219211936.6466-1-viktor.prutyanov@phystech.edu> Signed-off-by: Paolo Bonzini --- contrib/elf2dmp/main.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/contrib/elf2dmp/main.c b/contrib/elf2dmp/main.c index 1a45eaf..1bfeb89 100644 --- a/contrib/elf2dmp/main.c +++ b/contrib/elf2dmp/main.c @@ -524,6 +524,12 @@ int main(int argc, char *argv[]) } } =20 + if (!nt_start_addr) { + eprintf("Failed to find NT kernel image\n"); + err =3D 1; + goto out_ps; + } + printf("KernBase =3D 0x%016"PRIx64", signature is \'%.2s\'\n", KernBas= e, (char *)nt_start_addr); =20 --=20 1.8.3.1