From nobody Mon Feb 9 10:12:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552324840982461.00475450465876; Mon, 11 Mar 2019 10:20:40 -0700 (PDT) Received: from localhost ([127.0.0.1]:37151 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3ObM-0002OC-Se for importer@patchew.org; Mon, 11 Mar 2019 13:20:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3ODq-0007N9-CA for qemu-devel@nongnu.org; Mon, 11 Mar 2019 12:56:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3ODm-0003iP-Qw for qemu-devel@nongnu.org; Mon, 11 Mar 2019 12:56:17 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:38950) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h3ODk-0003bz-Se for qemu-devel@nongnu.org; Mon, 11 Mar 2019 12:56:14 -0400 Received: by mail-wr1-x434.google.com with SMTP id p8so4335160wrq.6 for ; Mon, 11 Mar 2019 09:56:11 -0700 (PDT) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id e12sm6484836wrs.91.2019.03.11.09.56.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Mar 2019 09:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ASyHtr3XxDb/3QnswjqQRSY/+KGBPjflbxqM9L5GZLY=; b=om9erKUZj7o1+EEx1jaJb3+037flLt18XehQvNjGHSUYdLBHvNOZ9qCieUTzAJnrMU KIBXyMaLncVMKKcOmO3p4OmYVEk52JX2bfRzza9KoEqCt2Oqt9vIgrdntrrfwVqxsKZm 0iZPRTc4crAsGmG/oL6Y7RFER0N8jrYU8Hf5D18FLQZt8w66DB6ZG95VhoziO3V8X9T/ E3+zNDlzC3bLfa1/hwhjTU/tsWkBcBwbHbIPUv3KE/D5SsyKAQyTmUkCguWeJKGo32ap ckCw29wz9NzsCer1wBdONi3H4LSkE66PCrGcVVO3qhYFtKxbO/NYIjgoa8EYo3qz29R0 3ivg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ASyHtr3XxDb/3QnswjqQRSY/+KGBPjflbxqM9L5GZLY=; b=NAN9BZuB4CVjdZokTkm6oLeVhFqrRblFL+GW9rkKuxr9dLPCS7uugrqbgaycDN2bE5 NantaYK7laJHARxRMN6yo1Vb+PVeFUq8f7hYBiDA/esfcopvSL89nNNsNRIyUC5YOcpt NH7FpPl/FUlxNT21KxsBeR/Vgjbv+h7RO5DIJDLQFCw8mubzHeGknWg81haShjOuwaZm eR/tonfl8yNKskPR4oT5ImYFao0kCZuvoncO5nsEQXkB0gaI0qhcoDuLJDYRQ4srBwF/ PMtE6aUracjBU7WMv3tzjNuIqq1T0b+rNArZ7PEIqWlLPYtRUNWcvVIyVuXPF80oFnrf 9+Xw== X-Gm-Message-State: APjAAAW5PdYgazU+GZOlnRAaTs94M7FOaFU/kRBL0uQeIobGdRh3y10k HlW4WZF9u1nXqFYwbzbtECu81/oK X-Google-Smtp-Source: APXvYqxpJRncft6gb2nLCl5SGxqlrgEcqwuGRsWK+hhZJ9kovicnwkSm2W1AIkeV8pSw1QchTyd0lg== X-Received: by 2002:adf:e3d1:: with SMTP id k17mr20432409wrm.143.1552323369847; Mon, 11 Mar 2019 09:56:09 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 11 Mar 2019 17:55:33 +0100 Message-Id: <1552323335-46779-30-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1552323335-46779-1-git-send-email-pbonzini@redhat.com> References: <1552323335-46779-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::434 Subject: [Qemu-devel] [PULL v2 29/31] qom: cpu: destroy work_mutex in cpu_common_finalize X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Li Qiang Commit 376692b9dc6(cpus: protect work list with work_mutex) initialize a work_mutex in cpu_common_initfn, however forget to destroy it. This will cause resource leak when hotunplug cpu or hotplug cpu fails. Signed-off-by: Li Qiang Message-Id: <20190102074114.26988-1-liq3ea@163.com> Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Paolo Bonzini --- qom/cpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qom/cpu.c b/qom/cpu.c index f5579b1..a8d2958 100644 --- a/qom/cpu.c +++ b/qom/cpu.c @@ -380,6 +380,9 @@ static void cpu_common_initfn(Object *obj) =20 static void cpu_common_finalize(Object *obj) { + CPUState *cpu =3D CPU(obj); + + qemu_mutex_destroy(&cpu->work_mutex); } =20 static int64_t cpu_common_get_arch_id(CPUState *cpu) --=20 1.8.3.1