From nobody Mon Feb 9 11:32:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552323882431330.62628396212347; Mon, 11 Mar 2019 10:04:42 -0700 (PDT) Received: from localhost ([127.0.0.1]:36920 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3OLv-0005NE-Br for importer@patchew.org; Mon, 11 Mar 2019 13:04:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3ODF-0006j0-QT for qemu-devel@nongnu.org; Mon, 11 Mar 2019 12:55:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3ODF-0002nb-4L for qemu-devel@nongnu.org; Mon, 11 Mar 2019 12:55:41 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:37343) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h3ODE-0002mw-Sj for qemu-devel@nongnu.org; Mon, 11 Mar 2019 12:55:41 -0400 Received: by mail-wr1-x436.google.com with SMTP id y15so4133155wro.4 for ; Mon, 11 Mar 2019 09:55:40 -0700 (PDT) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id e12sm6484836wrs.91.2019.03.11.09.55.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Mar 2019 09:55:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=yQ26pOTy7P4ofiTlf/SZaifTVQD5oVp7I02mOeiuF9I=; b=hZOUlZWeCEEX+AtZpcOqSSEH8KwFfoLuRbAjDT/oRQTakoAnNmjD/xDsvaeQWx7mT5 /ThuYRmYdzTaSlLfUgKEFjkAhd///x52FBx9a+/5ed0qXHNqjm0Bcr9AgQrgcXXm3soA G3okjjbZLX/X5Wo6Vda48qJTVCwuRhCoGaULGZElnnc8VqtyTqTLMfmfgabAMSKa/tjD Mnk+e1+H0vkZUrTWRx704ajAfjoAX2re4b8spz9ygzdud+3biRzSKwdgCQnkL1MDtsjx rQxgyCo+DBz5/sSMIFgpz3Knkivl7nw2OxWwtCuQM8PpFyahY3evEdO4RFv3amH97zUU xpLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=yQ26pOTy7P4ofiTlf/SZaifTVQD5oVp7I02mOeiuF9I=; b=Qg3yehgVSFnrdOqtLqa8FQdkSkDaT7g9kS7CzlCbOSz+htFo3jNkMTMsksEDRdrpgJ t91dvRtd6stUYP0d8ZQxN3SUVj1GgtR+Hjcux4GhYpOpz9rbVfJBuxnWqt70Ft3Xu5mL dXbfuTItqOyGQ0/JHzYH2JQF3uTV8UIAj04/ztAmItRYGJoAtMcfZZVkFKv9gq88wxIj PkP2no7/hNuNwP1FlCHDxf7R07Cx8KAzTaPZVGcfrv1ABCrkbcsvziuXG8l4SMZkmiki yT4MaBYCx+Gq40PgPwF8Ppupy6XY/nT2H67/0fiGxcAiOGLZtR8e/bwQ3EmX2yeHAiEY tzWA== X-Gm-Message-State: APjAAAXKOiF6EaGPFIl48YpcjG0vb/ZoJU4Ulf5xHqjjvb/+seoVIAyf CeXMkhl8SbORm5hsCcfux55t0Fmv X-Google-Smtp-Source: APXvYqzbnLryiYUg3iTlk+EWoj2VgdfU+Um6GhxzvOfcQdf3D1qw8wDwuCWAHqIFfhEZcViIINqgag== X-Received: by 2002:a5d:6207:: with SMTP id y7mr20185771wru.60.1552323339435; Mon, 11 Mar 2019 09:55:39 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 11 Mar 2019 17:55:05 +0100 Message-Id: <1552323335-46779-2-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1552323335-46779-1-git-send-email-pbonzini@redhat.com> References: <1552323335-46779-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::436 Subject: [Qemu-devel] [PULL v2 01/31] memory: Do not update coalesced IO range in the case of NOP X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jagannathan Raman Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Jagannathan Raman Do not add/del coalesced IO ranges in the case where the same FlatRanges are present in both old and new FlatViews Fixes: 3ac7d43a6fbb ("memory: update coalesced_range on transaction_commit") Signed-off-by: Jagannathan Raman Message-Id: <59572a7353830be4b7aa57d79ccb7ad6b72f0dda.1549406119.git.jag.ra= man@oracle.com> Signed-off-by: Paolo Bonzini --- memory.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/memory.c b/memory.c index 61d66e4..e49369d 100644 --- a/memory.c +++ b/memory.c @@ -932,9 +932,7 @@ static void address_space_update_topology_pass(AddressS= pace *as, } else if (frold && frnew && flatrange_equal(frold, frnew)) { /* In both and unchanged (except logging may have changed) */ =20 - if (!adding) { - flat_range_coalesced_io_del(frold, as); - } else { + if (adding) { MEMORY_LISTENER_UPDATE_REGION(frnew, as, Forward, region_n= op); if (frnew->dirty_log_mask & ~frold->dirty_log_mask) { MEMORY_LISTENER_UPDATE_REGION(frnew, as, Forward, log_= start, @@ -946,7 +944,6 @@ static void address_space_update_topology_pass(AddressS= pace *as, frold->dirty_log_mask, frnew->dirty_log_mask); } - flat_range_coalesced_io_add(frnew, as); } =20 ++iold; --=20 1.8.3.1