From nobody Sun Nov 9 23:02:29 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552118416253321.2323561810531; Sat, 9 Mar 2019 00:00:16 -0800 (PST) Received: from localhost ([127.0.0.1]:55398 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2Wtw-0004cu-5L for importer@patchew.org; Sat, 09 Mar 2019 03:00:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2Wih-0003tK-EF for qemu-devel@nongnu.org; Sat, 09 Mar 2019 02:48:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2Wig-0000WM-4Q for qemu-devel@nongnu.org; Sat, 09 Mar 2019 02:48:35 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:36839) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h2Wif-0000Nx-7j for qemu-devel@nongnu.org; Sat, 09 Mar 2019 02:48:34 -0500 Received: by mail-wr1-x444.google.com with SMTP id o17so23668688wrw.3 for ; Fri, 08 Mar 2019 23:48:26 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id 11sm5252294wmg.27.2019.03.08.23.48.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 23:48:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Z71wi9k2aAi0+2DvbEnqT56WoXDZVpAnTd+sSqaC6T8=; b=NeLzo7dFPPO32ItEpAOOTuWZc1NDgTPpfhR6hEZXBPIV9VZpKewfPXbPMshXZSqOE1 N84J+xg37OnTqSUkoHgqrQi5ybantsLdzQPxz0BrnIlF9Ajw//6Z+QSfgqQukDfx+GrF 2uXN06Bmhc2N3SSOCIojTKYE5CP9LyCf0orb2ngGGhBSLmjMnwVb/LP3HYRmeuOe/VxR 6ZtSJxDNZUXEKnbNOfbYIaS1FVYgJsYcsPCqk+C6H9MoPUcwhj1bOlzfKliSl9pqgB1C MJWsqgHBme3yDp9olGXD/U1XSQCYX9N+eulzMC82lpts0+indyiCNWgSRh8cXANw5T+W rPWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Z71wi9k2aAi0+2DvbEnqT56WoXDZVpAnTd+sSqaC6T8=; b=I75Kvg27+ER5wElckdlock1orRn78XVPF/HZ/yTQa1bkvZxXRq5N5hMgS4ETXo/seJ QVLaxWBct7DBqzZwVaJM8mzbqR9HncRJMY2auds5TRHU/ZS6f9w1t8DUcP1C3+B3nPlo rJ8eobHu99B7BTFWNGjElrMYlyXVYYlxh5fvQR3cPpaACnj7/hColKLIWUaDjdhD1rp2 AQ+1z8RUJbNJ57IRbZYfDXkmINN3rO6azC1PcGwNMjjEIYa7yWc+O3SdKVAug+L0DaMo JLOPce9yWeU27lKob7LZZePelzxdkIBUHeOg/EoyNwYIPZWY2dhHMpTdlvpNJTXT09Cs O2/g== X-Gm-Message-State: APjAAAWMsLfyIWyNB3V7RAW7M1EFfeKyCY6AazVnFwlkuEhzOA+iapG9 p9JdC4t/+wTYKWcT1c7mvBkKkAyP X-Google-Smtp-Source: APXvYqzsDgf2tqHucpE2bM63uFZaAW4Sm7nVZfR0+C6enlYLVZ1AA2QQRICTQrm+6dqQ9y87ZX2NLQ== X-Received: by 2002:adf:f40d:: with SMTP id g13mr13550775wro.18.1552117705135; Fri, 08 Mar 2019 23:48:25 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sat, 9 Mar 2019 08:47:59 +0100 Message-Id: <1552117698-12355-7-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1552117698-12355-1-git-send-email-pbonzini@redhat.com> References: <1552117698-12355-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PULL 06/25] configure: Enable werror for git worktrees X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexey Kardashevskiy Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Alexey Kardashevskiy The configure script checks multiple times whether it works in a git repository and it does this by "test -e "${source_path}/.git" in 4 cases but in one case where it tries to enable werror "-d" is used there which fails on git worktrees as .git is a file then and not a directory. This changes the test to "-e" as other occurrences. Signed-off-by: Alexey Kardashevskiy Message-Id: <20190228043503.68494-1-aik@ozlabs.ru> Signed-off-by: Paolo Bonzini --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 79453a6..c9a260c 100755 --- a/configure +++ b/configure @@ -1836,7 +1836,7 @@ fi # Consult white-list to determine whether to enable werror # by default. Only enable by default for git builds if test -z "$werror" ; then - if test -d "$source_path/.git" && \ + if test -e "$source_path/.git" && \ { test "$linux" =3D "yes" || test "$mingw32" =3D "yes"; }; then werror=3D"yes" else --=20 1.8.3.1