From nobody Sun Nov 9 22:58:53 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552118766492142.81602233850867; Sat, 9 Mar 2019 00:06:06 -0800 (PST) Received: from localhost ([127.0.0.1]:55549 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2Wza-0000tP-FW for importer@patchew.org; Sat, 09 Mar 2019 03:06:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2Wip-0003yy-PT for qemu-devel@nongnu.org; Sat, 09 Mar 2019 02:48:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2Wip-0000gm-69 for qemu-devel@nongnu.org; Sat, 09 Mar 2019 02:48:43 -0500 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:34146) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h2Wio-0000fj-VN for qemu-devel@nongnu.org; Sat, 09 Mar 2019 02:48:43 -0500 Received: by mail-wr1-x432.google.com with SMTP id f14so23644780wrg.1 for ; Fri, 08 Mar 2019 23:48:42 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id 11sm5252294wmg.27.2019.03.08.23.48.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 23:48:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=MVbKGZ5IZNniHsdQwSGV9lfa6JW/VzOYJ/nU6DXVyag=; b=oGDB7RQkutifDL/7TALzZex5Vld6VBgAswSKBmO+hGHAzi+fE1Jhrhk4RzSrOCSGpT ndFNMwdw3WtTubpsUqrWw7AHi5VpF/KCZXVCie1dTxqQvtWql2RrUsIMArTtO+YuKS76 yqx3FfC4s+0ZlWsczRejrbVfEeND3O2vwmVqkkLUH8J9u3qj5XJu2criGPMSvnB9NWEo v5eKDMpK7tLpJ0C8H/9mAg8gl5gAUckbQ1Okl85c7VklGagzvOameER0q7i3NoiTXH74 hsK5dNFdukaPUZSYcBqWKTaSalnoOf8XZ91F0tnOHxr8reGWSIeFelCVLnXsu0PgkiMY A8xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=MVbKGZ5IZNniHsdQwSGV9lfa6JW/VzOYJ/nU6DXVyag=; b=OD9ikg2Or46tu4HgMCBIF8zWS54sav4nQX7CWg3GYNdhDdJ2An3IO0kjUOEt6S03ID t/PGB7umw7HEfz5sZ9H0NeoKkSshrxlpTheU6JSqZckB/6ZF3ciD7qMFiifV2p7SAyAL dXEGumOq8U0UfH6PfcDisHH/+uYqmJ0Pw/fXDjrZMFXapINlq6nqACY8MuEg0/WS/oDD LqdHXiXSJWyqgHJzP7Nx24XPhRFF3XrPUM1zvgC/MPBv3m73Nx8/EiRObcaaOl3zk5Li pHAHlz3Xl5z/ZzP/sVZZR9sz/UWQHyAg9CLs9h4MmOZ0QZHNuxj/9GjuOq+d97DAwkEj rhIQ== X-Gm-Message-State: APjAAAUFttFCdPd0flp2UkopEnHm3Igf6HWqh+Qj24FIJXaWY4dGygE1 B779R87idpOulQYFY6UqteAIA2id X-Google-Smtp-Source: APXvYqzDBJmDF4mkW2wkTj0QNjiEATbPGx3S0SZRwG2NQomezZf4XL5tEEfWIh3Tbf/pu0enufxmuQ== X-Received: by 2002:a5d:5386:: with SMTP id d6mr13026753wrv.104.1552117721802; Fri, 08 Mar 2019 23:48:41 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sat, 9 Mar 2019 08:48:17 +0100 Message-Id: <1552117698-12355-25-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1552117698-12355-1-git-send-email-pbonzini@redhat.com> References: <1552117698-12355-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::432 Subject: [Qemu-devel] [PULL 24/25] lsi: return dfifo value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sven Schnelle Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Sven Schnelle Code was assigning DFIFO, but didn't return the value to users. Signed-off-by: Sven Schnelle Message-Id: <20190305195519.24303-6-svens@stackframe.org> --- hw/scsi/lsi53c895a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index 66f217f..bf6b6a5 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -1688,7 +1688,7 @@ static uint8_t lsi_reg_readb(LSIState *s, int offset) break; CASE_GET_REG32(temp, 0x1c) case 0x20: /* DFIFO */ - ret =3D 0; + ret =3D s->dfifo; break; case 0x21: /* CTEST4 */ ret =3D s->ctest4; --=20 1.8.3.1