From nobody Sun Nov 9 17:52:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=wbowling.info Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1551491967295538.3434634301051; Fri, 1 Mar 2019 17:59:27 -0800 (PST) Received: from localhost ([127.0.0.1]:46959 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gztvw-0004nf-Bh for importer@patchew.org; Fri, 01 Mar 2019 20:59:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzpzL-0001fB-FJ for qemu-devel@nongnu.org; Fri, 01 Mar 2019 16:46:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gzpzK-0005By-9J for qemu-devel@nongnu.org; Fri, 01 Mar 2019 16:46:39 -0500 Received: from wbowling.info ([2400:8901::f03c:91ff:fe59:6f11]:51508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzpzG-0004wT-TF for qemu-devel@nongnu.org; Fri, 01 Mar 2019 16:46:38 -0500 Received: by wbowling.info (Postfix, from userid 1004) id 623F515890; Fri, 1 Mar 2019 21:46:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wbowling.info; s=mail; t=1551476789; bh=zUYII1d7NL0CO+XzFnIg0QCpboLwU5Du0wppUCh45Tk=; h=From:To:Cc:Subject:Date:From; b=PYjSGAuczlI4xRW2yGGMhtroagS2JtWKjRSHnqY0CdiUmep7zXGQbn+qYm2auNUXk 7w3zRXre1tkYTzuoWI9Ezvm8HE99Xin23ZyoYUNIMnH80Cj1o/CggvW9BRY9Zy7z5y JayCWugnx4evhNYOeygGfd0G0mR+1j5tq0SRuto0= From: William Bowling To: qemu-devel@nongnu.org Date: Fri, 1 Mar 2019 21:45:56 +0000 Message-Id: <1551476756-25749-1-git-send-email-will@wbowling.info> X-Mailer: git-send-email 2.7.4 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2400:8901::f03c:91ff:fe59:6f11 X-Mailman-Approved-At: Fri, 01 Mar 2019 20:55:59 -0500 Subject: [Qemu-devel] [PATCH] slirp: check sscanf result when emulating ident X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: William Bowling , secalert@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When emulating ident in tcp_emu, if the strchr checks passed but the sscanf check failed, two uninitialized variables would be copied and sent in the reply. Signed-off-by: William Bowling Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- slirp/tcp_subr.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c index 262a42d6c8..73a160ba16 100644 --- a/slirp/tcp_subr.c +++ b/slirp/tcp_subr.c @@ -664,12 +664,12 @@ tcp_emu(struct socket *so, struct mbuf *m) break; } } - } - so_rcv->sb_cc =3D snprintf(so_rcv->sb_data, - so_rcv->sb_datale= n, - "%d,%d\r\n", n1, = n2); - so_rcv->sb_rptr =3D so_rcv->sb_data; - so_rcv->sb_wptr =3D so_rcv->sb_data + so_rcv->sb_cc; + so_rcv->sb_cc =3D snprintf(so_rcv->sb_data, + so_rcv->sb_datalen, + "%d,%d\r\n", n1, n2); + so_rcv->sb_rptr =3D so_rcv->sb_data; + so_rcv->sb_wptr =3D so_rcv->sb_data + so_rcv->sb_cc; + } } m_free(m); return 0; --=20 2.15.1