From nobody Fri May 3 20:47:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1550229153980931.8938163032888; Fri, 15 Feb 2019 03:12:33 -0800 (PST) Received: from localhost ([127.0.0.1]:37263 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gubPy-0007Lr-Vr for importer@patchew.org; Fri, 15 Feb 2019 06:12:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gubGV-0007Vx-9c for qemu-devel@nongnu.org; Fri, 15 Feb 2019 06:02:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gub3t-0005Hk-DF for qemu-devel@nongnu.org; Fri, 15 Feb 2019 05:49:42 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:35409) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gub3s-00048X-Uf for qemu-devel@nongnu.org; Fri, 15 Feb 2019 05:49:41 -0500 Received: by mail-wr1-x442.google.com with SMTP id t18so9867269wrx.2 for ; Fri, 15 Feb 2019 02:49:23 -0800 (PST) Received: from 640k.localdomain ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id w3sm2788206wrl.22.2019.02.15.02.49.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Feb 2019 02:49:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=/25WP1AhLK8pW6C0nHqelXnJ8/TcV/Z5dwS91/Fju7I=; b=eiSoJdWeLy8n8Hed96JWFREfrRJLYo/HgFgphTfUOLKOekEbTOiNc9omruJOIOc3e9 37eHGuqhhuonNycudeojpWmvhy45pxR0srBv4akKpmLlthbud4RnC5Crv+xf8euyCXSj WHrO5Vlq0jmyDOjX9F6Qa0AC+zoRYokV0fmxvKI+n+00eKMNgp/Fh9vdGWTniEvTsGlP nWPji37Qbq2MTslQdYLoBgYkto7UfOBMc2WUTYrknIzRfYHMSLcVTd0K6gvYtecVH+7O MuXt1gT06TCQ6P3ZRj9Cj2fN4/AsfzU9RP+EwEmicv0TfVUvUtvfSAPiu9E9e3zNamZP 35Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=/25WP1AhLK8pW6C0nHqelXnJ8/TcV/Z5dwS91/Fju7I=; b=UO5RKU8oDoO/OdJ2XEMWl09JEvwUqFIWtY2cuMbPxGH7npDM9oYbDLMc1AF5Kxzx4y sLJTeLsRj2+C0thvNZvvffIH1W2eObrdfPBDmfGRIO8XOfSlinykaNHnToWQEhFf6yVB mdAPhvpMAwvlWVdh1GaxrDSFBpWJCIuEvP4Ft9asaMs0E9nZYDO8FBbXH0kg9QOWNZET bwadZbToOyfPKbxVo3/Tf2thjs8kEKmqixyHfTy+cZSh5ExSbc5qpPOMDS7N9hDdjKFu I5S1jckleH2Qv1F8BPO3KOQDHbsuDrfEo/w+dIU/jNmYCSxm1NQwzyHc3v00XS+fzKNF JX/g== X-Gm-Message-State: AHQUAuabBXbTCWnf5AXLC0IGMUFF9IwCORsmT+sEzKRJlJqanf+ieBv7 Gp1XZuzeqiPj6acD89UyZ3yLY48U X-Google-Smtp-Source: AHgI3IZAhBr5J5EcA4gjKDHW/x5SzrcQuS9RDIpHdQAqrx/STlMEwO1rD3lX0oEA5PiSrM1rLBd8qw== X-Received: by 2002:adf:9d1d:: with SMTP id k29mr6107877wre.211.1550227761012; Fri, 15 Feb 2019 02:49:21 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Fri, 15 Feb 2019 11:49:16 +0100 Message-Id: <1550227757-10869-2-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH] build: remove unnecessary assignments from Makefile.target X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: armbru@redhat.com, stefanha@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" It is only necessary to clear block-obj-y because Makefile.objs uses "+=3D" instead of "=3D"; fix that and remove the assignment. The other variables need not be cleared at all. Signed-off-by: Paolo Bonzini Reviewed-by: Liam Merwick Reviewed-by: Markus Armbruster --- Makefile.objs | 2 +- Makefile.target | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index c3a2354..e5cc928 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -22,7 +22,7 @@ slirp-obj-$(CONFIG_SLIRP) =3D slirp/ ####################################################################### # block-obj-y is code used by both qemu system emulation and qemu-img =20 -block-obj-y +=3D nbd/ +block-obj-y =3D nbd/ block-obj-y +=3D block.o blockjob.o job.o block-obj-y +=3D block/ scsi/ block-obj-y +=3D qemu-io-cmds.o diff --git a/Makefile.target b/Makefile.target index a56a72f..06b44c0 100644 --- a/Makefile.target +++ b/Makefile.target @@ -174,10 +174,6 @@ endif # CONFIG_SOFTMMU dummy :=3D $(call unnest-vars,,obj-y) all-obj-y :=3D $(obj-y) =20 -block-obj-y :=3D -common-obj-y :=3D -chardev-obj-y :=3D -slirp-obj-y :=3D include $(SRC_PATH)/Makefile.objs dummy :=3D $(call unnest-vars,.., \ block-obj-y \ --=20 1.8.3.1