From nobody Sat Feb 7 01:42:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=oracle.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1549460653939771.113620793704; Wed, 6 Feb 2019 05:44:13 -0800 (PST) Received: from localhost ([127.0.0.1]:51176 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grNUm-0001oQ-VM for importer@patchew.org; Wed, 06 Feb 2019 08:44:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grNOl-0005Uu-1w for qemu-devel@nongnu.org; Wed, 06 Feb 2019 08:37:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1grNOg-0003sJ-97 for qemu-devel@nongnu.org; Wed, 06 Feb 2019 08:37:54 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:36450) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1grNOd-0003nD-9H for qemu-devel@nongnu.org; Wed, 06 Feb 2019 08:37:47 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x16DTWuY156395; Wed, 6 Feb 2019 13:37:21 GMT Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2qd98n906u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 06 Feb 2019 13:37:20 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x16DbK3p025697 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 6 Feb 2019 13:37:20 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x16DbK4P016034; Wed, 6 Feb 2019 13:37:20 GMT Received: from ol7.nl.oracle.com (/10.175.12.46) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 06 Feb 2019 05:37:19 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2018-07-02; bh=tE23AFN35BmibHukrgyis8lru1bp1Uague0Zfo9njVI=; b=QdphtUDhqO3i8FtMI+E0sTwDTU/Kj2YkV5Gn9r1DR2/HrpjN4LLpLTLbR9OY7t57PSfR ZhEimWC3BKXwnlmkZFJRV+Sdi0UZ5Jwd0knEE70zr1gJlib0iabAmAuNp3/m01ueOGAe oo6zqllVEhA5m0dEX7urkp+uOigXlFqwYZ3tKxMyqkkikdB7SevZYkm8O7r0BpVJyClr z3heXpbK14L9FZ1767C31qFFLziuxSWbjzZ61WLQy9/vJFyp7FVEYL+Xu8bP47stbmdJ PCv4LnetyhwPTu7rz3T74+Jk+3SvCi3mOZbDZosHgs7FXqVAcwZkXtShPZKmRjWUtXg9 Tg== From: Liam Merwick To: kraxel@redhat.com, qemu-devel@nongnu.org Date: Wed, 6 Feb 2019 13:36:56 +0000 Message-Id: <1549460216-25808-10-git-send-email-liam.merwick@oracle.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1549460216-25808-1-git-send-email-liam.merwick@oracle.com> References: <1549460216-25808-1-git-send-email-liam.merwick@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9158 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902060107 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 156.151.31.85 Subject: [Qemu-devel] [PATCH v2 9/9] usb: remove unnecessary NULL device check from usb_ep_get() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: darren.kenny@oracle.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" No caller of usb_ep_get() calls it with a NULL device (previous commits have addressed the few remaining cases which didn't explicitly check). Replace check for 'dev =3D=3D NULL' with an assert instead. Signed-off-by: Liam Merwick --- hw/usb/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/usb/core.c b/hw/usb/core.c index bfb7ae67bbf0..8fbd9c7d573b 100644 --- a/hw/usb/core.c +++ b/hw/usb/core.c @@ -717,9 +717,7 @@ struct USBEndpoint *usb_ep_get(USBDevice *dev, int pid,= int ep) { struct USBEndpoint *eps; =20 - if (dev =3D=3D NULL) { - return NULL; - } + assert(dev !=3D NULL); if (ep =3D=3D 0) { return &dev->ep_ctl; } --=20 1.8.3.1