From nobody Tue Feb 10 06:27:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1549309092213116.76398863252746; Mon, 4 Feb 2019 11:38:12 -0800 (PST) Received: from localhost ([127.0.0.1]:48230 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqk4D-0005qc-Sj for importer@patchew.org; Mon, 04 Feb 2019 14:38:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60150) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqj7x-00067N-Rt for qemu-devel@nongnu.org; Mon, 04 Feb 2019 13:37:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gqj7v-0004I4-RS for qemu-devel@nongnu.org; Mon, 04 Feb 2019 13:37:53 -0500 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:39232) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gqj7v-00046r-5Q for qemu-devel@nongnu.org; Mon, 04 Feb 2019 13:37:51 -0500 Received: by mail-wr1-x430.google.com with SMTP id t27so956001wra.6 for ; Mon, 04 Feb 2019 10:37:38 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id s132sm8836236wmf.28.2019.02.04.10.37.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 10:37:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=ewZofejI6sRCYvM4GkIU31Xd9qiT/N5UGG3udpNPqoM=; b=eQMZ22OvsGl6hPdCaIiUNvBjg4gG1/Dbr96YNkx5AzHGtWWclGXJhHg70ZWvLdhHeO KsaGumRPxAzRctpJYEEkMh3jGaftDK5D8xWAaLtvjS2awPXNipXHdq8AROE4BN7CPhv/ fFKYHe6IOo8PjqgqHvrR0xMKYf+W5osio3SwyAo00v3e15aMbGvVPEYc+bQpx+Dr68U7 2/fjUatungF33BINTTgCXwLusl+dn0Vgk9tD/5FNXajI9XLYMBzteakzAt/gnUk86G8V M/U1ufwCCxd/OM/CXKaY9M18GMd1lCIz9XMsVS1ne2s6gquvlA4kuShCkRfEU/mspTPn UJ8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=ewZofejI6sRCYvM4GkIU31Xd9qiT/N5UGG3udpNPqoM=; b=VOmSFfMePYg9j7CD/1yjHX0+E9iA/XrwjFTWX+tHL3x7RGMx17hiX5clPf/vThkYdW MCdFtY+3cjqeAZUj6PTTIzv1m2bkCZJXN5eW+QD+112oT/ZTirDeAJJ71IZMTAlltutt CS9Gx/aK+nkcR2L0hsPvGLRtV244ydOJOZENd7HXjTLoVbksMDzFe7qWfX4YVIjgOIAt VU8w599sQl17hBkMSVQUe6C/nqfox8C7gO4KsfNR74expa8fd351LIglxFun5ic79FRV CSKtVqJ4CQoyHHHpoDksQUB/1djdc05qZa6tE49Tr5j1HPv/84KgLJxYtFDsYwGrh4vy UHjQ== X-Gm-Message-State: AHQUAubs8TbQNoMpEyoy2hGuH+hRpSRESxTnOf+BVqNAXkkHzaF9ZnfR rRRpq0/IlTjaaPwKKQK678JsHwW2 X-Google-Smtp-Source: AHgI3IZ5eik+joZxolSDtLwRGDdYhgDBAQLdB3cuikdF4UwOoT4xw6g7xLvmSOUqMWTP4KKJX6xFvA== X-Received: by 2002:adf:8068:: with SMTP id 95mr559340wrk.181.1549305456957; Mon, 04 Feb 2019 10:37:36 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 4 Feb 2019 19:36:19 +0100 Message-Id: <1549305379-51117-78-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1549305379-51117-1-git-send-email-pbonzini@redhat.com> References: <1549305379-51117-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::430 Subject: [Qemu-devel] [PULL 77/77] queue: fix QTAILQ_FOREACH_REVERSE_SAFE X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The iteration was stopping as soon as prev_var was set to NULL, and therefore it skipped the first element. Fortunately, or unfortunately, we have only one use of QTAILQ_FOREACH_REVERSE_SAFE. Thus this only showed up as incorrect register preferences on the very first translation block that was compiled. Reported-by: Thomas Huth Reviewed-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- include/qemu/queue.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/queue.h b/include/qemu/queue.h index 1f8e219..0379bd8 100644 --- a/include/qemu/queue.h +++ b/include/qemu/queue.h @@ -439,7 +439,7 @@ union { = \ =20 #define QTAILQ_FOREACH_REVERSE_SAFE(var, head, field, prev_var) \ for ((var) =3D QTAILQ_LAST(head); \ - (var) && ((prev_var) =3D QTAILQ_PREV(var, field)); \ + (var) && ((prev_var) =3D QTAILQ_PREV(var, field), 1); \ (var) =3D (prev_var)) =20 /* --=20 1.8.3.1