From nobody Mon Feb 9 22:04:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1549309178288919.961324977587; Mon, 4 Feb 2019 11:39:38 -0800 (PST) Received: from localhost ([127.0.0.1]:48240 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqk5c-0006oZ-D6 for importer@patchew.org; Mon, 04 Feb 2019 14:39:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqj7w-00065u-Ie for qemu-devel@nongnu.org; Mon, 04 Feb 2019 13:37:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gqj7v-0004G3-1k for qemu-devel@nongnu.org; Mon, 04 Feb 2019 13:37:52 -0500 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:34883) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gqj7u-00045K-O7 for qemu-devel@nongnu.org; Mon, 04 Feb 2019 13:37:50 -0500 Received: by mail-wr1-x430.google.com with SMTP id z18so205451wrh.2 for ; Mon, 04 Feb 2019 10:37:33 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id s132sm8836236wmf.28.2019.02.04.10.37.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 10:37:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=JIvXHd4mlCTqxSS0fOCfFJEGAwzmeOAzTua89tVyfKQ=; b=Yaf0l9gOMhhNmeQUueW2fDzcpo003L7wBqf88EUNcqnjQwJamrAVlyIBSE+niQfOFP ITvC/1LTAII5WdeCJel37RC++8rvUM0d9ON1qaTeyHBpH3drazbYxm3F6QWYP7t8sYFz puVn3LjJloJrOfnYYwWD5BF9j2/xxjRYK8tDALt3XZZuqZLJCJ7dDLmodnteOmUAFTvb i0HxfPPHoS/XyuTrTD9Uupxn75VHNjBDei5+t0DwVcTx6ssAyhkm8Cbf8DUyEL1sG+KU AzeO1YRUFX+xvwNcml5vOxOE3mumipkFBOqWDSgQHsxOGYQghRNzkqyjbzGZIS4sXXkf +ncQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=JIvXHd4mlCTqxSS0fOCfFJEGAwzmeOAzTua89tVyfKQ=; b=LzIklKwNmFNjwzRrPzBTT+akvvFK089JyDMufbusa0oq3PQdlRyuArVWZOaj7FJzfb P4mZInig6le04LAofMA23Tb7ZKsN3vwVzoq27SgPu9IK1EBJ+gLueUdUsE/PUmagIDGb jN4+IphjpMN6JOcBHMDOX95ARcy3uW8kHwTage/3uN/Mo++Nulv7zU292kCMWBMIBzS7 r/ZQssiEgGKt0vexPjQ2lZWR0E5wZ4Q5J183CeQNhbiEgUYF+rZyjbIveqDhU32J/Igu 0rTKKTBiYktekyWXSKyF5ad/pB09OMH0o9rd6vv/Of1KjNl2c5zIve0A3+0s8Amtyzls OBww== X-Gm-Message-State: AHQUAubvWk0ZeDHl+wyYnUmDYhkb4+kkE9ATScWEwyqJsqtc3n+FXOLz 0QeGfMagYbV7wyQoxq+1A9S1qgBw X-Google-Smtp-Source: AHgI3IYw4XrcUbLc5VN7UlGhKJFLMx+E1WSsiz6kVO7PWAvYCUT4aAvMNodeo1eDaqypOTT+XJ0W8Q== X-Received: by 2002:a5d:5351:: with SMTP id t17mr575032wrv.288.1549305452526; Mon, 04 Feb 2019 10:37:32 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 4 Feb 2019 19:36:15 +0100 Message-Id: <1549305379-51117-74-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1549305379-51117-1-git-send-email-pbonzini@redhat.com> References: <1549305379-51117-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::430 Subject: [Qemu-devel] [PULL 73/77] i386: hvf: Fix smp boot hangs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiher Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Heiher The machine that with hvf accelerator and smp sometimes boot hangs because all processors are executing instructions at startup, including early I/O emulations. We should just allow the bootstrap processor to initialize the machine and then to wake up slave processors by interrupt. Signed-off-by: Heiher Message-Id: <20190123073402.28465-1-r@hev.cc> Signed-off-by: Paolo Bonzini --- target/i386/hvf/hvf.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 689b585..42f9447 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -499,7 +499,6 @@ void hvf_reset_vcpu(CPUState *cpu) { } =20 hv_vm_sync_tsc(0); - cpu->halted =3D 0; hv_vcpu_invalidate_tlb(cpu->hvf_fd); hv_vcpu_flush(cpu->hvf_fd); } @@ -582,8 +581,6 @@ int hvf_init_vcpu(CPUState *cpu) =20 wvmcs(cpu->hvf_fd, VMCS_TPR_THRESHOLD, 0); =20 - hvf_reset_vcpu(cpu); - x86cpu =3D X86_CPU(cpu); x86cpu->env.xsave_buf =3D qemu_memalign(4096, 4096); =20 @@ -659,8 +656,6 @@ int hvf_vcpu_exec(CPUState *cpu) int ret =3D 0; uint64_t rip =3D 0; =20 - cpu->halted =3D 0; - if (hvf_process_events(cpu)) { return EXCP_HLT; } --=20 1.8.3.1