From nobody Mon Feb 9 23:04:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1549306831967297.50478451538584; Mon, 4 Feb 2019 11:00:31 -0800 (PST) Received: from localhost ([127.0.0.1]:47582 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqjTm-0007GA-1D for importer@patchew.org; Mon, 04 Feb 2019 14:00:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqj7C-0005N1-9S for qemu-devel@nongnu.org; Mon, 04 Feb 2019 13:37:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gqj79-0003kd-5H for qemu-devel@nongnu.org; Mon, 04 Feb 2019 13:37:04 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:54282) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gqj78-0003jw-TT for qemu-devel@nongnu.org; Mon, 04 Feb 2019 13:37:03 -0500 Received: by mail-wm1-x341.google.com with SMTP id a62so959978wmh.4 for ; Mon, 04 Feb 2019 10:37:02 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id s132sm8836236wmf.28.2019.02.04.10.37.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 10:37:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=tA2jlZTIBs8Nb/dH8CrSBeXx6EsmTO9sShcsouJF7kI=; b=SycxyUFHqZYoyKC/XxXtj0C6gXKrZahAVXSphCZoypgZV6vpC7U0IQA+QVAVqdUY/j Pc59e5R2FzNTtINohXbGRI/v4T+gVceNcYgLIz+Cioo+ZIdZn9/qVRTobL/zStES/rJh 8WQEDEK8WQxPwC8bQEWCFy4rc0etxKvF3N/welH2ANVNk+wg4vszMrtrXbw+t+1+/Fo2 oYVDZomOeDtYdv1dApugMM2RzAyZfS8yYeecdpwWE59vBzegWM52GoKcGbFYwnMz/L+o 5AZQ7dpXqX+PXof+CseC2S+Ukn6hjnMul6nrFoKycSpzgp8sKDNFx3oBR9D/jhBS7InN 73Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=tA2jlZTIBs8Nb/dH8CrSBeXx6EsmTO9sShcsouJF7kI=; b=XGxaUOX+lSBRVrzBDlWbZKDS3aqn67wgJ0qJxaNiQE+7GOkyhs7eaa3ioVon3TmIZv 5ssQBcCuX9MrPBW5J5Dka9TRdZLC/9tAle/bUp8luQ0beO883zffFXBYYAw+U1ebAlnT IpbXjxeKQtedo9YE9lDoQQPMLtla5jOgafSbcQVnl5e7GxCQOcOYNWjwMWkL3Mq+0d5O +ydFl7RV/Umf5tMpy598pMljy0GoL2AfuTeCbMleilTZIMiEyn17LY/Z9fR6CJ0QLtQi lh0q6UCwU9rY/ySGS1c6ub9UKM6isVq59gn6PVa31HN9k7pT2tLwtQchxDchaRIibABe mK7w== X-Gm-Message-State: AHQUAuaO9XyhtdCnOlQjT3o70OIbS5E1o8y8T3dXyFpy8BioqnKpf4xh 5xJWHucCkDit8VeD9JWDELKKXCqP X-Google-Smtp-Source: AHgI3IYoGDVpKbhF+jDMMui/jC6BmUWAm8RQoUg2WuylbB2VDRvVJnnqKa6mpGAihEiBcdiyDwQasA== X-Received: by 2002:a1c:5dce:: with SMTP id r197mr540049wmb.130.1549305421609; Mon, 04 Feb 2019 10:37:01 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 4 Feb 2019 19:35:43 +0100 Message-Id: <1549305379-51117-42-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1549305379-51117-1-git-send-email-pbonzini@redhat.com> References: <1549305379-51117-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: [Qemu-devel] [PULL 41/77] i386: hvf: Don't miss 16-bit displacement X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Roman Bolshakov Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Roman Bolshakov In 16-bit addressing mode, when Mod =3D 0 and R/M =3D 6, decoded displaceme= nt doesn't reach decode_linear_addr and gets lost. Instructions that involve the combination of ModRM always get a pointer with zero offset from the beginning of DS segment. The change fixes drawing in F-BIRD from day 1 of '18 advent calendar. Signed-off-by: Roman Bolshakov Message-Id: <20190125154743.14498-1-r.bolshakov@yadro.com> Signed-off-by: Paolo Bonzini --- target/i386/hvf/x86_decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/hvf/x86_decode.c b/target/i386/hvf/x86_decode.c index 5f513c5..9ef7d75 100644 --- a/target/i386/hvf/x86_decode.c +++ b/target/i386/hvf/x86_decode.c @@ -1642,7 +1642,7 @@ void calc_modrm_operand16(CPUX86State *env, struct x8= 6_decode *decode, X86Seg seg =3D R_DS; =20 if (!decode->modrm.mod && 6 =3D=3D decode->modrm.rm) { - op->ptr =3D (uint16_t)decode->displacement; + ptr =3D decode->displacement; goto calc_addr; } =20 --=20 1.8.3.1