From nobody Mon Feb 9 17:24:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1549306524197796.5322672948732; Mon, 4 Feb 2019 10:55:24 -0800 (PST) Received: from localhost ([127.0.0.1]:47506 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqjOm-00037j-6i for importer@patchew.org; Mon, 04 Feb 2019 13:55:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqj76-0005HP-Nl for qemu-devel@nongnu.org; Mon, 04 Feb 2019 13:37:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gqj76-0003iW-0e for qemu-devel@nongnu.org; Mon, 04 Feb 2019 13:37:00 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:36810) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gqj74-0003hl-Su for qemu-devel@nongnu.org; Mon, 04 Feb 2019 13:36:59 -0500 Received: by mail-wm1-x332.google.com with SMTP id p6so1025099wmc.1 for ; Mon, 04 Feb 2019 10:36:58 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id s132sm8836236wmf.28.2019.02.04.10.36.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 10:36:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Pv7QOZfFzXUBUAJfwOCLg8Ta9/NfHbHT1o8qe8GcQYk=; b=ow9lskB6fgt9Zjr7iJ4/QjPoMvrFt+Vg0S+I7npi7H1b2rjsvksp31ddV4IkeYE/y1 B+PIwDO8b6X4yg/f/45d8XhiCUmftvrgyfmdSZO/tMYlVxuQFWFiCX+sC4USYUCHTxaz b08WM8Dx5VWCyPUcCp3SBtTuB9C6h31qjh9tDgcgTcijNMzExKaVyHuhWlmt76/kpHAd IUsPTOCeXWcqqSpgFBVKcl1k6iv7FdgVoPMCwtKrPN/vfGEoRzcwALLJi58fqpbFKhYN R6rr/tThZNdhjJYGDCYGZytOkaCwKxtBKu4W6mcMN+Zoif7KcP1SfmtM3k6dI5KnE813 8i7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Pv7QOZfFzXUBUAJfwOCLg8Ta9/NfHbHT1o8qe8GcQYk=; b=ias+YCc4RQZNOzTgibRbtIZK0BPepRBoN5dcCkzR1i9WTbQlOH2Vdc+Ov9NMT4MP+o uhMIftNzCQ1gNvdKc4IZWZONc02KwuEPXFswpPePJBf/oqpX/0ZDut6jSzENvVE/rWuH lbqbf2JM3pmCon9qInIxNtQ3QvWUZdB1V7Dw6V8iUmgmFpz52SxxPXHIiDzAFIQAWY80 oi6+JUyVzOoBuZDPRlZ7ucmPmrmiGMRKP/6u8hSMvT9oFt4GGca+Gv7f1O8yoP0gU3OS NioMOQlCGXFU4CTWUE7JBz0YOFmIikdg8Qbk6D8rcMtL6wMJDvVv5eVP6blDWZqHW7CI 2m/Q== X-Gm-Message-State: AHQUAuY5PBTcO7XzYoiycCzVR2avncCoglVvEJp7vQ3KQmyvJ2XoBMlo QgaZrKc4YjYZdgM0pJr5Xehx3GNc X-Google-Smtp-Source: AHgI3IYX3yzR7kUV5m1gpdhcnZqSKIqmpBtpt2xmts4c/WtegDuO8YDub+MkwEEmy/mIXLxYW9BnUA== X-Received: by 2002:a1c:cbcb:: with SMTP id b194mr534277wmg.64.1549305417486; Mon, 04 Feb 2019 10:36:57 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 4 Feb 2019 19:35:39 +0100 Message-Id: <1549305379-51117-38-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1549305379-51117-1-git-send-email-pbonzini@redhat.com> References: <1549305379-51117-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::332 Subject: [Qemu-devel] [PULL 37/77] hw/core/loader.c: Read as long as possible in load_image_size() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , Li Zhijian , Stefano Garzarella Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Li Zhijian Don't expect read(2) can always read as many as it's told. CC: Richard Henderson CC: Stefano Garzarella Signed-off-by: Li Zhijian Reviewed-by: Richard Henderson Reviewed-by: Stefano Garzarella Signed-off-by: Paolo Bonzini --- hw/core/loader.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index 3a000d5..fe5cb24 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -77,21 +77,20 @@ int64_t get_image_size(const char *filename) ssize_t load_image_size(const char *filename, void *addr, size_t size) { int fd; - ssize_t actsize; + ssize_t actsize, l =3D 0; =20 fd =3D open(filename, O_RDONLY | O_BINARY); if (fd < 0) { return -1; } =20 - actsize =3D read(fd, addr, size); - if (actsize < 0) { - close(fd); - return -1; + while ((actsize =3D read(fd, addr + l, size - l)) > 0) { + l +=3D actsize; } + close(fd); =20 - return actsize; + return actsize < 0 ? -1 : l; } =20 /* read()-like version */ --=20 1.8.3.1