From nobody Mon Feb 9 20:32:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1549306787912909.3872874013111; Mon, 4 Feb 2019 10:59:47 -0800 (PST) Received: from localhost ([127.0.0.1]:47574 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqjT3-0006fk-Qg for importer@patchew.org; Mon, 04 Feb 2019 13:59:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqj6x-00058Q-9A for qemu-devel@nongnu.org; Mon, 04 Feb 2019 13:36:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gqj6u-0003ZS-Pi for qemu-devel@nongnu.org; Mon, 04 Feb 2019 13:36:51 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:38893) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gqj6u-0003YJ-Hn for qemu-devel@nongnu.org; Mon, 04 Feb 2019 13:36:48 -0500 Received: by mail-wr1-x42e.google.com with SMTP id v13so961367wrw.5 for ; Mon, 04 Feb 2019 10:36:48 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id s132sm8836236wmf.28.2019.02.04.10.36.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 10:36:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=zlw4otX+sXF2EUUfBbepsg2Nz8RseQqACaPDBHAzgsM=; b=Mwm9AC7q43bOfBklOz8T4aflN+uBd3SD8aSXrsbU1H1AXh+qjH4OT1CUWNKnndtSzZ rC2zxqhMNnB//GA+zEMvWiUOkWjWuf6VW8+J+cuMHy0mGkZiTojm571XVEvaQm6jnVCj /B3+4F+XCYXrj17Ct54UZ/B4hMTjOy2pZLKMYCxmH0tQSIVwi22CM6v92w5Xq+vCGWDQ QsxBrXSBeUHJkjcKRN4C0t0q7yXrkI/cdI7Oxa9RjwHlGZSwn4BredD+Banxfq4WGqrn 61gZ8HdigyYzvkbG25zu4Cbfpy3xStDTuSR97WbgMTFGLZrR+Rm/MBlzeg/3vkdaDeHg pN2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=zlw4otX+sXF2EUUfBbepsg2Nz8RseQqACaPDBHAzgsM=; b=IqEzLcZM0ZOfb4IGbg3uSwUYNn5NhokBXomYRjUhtXbnB7kom514VlbinJwaP+RJtY MhRACOeH63Y8EBHynA++aVud/Yzz48ahF4p+kAHAiJC8agyAXl1yganDZr3RpM6v5fY0 zTb2rxP+9Q6RRzsbPc0vWUbBnOnF0svvvbzSgAU1i1CK7qEZ1YR3E6fMjBlZmGUzNcgG dCJ5sMTWFXSH7XZcKRrVZXKzxxHPRq2BJ3yGPD+8Y0R53lVQVyTCqcTT6Sut6PwnKarh PJ/aHUBsL6Pi2v/2gwDk3++PC42dg0yB5MhfHB75bjYO1Xl/j7QqpHKyUKROe1f6Qg4o OY0Q== X-Gm-Message-State: AHQUAuYih9Y6z8MualDosNU95wzoGL4SUg2neBjpfiJwI8JHxdtNzuGm HzTOjsSYsVrhJINgHxRgxhOl+Vb/ X-Google-Smtp-Source: AHgI3IZyFuiqmyhXaotiWOOAyPVG80pOolJi5PCvw+/XPQijGBoj4/GUraImV7P6/niwKtmvcaJRdQ== X-Received: by 2002:a5d:44d1:: with SMTP id z17mr528272wrr.271.1549305407253; Mon, 04 Feb 2019 10:36:47 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 4 Feb 2019 19:35:28 +0100 Message-Id: <1549305379-51117-27-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1549305379-51117-1-git-send-email-pbonzini@redhat.com> References: <1549305379-51117-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42e Subject: [Qemu-devel] [PULL 26/77] target-i386: hvf: remove MPX support X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" MPX support is being phased out by Intel and actually I am not sure that OS X has ever enabled it in XCR0. Drop it from the Hypervisor.framework acceleration. Signed-off-by: Paolo Bonzini --- target/i386/hvf/x86_cpuid.c | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/target/i386/hvf/x86_cpuid.c b/target/i386/hvf/x86_cpuid.c index 9874a46..4d957fe 100644 --- a/target/i386/hvf/x86_cpuid.c +++ b/target/i386/hvf/x86_cpuid.c @@ -38,16 +38,6 @@ static uint64_t xgetbv(uint32_t xcr) return (((uint64_t)edx) << 32) | eax; } =20 -static bool vmx_mpx_supported() -{ - uint64_t cap_exit, cap_entry; - - hv_vmx_read_capability(HV_VMX_CAP_ENTRY, &cap_entry); - hv_vmx_read_capability(HV_VMX_CAP_EXIT, &cap_exit); - - return ((cap_exit & (1 << 23)) && (cap_entry & (1 << 16))); -} - uint32_t hvf_get_supported_cpuid(uint32_t func, uint32_t idx, int reg) { @@ -92,11 +82,8 @@ uint32_t hvf_get_supported_cpuid(uint32_t func, uint32_t= idx, CPUID_7_0_EBX_CLFLUSHOPT | CPUID_7_0_EBX_CLWB | CPUID_7_0_EBX_AVX512DQ | CPUID_7_0_EBX_SHA_NI | CPUID_7_0_EBX_AVX512BW | CPUID_7_0_EBX_AVX512VL | - CPUID_7_0_EBX_INVPCID | CPUID_7_0_EBX_MPX; + CPUID_7_0_EBX_INVPCID; =20 - if (!vmx_mpx_supported()) { - ebx &=3D ~CPUID_7_0_EBX_MPX; - } hv_vmx_read_capability(HV_VMX_CAP_PROCBASED2, &cap); if (!(cap & CPU_BASED2_INVPCID)) { ebx &=3D ~CPUID_7_0_EBX_INVPCID; @@ -119,9 +106,6 @@ uint32_t hvf_get_supported_cpuid(uint32_t func, uint32_= t idx, XSTATE_BNDCSR_MASK | XSTATE_OPMASK_MASK | XSTATE_ZMM_Hi256_MASK | XSTATE_Hi16_ZMM_= MASK); eax &=3D supp_xcr0; - if (!vmx_mpx_supported()) { - eax &=3D ~(XSTATE_BNDREGS_MASK | XSTATE_BNDCSR_MASK); - } } else if (idx =3D=3D 1) { hv_vmx_read_capability(HV_VMX_CAP_PROCBASED2, &cap); eax &=3D CPUID_XSAVE_XSAVEOPT | CPUID_XSAVE_XGETBV1; --=20 1.8.3.1