From nobody Mon Feb 9 11:51:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1549305712302526.8512566184415; Mon, 4 Feb 2019 10:41:52 -0800 (PST) Received: from localhost ([127.0.0.1]:47338 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqjBl-0000Wd-WF for importer@patchew.org; Mon, 04 Feb 2019 13:41:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqj6r-00052Y-Ey for qemu-devel@nongnu.org; Mon, 04 Feb 2019 13:36:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gqj6p-0003TW-To for qemu-devel@nongnu.org; Mon, 04 Feb 2019 13:36:45 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:40246) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gqj6p-0003G4-LL for qemu-devel@nongnu.org; Mon, 04 Feb 2019 13:36:43 -0500 Received: by mail-wr1-x42e.google.com with SMTP id p4so943893wrt.7 for ; Mon, 04 Feb 2019 10:36:22 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id s132sm8836236wmf.28.2019.02.04.10.36.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 10:36:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TshKAAE0RNuQoCOsIUO0/6gnJwuL2kOPO0XB8jX12WA=; b=hlvibu64YGZcG+zCGG2/rXHyAqW2H61x1hGVE+bDUAG39NatzC/fADH7gGZOLWeeki 0HWyxPlx336LYlN9kOajdB5etKcUtSYiRVehNtBYDwnYmjAwZaALx/fOfuWs0CFr2iL0 h3fnfzgwpd/qtyGen2ZmS62L8MbyRidCJ+TDrJon1bGDg/EZzr4vZdJFjW69Lu9OLlA1 /Py7HdmBrRel0j6fzDHp3o3PrU29sdvuXiHrOg+cq+jAsOul9mozCwHpvzIXV0G11JDD 1ETmOQBkF1XEwChSoTCrrGuO4cGngwBT97R3D/HBizoLYzY9eSdNTb7vmtNRMLUE2HNj Sc0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=TshKAAE0RNuQoCOsIUO0/6gnJwuL2kOPO0XB8jX12WA=; b=AxWTRPGTIOzIDyMMqPqhXK1cL6pQTWLGg5snCkkh/qZwguSCzb3bLDrRepAhNpsrgj ZgwWlvP9kbJaaVxh8pw+xnKE3fTEcGMWQChGLKcqD9eK+JzXZ8saprTbTYs508r72hp/ jabZaZIkCnbLuLSMMzLQ7VRj9EZlj9zQeeN4idy3ffMOd6ssgjGQK0+StqC47lxAxW5u aSCosKw5calqLKV0clEDRfI2uIsj6rq/BD9TZai3ap4A4BsUnuMxar2j6k3cTcHJZqYS /+mH0sI+yx/Ksk7zNyaDC3oHSun7ibHWc9m3r/6ousPkOuLh6fjiBKsEKeCIxbhcJeQK r42g== X-Gm-Message-State: AHQUAuZ6nc4xgnHUsVesmrdMsKMQIDXcfDUgeNph1yUeAsDTyBve2AET zeDfS2mixjhE3Hkwwk1LDRAlJW8I X-Google-Smtp-Source: AHgI3IZqVL9O+l75qOICRBBseGRnNhMt8Ul9+4f8uoPRg5SZqfw5SR8LWr8W8ywKfAGLK7GVBdbsNg== X-Received: by 2002:a5d:5750:: with SMTP id q16mr600864wrw.12.1549305381630; Mon, 04 Feb 2019 10:36:21 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 4 Feb 2019 19:35:03 +0100 Message-Id: <1549305379-51117-2-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1549305379-51117-1-git-send-email-pbonzini@redhat.com> References: <1549305379-51117-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42e Subject: [Qemu-devel] [PULL 01/77] vhost-user-test: use g_cond_broadcast X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) g_cond_signal is rarely the right thing to do, it works now because vhost-user-test only has two threads but it is not correct in general. Fix it before adding more calls. Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Paolo Bonzini Message-Id: <1543851204-41186-7-git-send-email-pbonzini@redhat.com> --- tests/vhost-user-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index 84e50d8..9baaff4 100644 --- a/tests/vhost-user-test.c +++ b/tests/vhost-user-test.c @@ -393,7 +393,7 @@ static void chr_read(void *opaque, const uint8_t *buf, = int size) G_N_ELEMENTS(s->fds)); =20 /* signal the test that it can continue */ - g_cond_signal(&s->data_cond); + g_cond_broadcast(&s->data_cond); break; =20 case VHOST_USER_SET_VRING_KICK: @@ -419,7 +419,7 @@ static void chr_read(void *opaque, const uint8_t *buf, = int size) p =3D (uint8_t *) &msg; qemu_chr_fe_write_all(chr, p, VHOST_USER_HDR_SIZE); =20 - g_cond_signal(&s->data_cond); + g_cond_broadcast(&s->data_cond); break; =20 case VHOST_USER_SET_VRING_BASE: --=20 1.8.3.1