[Qemu-devel] [PATCH] MAINTAINERS: XIVE is an interrupt controller, not a machine

Thomas Huth posted 1 patch 5 years, 1 month ago
Test docker-clang@ubuntu passed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1548863140-31975-1-git-send-email-thuth@redhat.com
MAINTAINERS | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
[Qemu-devel] [PATCH] MAINTAINERS: XIVE is an interrupt controller, not a machine
Posted by Thomas Huth 5 years, 1 month ago
The "XIVE" section is currently listed in the "PowerPC Machines"
section, which is weird, since this is an interrupt controller
device. Move it to the "Devices" section instead.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index b334b53..eac36b6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1038,14 +1038,6 @@ F: tests/libqos/*spapr*
 F: tests/rtas*
 F: tests/libqos/rtas*
 
-XIVE
-M: David Gibson <david@gibson.dropbear.id.au>
-M: Cédric Le Goater <clg@kaod.org>
-L: qemu-ppc@nongnu.org
-S: Supported
-F: hw/*/*xive*
-F: include/hw/*/*xive*
-
 virtex_ml507
 M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
 L: qemu-ppc@nongnu.org
@@ -1645,6 +1637,14 @@ F: tests/libqos/fw_cfg.c
 F: tests/fw_cfg-test.c
 T: git https://github.com/philmd/qemu.git fw_cfg-next
 
+XIVE
+M: David Gibson <david@gibson.dropbear.id.au>
+M: Cédric Le Goater <clg@kaod.org>
+L: qemu-ppc@nongnu.org
+S: Supported
+F: hw/*/*xive*
+F: include/hw/*/*xive*
+
 Subsystems
 ----------
 Audio
-- 
1.8.3.1


Re: [Qemu-devel] [PATCH] MAINTAINERS: XIVE is an interrupt controller, not a machine
Posted by Philippe Mathieu-Daudé 5 years, 1 month ago
On 1/30/19 4:45 PM, Thomas Huth wrote:
> The "XIVE" section is currently listed in the "PowerPC Machines"
> section, which is weird, since this is an interrupt controller
> device. Move it to the "Devices" section instead.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  MAINTAINERS | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b334b53..eac36b6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1038,14 +1038,6 @@ F: tests/libqos/*spapr*
>  F: tests/rtas*
>  F: tests/libqos/rtas*
>  
> -XIVE
> -M: David Gibson <david@gibson.dropbear.id.au>
> -M: Cédric Le Goater <clg@kaod.org>
> -L: qemu-ppc@nongnu.org
> -S: Supported
> -F: hw/*/*xive*
> -F: include/hw/*/*xive*
> -
>  virtex_ml507
>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>  L: qemu-ppc@nongnu.org
> @@ -1645,6 +1637,14 @@ F: tests/libqos/fw_cfg.c
>  F: tests/fw_cfg-test.c
>  T: git https://github.com/philmd/qemu.git fw_cfg-next
>  
> +XIVE
> +M: David Gibson <david@gibson.dropbear.id.au>
> +M: Cédric Le Goater <clg@kaod.org>
> +L: qemu-ppc@nongnu.org
> +S: Supported
> +F: hw/*/*xive*

   F: hw/intc/*xive*

> +F: include/hw/*/*xive*

I'd expect them in /intc/ like the source, but they are in:

   F: include/hw/ppc/*xive*

> +
>  Subsystems
>  ----------
>  Audio
> 

With or without the paths updated:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [Qemu-devel] [PATCH] MAINTAINERS: XIVE is an interrupt controller, not a machine
Posted by David Gibson 5 years, 1 month ago
On Wed, Jan 30, 2019 at 04:45:40PM +0100, Thomas Huth wrote:
> The "XIVE" section is currently listed in the "PowerPC Machines"
> section, which is weird, since this is an interrupt controller
> device. Move it to the "Devices" section instead.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Applied to ppc-for-4.0, thanks.

> ---
>  MAINTAINERS | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b334b53..eac36b6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1038,14 +1038,6 @@ F: tests/libqos/*spapr*
>  F: tests/rtas*
>  F: tests/libqos/rtas*
>  
> -XIVE
> -M: David Gibson <david@gibson.dropbear.id.au>
> -M: Cédric Le Goater <clg@kaod.org>
> -L: qemu-ppc@nongnu.org
> -S: Supported
> -F: hw/*/*xive*
> -F: include/hw/*/*xive*
> -
>  virtex_ml507
>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>  L: qemu-ppc@nongnu.org
> @@ -1645,6 +1637,14 @@ F: tests/libqos/fw_cfg.c
>  F: tests/fw_cfg-test.c
>  T: git https://github.com/philmd/qemu.git fw_cfg-next
>  
> +XIVE
> +M: David Gibson <david@gibson.dropbear.id.au>
> +M: Cédric Le Goater <clg@kaod.org>
> +L: qemu-ppc@nongnu.org
> +S: Supported
> +F: hw/*/*xive*
> +F: include/hw/*/*xive*
> +
>  Subsystems
>  ----------
>  Audio

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
Re: [Qemu-devel] [PATCH] MAINTAINERS: XIVE is an interrupt controller, not a machine
Posted by Cédric Le Goater 5 years, 1 month ago
On 1/30/19 4:45 PM, Thomas Huth wrote:
> The "XIVE" section is currently listed in the "PowerPC Machines"
> section, which is weird, since this is an interrupt controller
> device. 

( I wonder how XIVE should be classified, the logic is as big as 
  a core on the POWER9 processor. )

> Move it to the "Devices" section instead.
> Signed-off-by: Thomas Huth <thuth@redhat.com>

yes, looks good me.

Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.

> ---
>  MAINTAINERS | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b334b53..eac36b6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1038,14 +1038,6 @@ F: tests/libqos/*spapr*
>  F: tests/rtas*
>  F: tests/libqos/rtas*
>  
> -XIVE
> -M: David Gibson <david@gibson.dropbear.id.au>
> -M: Cédric Le Goater <clg@kaod.org>
> -L: qemu-ppc@nongnu.org
> -S: Supported
> -F: hw/*/*xive*
> -F: include/hw/*/*xive*
> -
>  virtex_ml507
>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>  L: qemu-ppc@nongnu.org
> @@ -1645,6 +1637,14 @@ F: tests/libqos/fw_cfg.c
>  F: tests/fw_cfg-test.c
>  T: git https://github.com/philmd/qemu.git fw_cfg-next
>  
> +XIVE
> +M: David Gibson <david@gibson.dropbear.id.au>
> +M: Cédric Le Goater <clg@kaod.org>
> +L: qemu-ppc@nongnu.org
> +S: Supported
> +F: hw/*/*xive*
> +F: include/hw/*/*xive*
> +
>  Subsystems
>  ----------
>  Audio
>