From nobody Fri Nov 7 14:34:58 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1548095443020429.9538100747368; Mon, 21 Jan 2019 10:30:43 -0800 (PST) Received: from localhost ([127.0.0.1]:57688 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gleLK-0007SF-1X for importer@patchew.org; Mon, 21 Jan 2019 13:30:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gldyN-0004cv-Rj for qemu-devel@nongnu.org; Mon, 21 Jan 2019 13:07:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gldyN-0004Si-55 for qemu-devel@nongnu.org; Mon, 21 Jan 2019 13:06:59 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:40731) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gldyM-0004Rr-UG for qemu-devel@nongnu.org; Mon, 21 Jan 2019 13:06:59 -0500 Received: by mail-wm1-x32f.google.com with SMTP id f188so11667327wmf.5 for ; Mon, 21 Jan 2019 10:06:58 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id 133sm56197732wme.9.2019.01.21.10.06.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Jan 2019 10:06:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=zlw4otX+sXF2EUUfBbepsg2Nz8RseQqACaPDBHAzgsM=; b=QSsV9UcsUQqIZaaVT+oKFPuqU+FLVBmjfMUbsq2U9yvyu7ZJ/7gHjCNm0MUkg3RkEG jx0b1QJUrYGc7Nk8ZbNjHXmUL/gkkaZuFUmT6moKmVWbQqyRxiFFsXyC8ZPGCCiBsqfH HfTP453Hi8/Wu7qtEuONgBpJwLR/GyaFY/85t+IITWIaAJcRnjh7c9qV80gf5m1nycR3 y6oC0b1V0RyiWMjSepljFc2kAKTpmVdMP0R6yEnTKkV8Ra2bqe2jU00zmAx92FHPS7WT wKio57T/7j6q5cFp0EN39D4Y8yKF5jQ3PnlbmKfBOrWxa+WpjfIg2nDpPBSQscsdWCrg HW3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=zlw4otX+sXF2EUUfBbepsg2Nz8RseQqACaPDBHAzgsM=; b=LZcuJEazGUI4ngDID0Hq7y/9NouyQf4gqKVhh3/qCDO6yZmnSS78IVDKuHVZHShFMN Zu7D5+Tj3hQ3y9ZrV6mPL3Aujug+MWc+OYwGZJqCddijKq/piLinEYvuL6opzCBeeIUG TFGnAithfN/7myfwvB76j+nWJ7e8xL91tkMNanemou+Vk7TigKycaJrWF/ydyLwouS4t 3VNcnBMEaw73/wT1AEkj+OP+sP0ijW+Rx+tBetjs4Jo9d0QLpJR834Q6dcJkdYOLAruH fp9jEu5XpK/IRN4nYUIRI3mj2sGoA6YaOnR2diIWjrx+CyL70kn+qUiX4eE32Tog8t81 LY7A== X-Gm-Message-State: AJcUukcFyTeBxTgV3B8k+SaDAlBVPkpOM8NoOQ9GPAsGXYQFUDAne1zp chOqOjS/DAp4t5bT2nKlQsZYXmiT X-Google-Smtp-Source: ALg8bN5jpN5ioAjZmUa8htLBZ9V4nwOGjtSVglmzCOfaIcm+uKVYZwUP4X/v6xCaAqmgCLzR/8nZcg== X-Received: by 2002:a1c:868a:: with SMTP id i132mr398352wmd.49.1548094017641; Mon, 21 Jan 2019 10:06:57 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 21 Jan 2019 19:06:06 +0100 Message-Id: <1548093980-43088-36-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1548093980-43088-1-git-send-email-pbonzini@redhat.com> References: <1548093980-43088-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32f Subject: [Qemu-devel] [PULL 35/49] target-i386: hvf: remove MPX support X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" MPX support is being phased out by Intel and actually I am not sure that OS X has ever enabled it in XCR0. Drop it from the Hypervisor.framework acceleration. Signed-off-by: Paolo Bonzini --- target/i386/hvf/x86_cpuid.c | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/target/i386/hvf/x86_cpuid.c b/target/i386/hvf/x86_cpuid.c index 9874a46..4d957fe 100644 --- a/target/i386/hvf/x86_cpuid.c +++ b/target/i386/hvf/x86_cpuid.c @@ -38,16 +38,6 @@ static uint64_t xgetbv(uint32_t xcr) return (((uint64_t)edx) << 32) | eax; } =20 -static bool vmx_mpx_supported() -{ - uint64_t cap_exit, cap_entry; - - hv_vmx_read_capability(HV_VMX_CAP_ENTRY, &cap_entry); - hv_vmx_read_capability(HV_VMX_CAP_EXIT, &cap_exit); - - return ((cap_exit & (1 << 23)) && (cap_entry & (1 << 16))); -} - uint32_t hvf_get_supported_cpuid(uint32_t func, uint32_t idx, int reg) { @@ -92,11 +82,8 @@ uint32_t hvf_get_supported_cpuid(uint32_t func, uint32_t= idx, CPUID_7_0_EBX_CLFLUSHOPT | CPUID_7_0_EBX_CLWB | CPUID_7_0_EBX_AVX512DQ | CPUID_7_0_EBX_SHA_NI | CPUID_7_0_EBX_AVX512BW | CPUID_7_0_EBX_AVX512VL | - CPUID_7_0_EBX_INVPCID | CPUID_7_0_EBX_MPX; + CPUID_7_0_EBX_INVPCID; =20 - if (!vmx_mpx_supported()) { - ebx &=3D ~CPUID_7_0_EBX_MPX; - } hv_vmx_read_capability(HV_VMX_CAP_PROCBASED2, &cap); if (!(cap & CPU_BASED2_INVPCID)) { ebx &=3D ~CPUID_7_0_EBX_INVPCID; @@ -119,9 +106,6 @@ uint32_t hvf_get_supported_cpuid(uint32_t func, uint32_= t idx, XSTATE_BNDCSR_MASK | XSTATE_OPMASK_MASK | XSTATE_ZMM_Hi256_MASK | XSTATE_Hi16_ZMM_= MASK); eax &=3D supp_xcr0; - if (!vmx_mpx_supported()) { - eax &=3D ~(XSTATE_BNDREGS_MASK | XSTATE_BNDCSR_MASK); - } } else if (idx =3D=3D 1) { hv_vmx_read_capability(HV_VMX_CAP_PROCBASED2, &cap); eax &=3D CPUID_XSAVE_XSAVEOPT | CPUID_XSAVE_XGETBV1; --=20 1.8.3.1