From nobody Fri Nov 7 14:34:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1548095443921369.20265497360606; Mon, 21 Jan 2019 10:30:43 -0800 (PST) Received: from localhost ([127.0.0.1]:57693 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gleLK-0007UF-Rs for importer@patchew.org; Mon, 21 Jan 2019 13:30:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gldyB-0004RM-Nu for qemu-devel@nongnu.org; Mon, 21 Jan 2019 13:06:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gldyB-0004FX-3D for qemu-devel@nongnu.org; Mon, 21 Jan 2019 13:06:47 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:56124) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gldyA-0004DS-TM for qemu-devel@nongnu.org; Mon, 21 Jan 2019 13:06:47 -0500 Received: by mail-wm1-x32c.google.com with SMTP id y139so11637896wmc.5 for ; Mon, 21 Jan 2019 10:06:46 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id 133sm56197732wme.9.2019.01.21.10.06.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Jan 2019 10:06:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=CbQc0oVerUPwjt8sr54endkEDd1gxjnDLeM63jRNSVM=; b=mL95dQj4MGfyiptWYrg2QSiG5j2wLkAISiS0igxq/9ERmBPV8Vo0CWapSZfh2oP6iZ NapqOCHJYGUkr2mpqmzSXyHAPWonJmsGl30uKsf0FHuwQWVMDMgiM6Xun2vqD/bsrSz6 zqFw7zYM5yRRqIP+hHKxsddt9BY8JPdmd75Z88cQaGQAWOzK7nAY34MvBjoTrbvNxqa3 ZYNNcjE4drQuWeylsVipn/lZys2tmR9iCQPn5OkTGlNFjLqAnj53fet6JahLXuyqkWLo sDLyZYlVcpoLK1carECc76UdFuvpUsLWYu08XjbJaqG1pAAiQPVYIWC+hXwQ16gJBFpF 482g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=CbQc0oVerUPwjt8sr54endkEDd1gxjnDLeM63jRNSVM=; b=lx03Z2yH3ZThfPPH/wmN+kLDAaZjhK/sdF+HWPqf++9sqkeiVuMHTmnyW5hI578599 3WIpZwbjyoHCezvOr83aU28EOsUjNN4622tZ6kKLiYUWghbrCuKv9EnQlIdkUE9VwjQl rpleZ10iu5pgytmzuV9MUYU7Vnz++cVrU6r7TZn45+yClFRlX/uWu+ER1DuRnI7yZAE6 yQ0xml7BuxAgRCBaf+FlFxFdgqRXgFfiuAfsMmRxbL51+qpODYylL9lbQoP0gVBvGZZM t8nc3kPnzKPCQhS0Wpp8bqKblif6kDuKqK6D82oYGF1jOaI3IIa+PZag9ek/EmMOFaoh e8DA== X-Gm-Message-State: AJcUukdQKEps4JOn1tBGipaORl5rYv3V/g8508gBdyaKDLJ2f4vfJ6UQ Kk9RlEA8l4KTmJFwAyIk7Z7Vw5h3 X-Google-Smtp-Source: ALg8bN6qsz4C1XAQ9A3nfK5zoF9RZeeCd153PHefmnBc6GOrLkfAucvcyDP7CVZxsZkR5rGNfZNdaQ== X-Received: by 2002:a1c:9855:: with SMTP id a82mr431999wme.20.1548094004313; Mon, 21 Jan 2019 10:06:44 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 21 Jan 2019 19:05:53 +0100 Message-Id: <1548093980-43088-23-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1548093980-43088-1-git-send-email-pbonzini@redhat.com> References: <1548093980-43088-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32c Subject: [Qemu-devel] [PULL 22/49] cpus: ignore ESRCH in qemu_cpu_kick_thread() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Laurent Vivier We can have a race condition between qemu_cpu_kick_thread() and qemu_kvm_cpu_thread_fn() when we hotunplug a CPU. In this case, qemu_cpu_kick_thread() can try to kick a thread that is exiting. pthread_kill() returns an error and qemu is stopped by an exit(1). qemu:qemu_cpu_kick_thread: No such process We can ignore safely this error. Signed-off-by: Laurent Vivier Signed-off-by: Paolo Bonzini --- cpus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpus.c b/cpus.c index b09b702..154daf5 100644 --- a/cpus.c +++ b/cpus.c @@ -1778,7 +1778,7 @@ static void qemu_cpu_kick_thread(CPUState *cpu) } cpu->thread_kicked =3D true; err =3D pthread_kill(cpu->thread->thread, SIG_IPI); - if (err) { + if (err && err !=3D ESRCH) { fprintf(stderr, "qemu:%s: %s", __func__, strerror(err)); exit(1); } --=20 1.8.3.1