From nobody Fri Nov 7 14:33:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1548095034310606.7198410467032; Mon, 21 Jan 2019 10:23:54 -0800 (PST) Received: from localhost ([127.0.0.1]:57584 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gleEj-0001CV-24 for importer@patchew.org; Mon, 21 Jan 2019 13:23:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gldy7-0004Mb-2y for qemu-devel@nongnu.org; Mon, 21 Jan 2019 13:06:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gldy6-00049N-8S for qemu-devel@nongnu.org; Mon, 21 Jan 2019 13:06:43 -0500 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:42787) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gldy6-00048i-0k for qemu-devel@nongnu.org; Mon, 21 Jan 2019 13:06:42 -0500 Received: by mail-wr1-x435.google.com with SMTP id q18so24433738wrx.9 for ; Mon, 21 Jan 2019 10:06:41 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id 133sm56197732wme.9.2019.01.21.10.06.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Jan 2019 10:06:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=gff0EQv3h3NG64Nd9DR9Q9e01dkAHdDD874kxUSW5iI=; b=l10rufVd7QXPE5I1ujgSVRwtVt7cJ8Yn/Q5msEt/pTHSb6CQ1m47F5VXG9+vAu8atf oFjeG2CeTcGDsOP9EAGaHbVkTb3nIHq+pMQMhjMaS595XT0Haq6VKU/C5JUK7Q1TQJLg Z5mW5US4/FTB+MIkYwrQGXQxTlx2rHgsu1xxmydmim6aAelC6AcBmyDac1Hgy9AULUWs dqsbeB3OQXXRVMWlL9NF4HmcPy4+eysuKmP7GhVPClMCWlSBHSsCdEMq1h87mRFrQbLi +s5mlWr9JnzvaE/R5Tki0NspRVYY0j2ymLuj6eFk6zUqzVowbKsh0idKjq4mSzqRKzXb yfdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=gff0EQv3h3NG64Nd9DR9Q9e01dkAHdDD874kxUSW5iI=; b=qAtbC9NiXRQlBcTZdOCNtJnRZ0cJL/GZoEQL9ik1YHOKc/LAlvypRVT5KmXo0t+D1E B7/K3P/JzNCfO50uf4RMY9UcDucEip0ibS2u10djkv54yLYV8argsxWzvR+EHXV2DdmT H8iLGoafsWI7Ki9Fb8SPtkDyEZLaQptZUogT5C6jUHzMjN/ksKWnWVRdi0WZapDNEtIK EO2dePPyUQxwiArQXTFPyb9821v7HTrUBMgaj1HAjXkqeVtWhR9i5hLrFt38mj7UQCgw k5P0xqjLLBITqwWe+jdqMqU8imtvaLfuUXus6bH3bKCUO2I11r+v03yNwQaObR/2Y4Ei TLXw== X-Gm-Message-State: AJcUukfspimz5HJGVGt0fWz+6WTOYfwfp/3f8GxkuSfcJNd37wdLVx1L l4L/PDcwR2x0ksMQzxPc29tPqXgz X-Google-Smtp-Source: ALg8bN5zkb6DbzCsCkFs2ds99LofFDkDSt+prKx1Si8v5ck9h85wpCtsZz5ZVNNWT7E5fWZQj+vF4A== X-Received: by 2002:adf:e407:: with SMTP id g7mr18600083wrm.277.1548094000705; Mon, 21 Jan 2019 10:06:40 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 21 Jan 2019 19:05:49 +0100 Message-Id: <1548093980-43088-19-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1548093980-43088-1-git-send-email-pbonzini@redhat.com> References: <1548093980-43088-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::435 Subject: [Qemu-devel] [PULL 18/49] tests/hexloader-test: Don't pass -nographic to the QEMU under test X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Peter Maydell The hexloader test invokes QEMU with the -nographic argument. This is unnecessary, because the qtest_initf() function will pass it -display none, which suffices to disable the graphical window. It also means that the QEMU process will make the stdin/stdout O_NONBLOCK. Since O_NONBLOCK is not per-file descriptor but per "file description", this non-blocking behaviour is then shared with any other process that's using the stdin/stdout of the 'make check' run, including make itself. This can result in make falling over with "make: write error: stdout" because it got an unexpected EINTR trying to write output messages to the terminal. This is particularly noticable if running 'make check' in a loop with while make check; do true; done (It does not affect single make check runs so much because the shell will remove the O_NONBLOCK status before it reads the terminal for interactive input.) Remove the unwanted -nographic argument. Signed-off-by: Peter Maydell Message-Id: <20190104145018.16950-1-peter.maydell@linaro.org> Reviewed-by: Thomas Huth Signed-off-by: Paolo Bonzini --- tests/hexloader-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/hexloader-test.c b/tests/hexloader-test.c index 834ed52..8b7aa2d 100644 --- a/tests/hexloader-test.c +++ b/tests/hexloader-test.c @@ -23,7 +23,7 @@ static void hex_loader_test(void) const unsigned int base_addr =3D 0x00010000; =20 QTestState *s =3D qtest_initf( - "-M vexpress-a9 -nographic -device loader,file=3Dtests/data/hex-lo= ader/test.hex"); + "-M vexpress-a9 -device loader,file=3Dtests/data/hex-loader/test.h= ex"); =20 for (i =3D 0; i < 256; ++i) { uint8_t val =3D qtest_readb(s, base_addr + i); --=20 1.8.3.1