From nobody Fri Nov 7 06:51:28 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1547475331739390.08084703036707; Mon, 14 Jan 2019 06:15:31 -0800 (PST) Received: from localhost ([127.0.0.1]:36172 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj31S-000221-Ml for importer@patchew.org; Mon, 14 Jan 2019 09:15:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj2jO-0004p7-Vc for qemu-devel@nongnu.org; Mon, 14 Jan 2019 08:56:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gj2Zx-0000D8-VJ for qemu-devel@nongnu.org; Mon, 14 Jan 2019 08:47:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52500) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gj2Zw-0000By-S1; Mon, 14 Jan 2019 08:47:00 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7CC0F64100; Mon, 14 Jan 2019 13:46:59 +0000 (UTC) Received: from thuth.com (ovpn-116-190.ams2.redhat.com [10.36.116.190]) by smtp.corp.redhat.com (Postfix) with ESMTP id 688205D969; Mon, 14 Jan 2019 13:46:57 +0000 (UTC) From: Thomas Huth To: Peter Maydell , qemu-devel@nongnu.org, berrange@redhat.com Date: Mon, 14 Jan 2019 14:46:54 +0100 Message-Id: <1547473614-20033-1-git-send-email-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 14 Jan 2019 13:46:59 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Peter Lieven , qemu-block@nongnu.org, Ronnie Sahlberg Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The header "scsi-lowlevel.h" of libiscsi 1.9.0 contains some bad "inline" prototype definitions which GCC refuses to compile in its gnu99 mode: In file included from block/iscsi.c:52:0: /usr/include/iscsi/scsi-lowlevel.h:810:13: error: inline function =E2=80=98scsi_set_uint16=E2=80=99 declared but never defined [-Werror] inline void scsi_set_uint16(unsigned char *c, uint16_t val); ^ /usr/include/iscsi/scsi-lowlevel.h:809:13: error: inline function =E2=80=98scsi_set_uint32=E2=80=99 declared but never defined [-Werror] inline void scsi_set_uint32(unsigned char *c, uint32_t val); ^ This has been fixed by upstream libiscsi in version 1.10.0 (see https://github.com/sahlberg/libiscsi/commit/7692027d6c11 ), but since we still want to support 1.9.0 for CentOS 7 / RHEL7, we have to work-around the issue by compiling with "-fgnu89-inline" in this case instead. Suggested-by: Daniel P. Berrang=C3=A9 Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- configure | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/configure b/configure index 2b9ba7d..aa80c17 100755 --- a/configure +++ b/configure @@ -4562,6 +4562,11 @@ if test "$libiscsi" !=3D "no" ; then libiscsi=3D"yes" libiscsi_cflags=3D$($pkg_config --cflags libiscsi) libiscsi_libs=3D$($pkg_config --libs libiscsi) + if $pkg_config --exact-version=3D=3D1.9.0 libiscsi; then + # There are some bad inline declarations in scsi-lowlevel.h of + # libiscsi 1.9.0 which don't work in gnu99 mode without this: + libiscsi_cflags=3D"-fgnu89-inline $libiscsi_cflags" + fi else if test "$libiscsi" =3D "yes" ; then feature_not_found "libiscsi" "Install libiscsi >=3D 1.9.0" --=20 1.8.3.1