From nobody Fri Nov 7 00:45:55 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1544628350494764.62556148806; Wed, 12 Dec 2018 07:25:50 -0800 (PST) Received: from localhost ([::1]:45570 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gX6OT-00025t-5Z for importer@patchew.org; Wed, 12 Dec 2018 10:25:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gX6MO-0000f6-FA for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:23:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gX6MH-0008TV-4P for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:23:38 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:42670) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gX6MG-0008KO-Pb for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:23:32 -0500 Received: by mail-wr1-x436.google.com with SMTP id q18so18081052wrx.9 for ; Wed, 12 Dec 2018 07:23:23 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id u10sm15878859wrr.33.2018.12.12.07.23.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Dec 2018 07:23:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Vm2wjzXkL5PP2aLDyrYYWyhFBlLf24Lfzqe9tNyyfE4=; b=IXVLmXWrwmozDWBkuPPjrGJSv5t3kFVEmroi+JTRMs/39I3gIVyIdCuICYwrjy9ZpF ld9DHE6E5hZuUx+eGY2ntptSh2XmXVl36rnGJZFWcKP5wMUc0Q+RRHPFZLDnNn1VlQ5V qVR5ZRuAhXOUZ10CRGnWLST4O56/qaOXWeNkgcr7t6iqKEDTnUru69T6WQl6MyFDmLfv sV9EqaIjB0GWJAKo4WAMMiro2ipFxHpCbB0HWw8mDm8+QRGpFPIt1yf+yolw8kkv61Qy 7LfzlZq3XQ9kVTPdx4erTqFnJ4riGnRt1+eTGg7+e4XCsMmQ+Qpt0/c71sf7jwhiuAlB owOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Vm2wjzXkL5PP2aLDyrYYWyhFBlLf24Lfzqe9tNyyfE4=; b=unebTDFUpuVU7ypOuTpSXFQBLGvna86sPMCYlJ3ftA4/grp9bR0p2EFNh+xncb1L1K PmcqDrChurLQxZqC41gqY4ORzsGJoU4LM3srM36dLYeDL8zIetzJZvHNbydePyLWKiTa VDxmvttin8ClgyYplFnXOzO8mxETSRZsKLudimvHDYe4ashhIaBkdZ25XM6hbMQE92AV 2W95Ay4hxFujKCuX6euHgrpKTS3GdIYUMGvUjxM/DsT4ZBtJNpbjxpj48D5oCSf3Hs3E fFQmLR/oW/Lu2EVevDXH7ZSFTBI8nkIdIZEE0m2s5Zq7D0B227UE89R0rFjIX0dxxqQx e96g== X-Gm-Message-State: AA+aEWYV9j7l+0rUzZtkZP0xzodcwXbcPpsYKX2daDZGxwjFFgJcJETV 6yDiJ1TjTVkdEeZlaohM8yAufYir X-Google-Smtp-Source: AFSGD/UQkynO4SMRF/0AjU5+LwlQ7eDJKNhjZV/0X9da3+vmihdD47vaKqfcyEoSBdsc6h8oGtPiLQ== X-Received: by 2002:adf:9061:: with SMTP id h88mr17413797wrh.65.1544628202629; Wed, 12 Dec 2018 07:23:22 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 12 Dec 2018 16:22:25 +0100 Message-Id: <1544628195-37728-5-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1544628195-37728-1-git-send-email-pbonzini@redhat.com> References: <1544628195-37728-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::436 Subject: [Qemu-devel] [PULL 04/54] checkpatch: check Signed-off-by in --mailback mode X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Pull the test before the anticipated exits from the process sub. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Paolo Bonzini --- scripts/checkpatch.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index b9974f0..506aa6c 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2817,6 +2817,10 @@ sub process { } } =20 + if ($is_patch && $chk_signoff && $signoff =3D=3D 0) { + ERROR("Missing Signed-off-by: line(s)\n"); + } + # If we have no input at all, then there is nothing to report on # so just keep quiet. if ($#rawlines =3D=3D -1) { @@ -2838,9 +2842,6 @@ sub process { if (!$is_patch) { ERROR("Does not appear to be a unified-diff format patch\n"); } - if ($is_patch && $chk_signoff && $signoff =3D=3D 0) { - ERROR("Missing Signed-off-by: line(s)\n"); - } =20 print report_dump(); if ($summary && !($clean =3D=3D 1 && $quiet =3D=3D 1)) { --=20 1.8.3.1