From nobody Fri Nov 7 00:50:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1544630215137303.4064536618648; Wed, 12 Dec 2018 07:56:55 -0800 (PST) Received: from localhost ([::1]:45731 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gX6sX-0002zV-TG for importer@patchew.org; Wed, 12 Dec 2018 10:56:53 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gX6N8-0001NH-9R for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:24:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gX6N5-0000fZ-9w for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:24:26 -0500 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:46536) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gX6N3-0000XV-Dq for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:24:23 -0500 Received: by mail-wr1-x434.google.com with SMTP id l9so18049536wrt.13 for ; Wed, 12 Dec 2018 07:24:08 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id u10sm15878859wrr.33.2018.12.12.07.24.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Dec 2018 07:24:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hICXc8HMZhgdE0qb9lHGLe+WYP+BV3i5De/QV94N0jA=; b=ZzbJzK0q0OvQj3CqLcf5w+TyScozEyy4Yc7XPzq+ldcG6t9AAzo0SJsmze7YmmnxX3 lu0osNDISTTCvnUDbrmTbR8RIuqS6bZ9h7PgxqaZZSOjS7Z9lZ8nbJmyMN1+wcsUaXhS YGbw6cgFPpYeBpVKtryw6pxgSRTzVNJEJyYUdb81UPXW2owYGS2f3xLnGLf7uheQdept nPRYIpWN8tf+/pHhT65wiPZKjVf+Qt+tvWRbwVq7E6+z0uT5huMFye5TjuGoFK29aslh QMLfH0YqIrjQmqL8kYuLM4TPfJzZSs1enxcAgD9mmjdRymWNNdTfecmqIkGTrhcD+/1I Emzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=hICXc8HMZhgdE0qb9lHGLe+WYP+BV3i5De/QV94N0jA=; b=MBpL/KTIWltfV0vVEwaxUAu82564OLtV9bUA9afLFxxzdW79QXevRhWqWnoxyM+CpV 2CLVdBER4Oj7YQQvFrdqcLiT1YeeywxmckUaGQwzinWZg88SigCRLKB1AdlMUMl9DujZ TxImwUsqJc+HxTfj6B/XKfsilJ9FSd0zi7ntImCuX00k6jNasbKRHZWaxCqCxWiJLEcg yVcI8JvYdfS9rbZCunqWE5/N+2nO6459S+SRWYgyCKLauX/zQvfE/uzYOdyMsFv+HARN 3vHmXi3ytppT988P9Jqw5kW3be8oY1274bIztOgr0NVJTvBBCbHgTkc0cSdk8U+sSPdR GZMw== X-Gm-Message-State: AA+aEWZB/eNScoC4YdJEjV/9BfymbnMEgoO6sRH84iYKXgYUz+tmADZ3 4fWlmCKgtQG51KNtCkGAAAOFNMd9 X-Google-Smtp-Source: AFSGD/XbFvSam+nfFv1nl4JFmj5c3WaGZRwCLr5r0JuXa43GGI92pQyTY8FuuKyumCnz15Lu+ymwDw== X-Received: by 2002:adf:ce86:: with SMTP id r6mr18664608wrn.257.1544628247525; Wed, 12 Dec 2018 07:24:07 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 12 Dec 2018 16:23:07 +0100 Message-Id: <1544628195-37728-47-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1544628195-37728-1-git-send-email-pbonzini@redhat.com> References: <1544628195-37728-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::434 Subject: [Qemu-devel] [PULL 46/54] vhost-user-test: use g_cond_broadcast X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) g_cond_signal is rarely the right thing to do, it works now because vhost-user-test only has two threads but it is not correct in general. Fix it before adding more calls. Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Paolo Bonzini Message-Id: <1543851204-41186-7-git-send-email-pbonzini@redhat.com> --- tests/vhost-user-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index 45d58d8..656e519 100644 --- a/tests/vhost-user-test.c +++ b/tests/vhost-user-test.c @@ -393,7 +393,7 @@ static void chr_read(void *opaque, const uint8_t *buf, = int size) G_N_ELEMENTS(s->fds)); =20 /* signal the test that it can continue */ - g_cond_signal(&s->data_cond); + g_cond_broadcast(&s->data_cond); break; =20 case VHOST_USER_SET_VRING_KICK: @@ -419,7 +419,7 @@ static void chr_read(void *opaque, const uint8_t *buf, = int size) p =3D (uint8_t *) &msg; qemu_chr_fe_write_all(chr, p, VHOST_USER_HDR_SIZE); =20 - g_cond_signal(&s->data_cond); + g_cond_broadcast(&s->data_cond); break; =20 case VHOST_USER_SET_VRING_BASE: --=20 1.8.3.1