From nobody Fri Nov 7 00:45:55 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1544630143545321.63971962532037; Wed, 12 Dec 2018 07:55:43 -0800 (PST) Received: from localhost ([::1]:45724 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gX6rO-00021L-El for importer@patchew.org; Wed, 12 Dec 2018 10:55:42 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52734) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gX6N8-0001NG-9U for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:24:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gX6N3-0000e7-5T for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:24:26 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:38475) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gX6N1-0000Tx-15 for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:24:21 -0500 Received: by mail-wr1-x42f.google.com with SMTP id v13so18111224wrw.5 for ; Wed, 12 Dec 2018 07:24:02 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id u10sm15878859wrr.33.2018.12.12.07.24.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Dec 2018 07:24:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=7PsksNWoHejU852i6cVb4FcQujJbTtshZdAeL19mv/g=; b=PkEY4WcMjQHc4o6DTmVyWrUqT68AJGEoxREsVcM5mIORNFTiyEF7/BdhVMXcjCEBrI +OhI/wvQuv9+XZZhI1MnS1F6cABNPuO1IlDhYGU3VmncX0PJXW/k/nCL9z0wd/8cFbkW lTryMInbim5c6zu13XcbIBt/dVbwlnSHs/BgDeZ3uDwO3NlSqPjkOQIR4l4aQTC1FQyG KIE5Lv1EXtP2XlaXzz07iteE3LiqYHvsV240oSqwdgEHEqHl64Bqm65J0J3erkawLpDB 7DC8O0VPDtYCOzywroHp4kFg0+SRHNXRkSmAodQwmtxS8u17wIXAAnxbhHxfxHirSWCq E66g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=7PsksNWoHejU852i6cVb4FcQujJbTtshZdAeL19mv/g=; b=LyhF/3sk2RcLb29+1iCjR6xmDmnD+JRLO/N2eRyw+ypONVixqdDY2TNhT1cIG07FU3 cWhg4NWAUWwbR1DQtf66cyH76o0yoioLFS598v2B7Xit1LZuZfHoxfL0PXJvgPM0xpjH gMCu1NCeqmy0nx+wG+jzqfWpUkKLDlqbGzIRR9Px3HDpaEFuvD3C+DEg3TAEjaMkfaBY QqbOfUsXpAMflCYuCHIHBTV6TAtv61lJt7DdsEXifQ5CWc+R2nYcWNy2fgiHdWmQpjMq CMfi9kv6HW3E9eB7s9u6+BxlGfL5drb+zIe/EljmAxiIld+y0LbDs0gg5bnQ2psdC4XN yx6g== X-Gm-Message-State: AA+aEWatrhX76jrlrzvsRgVoxh6aPD3emWotqVm7lWlbkVB+i5/hJseh spIoYn3X2PXbtcg/uf8z5QMf8otV X-Google-Smtp-Source: AFSGD/XPHaEssT1QfthPn5FHUDM0EZH/TnrJnXjDadSjX/MDu1k9Y6Ui4V3/pOv0khNvcD4AnRkXBQ== X-Received: by 2002:adf:df01:: with SMTP id y1mr18508625wrl.127.1544628240909; Wed, 12 Dec 2018 07:24:00 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 12 Dec 2018 16:23:01 +0100 Message-Id: <1544628195-37728-41-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1544628195-37728-1-git-send-email-pbonzini@redhat.com> References: <1544628195-37728-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42f Subject: [Qemu-devel] [PULL 40/54] hw/watchdog/wdt_i6300esb : remove a unnecessary comment X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peng Hao Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Peng Hao The registered memory region of i6300esb is not suitable for coalesced mmio, because a write for the region may trigger an immediate action and can't be delayed. Signed-off-by: Peng Hao Message-Id: <1544253511-82742-1-git-send-email-peng.hao2@zte.com.cn> Signed-off-by: Paolo Bonzini --- hw/watchdog/wdt_i6300esb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c index 7b59469..1c6eddf 100644 --- a/hw/watchdog/wdt_i6300esb.c +++ b/hw/watchdog/wdt_i6300esb.c @@ -449,7 +449,6 @@ static void i6300esb_realize(PCIDevice *dev, Error **er= rp) memory_region_init_io(&d->io_mem, OBJECT(d), &i6300esb_ops, d, "i6300esb", 0x10); pci_register_bar(&d->dev, 0, 0, &d->io_mem); - /* qemu_register_coalesced_mmio (addr, 0x10); ? */ } =20 static void i6300esb_exit(PCIDevice *dev) --=20 1.8.3.1