From nobody Fri Nov 7 00:45:55 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1544628910408259.76030028854404; Wed, 12 Dec 2018 07:35:10 -0800 (PST) Received: from localhost ([::1]:45615 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gX6XV-0001fD-D7 for importer@patchew.org; Wed, 12 Dec 2018 10:35:09 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gX6MW-0000lG-Bw for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:23:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gX6MU-0000C0-De for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:23:48 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:36633) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gX6MS-0008JB-GF for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:23:45 -0500 Received: by mail-wm1-x331.google.com with SMTP id a18so6412214wmj.1 for ; Wed, 12 Dec 2018 07:23:22 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id u10sm15878859wrr.33.2018.12.12.07.23.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Dec 2018 07:23:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ctRbsjwq3h8bFqRfd6s2LOcH6gg+c6ZIouWMyTb2n+k=; b=aUNJe0tztt+Xu2YfrQQd2WBA5nmulvJjTx2R9Rh/hYbKPVJ8v8ExstopXJf8aiRGSF /nCZCC5KxxRdPMZKrj7xJzOkQcQsqxwjWjiRFIsy/u8gctpa+Bz7EBgfRdBQxRdHYo0G Wkv0AGVqW6N2DFqC8yi+5zS13aN4bAgZbeOkozNO7PG0LASdJKCj7wiQJcwZ1XG12eBR 4LQ/knQLNrUV/QMaDmFhCmEKV4doxSOORhy7N0bx8ho0BI/A9+RZKngh7rvgMyoogcRy 2C6ScuUUeWuP6skjXlbcLeeIkdsU041sFhfVuXVG+zKd5jZrJI0SsvqZk6bJb3+YU5UW tZxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ctRbsjwq3h8bFqRfd6s2LOcH6gg+c6ZIouWMyTb2n+k=; b=hx9CR4kf25QnuYw4i51POCcD+VCU8Fn++gD7hY0YGY82BykDBNttRygn1Wrbf5X0eg 2d2R2ocjfN+g6miIa5kcRGSh9rcALtNDrWe3lN8MWj19RzQRMPrDVAL+bBdeqv+SHkun eht0jrg4DHIER1Uq0PeTk7ktH23laemT+umeMR9g2K6/RivKiriIOktR8SYZin+xd7qw aypnRNqEED9K/D2cU8yozZ0/6NzJC32lf6gSkLdrz2I8BrF1e7lOAtjxjxQlkgtVDlxC yKCjrFMYMcO4dOuGCXAMTDOr40rdegqjBjD8TWRNyvb8WCZ34Rf3nXddYuSNWWhX1Opa iNwA== X-Gm-Message-State: AA+aEWZr7SHWZL+8N+gMvk4V9IrC4ezTijFlXqESrfB5BbbK2Mq2c1fR LtAJmvMdhyCiolT2xWFuZoug7ag+ X-Google-Smtp-Source: AFSGD/US12cDcthGVbUGLed0abkDAm65I0QnkTFBiZGd7VYSOiHuRD6lV9Pnp9eACvv5HDRGHtVndw== X-Received: by 2002:a1c:8d12:: with SMTP id p18mr7282941wmd.31.1544628201625; Wed, 12 Dec 2018 07:23:21 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 12 Dec 2018 16:22:24 +0100 Message-Id: <1544628195-37728-4-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1544628195-37728-1-git-send-email-pbonzini@redhat.com> References: <1544628195-37728-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::331 Subject: [Qemu-devel] [PULL 03/54] checkpatch: fix premature exit when no input or --mailback X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) In some cases, checkpatch's process subroutine is exiting the whole process. This is wrong, just return from the subroutine instead. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Paolo Bonzini --- scripts/checkpatch.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 60f6f89..b9974f0 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2820,19 +2820,19 @@ sub process { # If we have no input at all, then there is nothing to report on # so just keep quiet. if ($#rawlines =3D=3D -1) { - exit(0); + return 1; } =20 # In mailback mode only produce a report in the negative, for # things that appear to be patches. if ($mailback && ($clean =3D=3D 1 || !$is_patch)) { - exit(0); + return 1; } =20 # This is not a patch, and we are are in 'no-patch' mode so # just keep quiet. if (!$chk_patch && !$is_patch) { - exit(0); + return 1; } =20 if (!$is_patch) { --=20 1.8.3.1