From nobody Fri Nov 7 00:44:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1544629765059653.6551636087129; Wed, 12 Dec 2018 07:49:25 -0800 (PST) Received: from localhost ([::1]:45693 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gX6lI-0004ya-1o for importer@patchew.org; Wed, 12 Dec 2018 10:49:24 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52535) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gX6Mh-0000zq-8u for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:24:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gX6Md-0000Nj-7V for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:23:59 -0500 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:54482) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gX6Mc-0000MS-U0 for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:23:55 -0500 Received: by mail-wm1-x344.google.com with SMTP id a62so6179678wmh.4 for ; Wed, 12 Dec 2018 07:23:54 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id u10sm15878859wrr.33.2018.12.12.07.23.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Dec 2018 07:23:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Omg7v2Y7KTWH1aoAgDtptQTe4lugbmUuGw0+DjC3zqQ=; b=PWd2prEacNP/B6zqLNrdlIQz62+n4wp3qiqpGiPgzqsUczM/BdEw0gAPuo46VAs5OY 6ts3PG1I2Eh+ciyBpju1zuciErzBhVULumv9gIN8jG99zwgavckaFlpeFLskYT5ZOOPD ob9Ljc4y2PVn5FNocINJo/qyP9ZXqBtH7i8ox3uOUDTq5WYd1vpv3TrjsseyfIjBwSLU YCHO/J8pCU2j5ZpjLY0KOPVE4kJ8P6/IuswhqDUlL3YClEmEGSkhyTvxUuxYwwnMnuRD cRtEflminFEwyos8emYWyWMwYBgsUvU4xR9nITLD9Vq60oiKKr5mxKNCGwx721jsEefd rfRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Omg7v2Y7KTWH1aoAgDtptQTe4lugbmUuGw0+DjC3zqQ=; b=Q9hauGgw1jRTIi+EUb7fhVveGs8Jh78iuNGknApfi6bsutXN5d5OqL1y/IW1cFzcdD 0lRfbEWGNpM5Gbqp4VVQDlqWHiBh+gnbpREhG8Qds3HjqBLxelXYwddTjOMpcAHFxgAs GlgeUwV1pnQ+Hf2EChpHOAqysuKdsuwrgAdVbmiw2RaktrYLcIDVYFTfBKMyoy0/y+Bx QXehnd96ZGhWe+iu16xtcaDUlnVGCpIQIV763VBV457q10KLQ0JSTQ8gkOekQbGq4xq5 rhH0TnPZOlUskYEyrrpxxmuzywReiOUXo8jyN5bBpi2BfC7+udFsJjQb9mM5lbX15z+I LrEQ== X-Gm-Message-State: AA+aEWYOOk+IGVtnnBDNNM3Izo87gyd+5NWYUFjASN2T9DnQ3Dr/UWxM Kn5N/PQm8SGbAKlwpHvZkLvZ2vrS X-Google-Smtp-Source: AFSGD/UeTibPLzhIet+BrpxuqfCAYbIOMp8yaxCFj6cdgHQBVt1gELZ63sHgq7q+0DY9blzy3iLjrQ== X-Received: by 2002:a7b:cc86:: with SMTP id p6mr712327wma.19.1544628233461; Wed, 12 Dec 2018 07:23:53 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 12 Dec 2018 16:22:54 +0100 Message-Id: <1544628195-37728-34-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1544628195-37728-1-git-send-email-pbonzini@redhat.com> References: <1544628195-37728-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 Subject: [Qemu-devel] [PULL 33/54] configure: Add a test for the minimum compiler version X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Thomas Huth So far we only had implicit requirements for the minimum compiler version, e.g. we require at least GCC 4.1 for the support of atomics. However, such old compiler versions are not tested anymore by the developers, so they are not really supported anymore. Since we recently declared explicitly what platforms we intend to support, we can also get more explicit on the compiler version now. The supported distributions use the following version of GCC: RHEL-7: 4.8.5 Debian (Stretch): 6.3.0 Debian (Jessie): 4.8.4 OpenBSD (ports): 4.9.4 FreeBSD (ports): 8.2.0 OpenSUSE Leap 15: 7.3.1 Ubuntu (Xenial): 5.3.1 macOS (Homebrew): 8.2.0 So we can safely assume GCC 4.8 these days. For Clang, the situation is a little bit more ambiguous, since it is sometimes not available in the main distros but rather third party repositories. At least Debian Jessie uses version 3.5, and EPEL7 for RHEL7 uses 3.4, so let's use 3.4 as minimum Clang version now - we still can adjust this later if necessary. Unfortunately Apple uses different version numbers for the Clang that is included in their Xcode suite, so we need to check the version numbers for Xcode separately. Xcode 5.1 seems to be the first one that has been shipped with LLVM 3.4, so use this version as the minimum there. Signed-off-by: Thomas Huth Reviewed-by: Richard Henderson Message-Id: <1543937577-28256-2-git-send-email-thuth@redhat.com> --- configure | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/configure b/configure index 8c292ef..51150b1 100755 --- a/configure +++ b/configure @@ -1837,6 +1837,31 @@ if test "$bogus_os" =3D "yes"; then error_exit "Unrecognized host OS (uname -s reports '$(uname -s)')" fi =20 +# Check whether the compiler matches our minimum requirements: +cat > $TMPC << EOF +#if defined(__clang_major__) && defined(__clang_minor__) +# ifdef __apple_build_version__ +# if __clang_major__ < 5 || (__clang_major__ =3D=3D 5 && __clang_minor__ = < 1) +# error You need at least XCode Clang v5.1 to compile QEMU +# endif +# else +# if __clang_major__ < 3 || (__clang_major__ =3D=3D 3 && __clang_minor__ = < 4) +# error You need at least Clang v3.4 to compile QEMU +# endif +# endif +#elif defined(__GNUC__) && defined(__GNUC_MINOR__) +# if __GNUC__ < 4 || (__GNUC__ =3D=3D 4 && __GNUC_MINOR__ < 8) +# error You need at least GCC v4.8 to compile QEMU +# endif +#else +# error You either need GCC or Clang to compiler QEMU +#endif +int main (void) { return 0; } +EOF +if ! compile_prog "" "" ; then + error_exit "You need at least GCC v4.8 or Clang v3.4 (or XCode Clang v= 5.1)" +fi + gcc_flags=3D"-Wold-style-declaration -Wold-style-definition -Wtype-limits" gcc_flags=3D"-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifie= rs $gcc_flags" gcc_flags=3D"-Wno-missing-include-dirs -Wempty-body -Wnested-externs $gcc_= flags" --=20 1.8.3.1