From nobody Fri Nov 7 00:44:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1544629570064579.7956058789059; Wed, 12 Dec 2018 07:46:10 -0800 (PST) Received: from localhost ([::1]:45678 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gX6i8-0002XI-VX for importer@patchew.org; Wed, 12 Dec 2018 10:46:09 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gX6Mh-0000zT-5K for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:24:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gX6Mc-0000MK-4t for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:23:58 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:53232) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gX6Mb-0000KF-Q0 for qemu-devel@nongnu.org; Wed, 12 Dec 2018 10:23:53 -0500 Received: by mail-wm1-x32c.google.com with SMTP id m1so5558572wml.2 for ; Wed, 12 Dec 2018 07:23:53 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id u10sm15878859wrr.33.2018.12.12.07.23.51 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Dec 2018 07:23:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=aMMuU3/fl9YywPbugjmVSAgZ5BhbfQiCOVigCSoWUXQ=; b=Ju6aJV4v6ivAfp4EC/aZejLr+JwRoTIzsfGg9OGKiE55gG0+iWVHoZqxY393A/KRAK g5H4RGMbcT8sKCIX/nxYEjKu3mvYrjYMH6DJ8KgtE3b/l56+MIb29wBV0RMfZ0ZHt7BD a8SbdrrI6KaDjuLMfY0m8msG/05Ns4FAT4ZYQqAq34YuUlIcmHbAvsZLGxjS+CdI8QMV 4Sj3orFHpQqX19lQKpyQGh+t2sx7PfG5z26LsFT60lFHDq86s4BY+AHv8fJgEUWedTp6 9z271opHIBjFiU0nDX6IaZvTatjFgN8ON4h5YWMvjuWJqFT8TI+sVSo/VhlJFZoIRPBK +ObA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=aMMuU3/fl9YywPbugjmVSAgZ5BhbfQiCOVigCSoWUXQ=; b=ngSj2pnayd4qq/Lu7E2jv09x3Jip7FBP8LtWZ2a8TeuIfJ87y0WUB2QXrtFwcxWTXF NwqSUZqWhbZ6tu6n5NswPbNFa8WFFkMAJecvhQCm9B8InkKZuAcVrIhRO4VZM0X0v2Mb n6cucYTc9Ct752K7d6gHzUJvrQNvc+hkU0Z3ltCP9c6eFuoseaZGlKaxTAAvzwRwKCg2 fM8FzPg321inHay4KxynQgF9qaBEjoop6h32IC6kvdoYcJRIH8gfIWfexJrJdZvo90MR nkx1FFA/6bR8XLB8+412O1biGSGu44e9qXaYAn6ldX6mNpDGXkYphO4H4pizYPkP51u/ topQ== X-Gm-Message-State: AA+aEWb7hUaQSu2iyvJVMTcBtZevgDwUBrelkj59I9vwFpE7eZFoybZ3 GhjUFzSGiXmadPJbftcK6oCeOMXQ X-Google-Smtp-Source: AFSGD/X1jZNUHLocReh11BTmS2j8D9y8kVP8gkvJSPFlcNM2JrYyOHOPoM5s/GXrYHa+RzhEaKRMKw== X-Received: by 2002:a1c:c645:: with SMTP id w66mr7253452wmf.18.1544628232385; Wed, 12 Dec 2018 07:23:52 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 12 Dec 2018 16:22:53 +0100 Message-Id: <1544628195-37728-33-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1544628195-37728-1-git-send-email-pbonzini@redhat.com> References: <1544628195-37728-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32c Subject: [Qemu-devel] [PULL 32/54] checkpatch: warn about qemu/queue.h head structs that are not typedef-ed X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" These are just like any other struct or union, so they should have CamelCase typedefs. Signed-off-by: Paolo Bonzini --- scripts/checkpatch.pl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index a8d6e44..b4b3495 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2263,6 +2263,11 @@ sub process { } } =20 + if ($line =3D~ /^.\s*(Q(?:S?LIST|SIMPLEQ|TAILQ)_HEAD)\s*\(\s*[^,]/ && + $line !~ /^.typedef/) { + ERROR("named $1 should be typedefed separately\n" . $herecurr); + } + # Need a space before open parenthesis after if, while etc if ($line=3D~/\b(if|while|for|switch)\(/) { ERROR("space required before the open parenthesis '('\n" . $herecurr); --=20 1.8.3.1