From nobody Tue Feb 10 10:54:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1544098787695592.4638436118809; Thu, 6 Dec 2018 04:19:47 -0800 (PST) Received: from localhost ([::1]:40411 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUsd1-0006Kd-Ed for importer@patchew.org; Thu, 06 Dec 2018 07:19:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUsLl-00015w-59 for qemu-devel@nongnu.org; Thu, 06 Dec 2018 07:01:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gUsLf-00068Z-QH for qemu-devel@nongnu.org; Thu, 06 Dec 2018 07:01:47 -0500 Received: from mail.ispras.ru ([83.149.199.45]:60372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUsLd-0005uC-Fr for qemu-devel@nongnu.org; Thu, 06 Dec 2018 07:01:43 -0500 Received: from Misha-PC.lan02.inno (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id B578F540089; Thu, 6 Dec 2018 15:01:25 +0300 (MSK) From: Mikhail Abakumov To: qemu-devel@nongnu.org Date: Thu, 06 Dec 2018 15:01:21 +0300 Message-ID: <154409768093.5432.14349304881922492190.stgit@Misha-PC.lan02.inno> In-Reply-To: <154409751316.5432.3325938832238028060.stgit@Misha-PC.lan02.inno> References: <154409751316.5432.3325938832238028060.stgit@Misha-PC.lan02.inno> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [PATCH v3 29/39] windbg: implement kd_api_write_breakpoint and kd_api_restore_breakpoint X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sw@weilnetz.de, lprosek@redhat.com, dovgaluk@ispras.ru, rkagan@virtuozzo.com, pbonzini@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Mikhail Abakumov Signed-off-by: Pavel Dovgalyuk --- include/exec/windbgstub-utils.h | 3 ++ windbgstub-utils.c | 68 +++++++++++++++++++++++++++++++++++= ++++ windbgstub.c | 12 +++++++ 3 files changed, 83 insertions(+) diff --git a/include/exec/windbgstub-utils.h b/include/exec/windbgstub-util= s.h index 2781a54044..85b7322b82 100644 --- a/include/exec/windbgstub-utils.h +++ b/include/exec/windbgstub-utils.h @@ -71,8 +71,11 @@ void kd_api_read_virtual_memory(CPUState *cs, PacketData= *pd); void kd_api_write_virtual_memory(CPUState *cs, PacketData *pd); void kd_api_get_context(CPUState *cs, PacketData *pd); void kd_api_set_context(CPUState *cs, PacketData *pd); +void kd_api_write_breakpoint(CPUState *cs, PacketData *pd); +void kd_api_restore_breakpoint(CPUState *cs, PacketData *pd); void kd_api_read_control_space(CPUState *cs, PacketData *pd); void kd_api_write_control_space(CPUState *cs, PacketData *pd); +void kd_api_clear_all_internal_breakpoints(CPUState *cs, PacketData *pd); void kd_api_get_context_ex(CPUState *cs, PacketData *pd); void kd_api_set_context_ex(CPUState *cs, PacketData *pd); void kd_api_unsupported(CPUState *cs, PacketData *pd); diff --git a/windbgstub-utils.c b/windbgstub-utils.c index e7da2d5dd8..e4b7c4e6d0 100644 --- a/windbgstub-utils.c +++ b/windbgstub-utils.c @@ -80,6 +80,8 @@ static const char *kd_packet_type_names[] =3D { "PACKET_TYPE_MAX", }; =20 +static InitedAddr bps[KD_BREAKPOINT_MAX]; + static void prep_bmbc(const uint8_t *pattern, int pLen, int bmBc[]) { int i; @@ -247,6 +249,72 @@ void kd_api_write_virtual_memory(CPUState *cs, PacketD= ata *pd) stl_p(&mem->ActualBytesWritten, len); } =20 +void kd_api_write_breakpoint(CPUState *cs, PacketData *pd) +{ + DBGKD_WRITE_BREAKPOINT64 *m64c =3D &pd->m64.u.WriteBreakPoint; + target_ulong addr; + int i, err =3D 0; + + addr =3D ldtul_p(&m64c->BreakPointAddress); + + for (i =3D 0; i < KD_BREAKPOINT_MAX; ++i) { + if (!bps[i].is_init) { + err =3D cpu_breakpoint_insert(cs, addr, BP_GDB, NULL); + if (!err) { + bps[i].addr =3D addr; + bps[i].is_init =3D true; + DPRINTF("write_breakpoint: " FMT_ADDR ", index(%d)\n", + addr, i); + break; + } else { + WINDBG_ERROR("write_breakpoint: " FMT_ADDR ", " FMT_ERR, a= ddr, + err); + pd->m64.ReturnStatus =3D STATUS_UNSUCCESSFUL; + return; + } + } else if (addr =3D=3D bps[i].addr) { + break; + } + } + + if (!err) { + stl_p(&m64c->BreakPointHandle, i + 1); + pd->m64.ReturnStatus =3D STATUS_SUCCESS; + } else { + WINDBG_ERROR("write_breakpoint: All breakpoints occupied"); + pd->m64.ReturnStatus =3D STATUS_UNSUCCESSFUL; + } +} + +void kd_api_restore_breakpoint(CPUState *cs, PacketData *pd) +{ + DBGKD_RESTORE_BREAKPOINT *m64c =3D &pd->m64.u.RestoreBreakPoint; + uint8_t index; + int err =3D -1; + + index =3D ldtul_p(&m64c->BreakPointHandle) - 1; + + if (bps[index].is_init) { + err =3D cpu_breakpoint_remove(cs, bps[index].addr, BP_GDB); + if (!err) { + DPRINTF("restore_breakpoint: " FMT_ADDR ", index(%d)\n", + bps[index].addr, index); + } else { + WINDBG_ERROR("restore_breakpoint: " FMT_ADDR + ", index(%d), " FMT_ERR, + bps[index].addr, index, err); + } + bps[index].is_init =3D false; + pd->m64.ReturnStatus =3D STATUS_SUCCESS; + } else { + pd->m64.ReturnStatus =3D STATUS_SUCCESS; + } +} + +void kd_api_clear_all_internal_breakpoints(CPUState *cs, PacketData *pd) +{ +} + void kd_api_unsupported(CPUState *cs, PacketData *pd) { WINDBG_ERROR("Caught unimplemented api %s", kd_api_name(pd->m64.ApiNum= ber)); diff --git a/windbgstub.c b/windbgstub.c index 328a04735f..a1c013cd8c 100644 --- a/windbgstub.c +++ b/windbgstub.c @@ -165,6 +165,14 @@ static void windbg_process_manipulate_packet(WindbgSta= te *state) kd_api_set_context(cs, data); break; =20 + case DbgKdWriteBreakPointApi: + kd_api_write_breakpoint(cs, data); + break; + + case DbgKdRestoreBreakPointApi: + kd_api_restore_breakpoint(cs, data); + break; + case DbgKdReadControlSpaceApi: kd_api_read_control_space(cs, data); break; @@ -173,6 +181,10 @@ static void windbg_process_manipulate_packet(WindbgSta= te *state) kd_api_write_control_space(cs, data); break; =20 + case DbgKdClearAllInternalBreakpointsApi: + kd_api_clear_all_internal_breakpoints(cs, data); + return; + case DbgKdGetContextExApi: kd_api_get_context_ex(cs, data); break;