From nobody Mon Feb 9 23:39:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1544098251202777.7130821974748; Thu, 6 Dec 2018 04:10:51 -0800 (PST) Received: from localhost ([::1]:40366 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUsUS-00085h-CM for importer@patchew.org; Thu, 06 Dec 2018 07:10:48 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUsKk-0000O1-5m for qemu-devel@nongnu.org; Thu, 06 Dec 2018 07:00:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gUsKg-0005XT-3y for qemu-devel@nongnu.org; Thu, 06 Dec 2018 07:00:46 -0500 Received: from mail.ispras.ru ([83.149.199.45]:60180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUsKf-0005XC-PE for qemu-devel@nongnu.org; Thu, 06 Dec 2018 07:00:41 -0500 Received: from Misha-PC.lan02.inno (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id 0BD8F540089; Thu, 6 Dec 2018 15:00:41 +0300 (MSK) From: Mikhail Abakumov To: qemu-devel@nongnu.org Date: Thu, 06 Dec 2018 15:00:36 +0300 Message-ID: <154409763623.5432.8362322737094435114.stgit@Misha-PC.lan02.inno> In-Reply-To: <154409751316.5432.3325938832238028060.stgit@Misha-PC.lan02.inno> References: <154409751316.5432.3325938832238028060.stgit@Misha-PC.lan02.inno> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [PATCH v3 21/39] windbg: implement kd_api_read_virtual_memory and kd_api_write_virtual_memory X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sw@weilnetz.de, lprosek@redhat.com, dovgaluk@ispras.ru, rkagan@virtuozzo.com, pbonzini@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Mikhail Abakumov Signed-off-by: Pavel Dovgalyuk --- include/exec/windbgstub-utils.h | 2 ++ windbgstub-utils.c | 47 +++++++++++++++++++++++++++++++++++= ++++ windbgstub.c | 8 +++++++ 3 files changed, 57 insertions(+) diff --git a/include/exec/windbgstub-utils.h b/include/exec/windbgstub-util= s.h index 1c577ddd49..638b2b9a6f 100644 --- a/include/exec/windbgstub-utils.h +++ b/include/exec/windbgstub-utils.h @@ -67,6 +67,8 @@ typedef struct PacketData { const char *kd_api_name(int id); const char *kd_pkt_type_name(int id); =20 +void kd_api_read_virtual_memory(CPUState *cs, PacketData *pd); +void kd_api_write_virtual_memory(CPUState *cs, PacketData *pd); void kd_api_unsupported(CPUState *cs, PacketData *pd); =20 DBGKD_ANY_WAIT_STATE_CHANGE *kd_state_change_exc(CPUState *cs); diff --git a/windbgstub-utils.c b/windbgstub-utils.c index 1455693975..e7da2d5dd8 100644 --- a/windbgstub-utils.c +++ b/windbgstub-utils.c @@ -200,6 +200,53 @@ InitedAddr windbg_search_vmaddr(CPUState *cs, target_u= long start, return ret; } =20 +void kd_api_read_virtual_memory(CPUState *cs, PacketData *pd) +{ + DBGKD_READ_MEMORY64 *mem =3D &pd->m64.u.ReadMemory; + uint32_t len; + target_ulong addr; + int err; + + len =3D MIN(ldl_p(&mem->TransferCount), + PACKET_MAX_SIZE - sizeof(DBGKD_MANIPULATE_STATE64)); + addr =3D ldtul_p(&mem->TargetBaseAddress); + err =3D cpu_memory_rw_debug(cs, addr, pd->extra, len, 0); + + if (err) { + len =3D 0; + pd->m64.ReturnStatus =3D STATUS_UNSUCCESSFUL; + + DPRINTF("read_virtual_memory: No physical page mapped: " FMT_ADDR = "\n", + addr); + } + + pd->extra_size =3D len; + stl_p(&mem->ActualBytesRead, len); +} + +void kd_api_write_virtual_memory(CPUState *cs, PacketData *pd) +{ + DBGKD_WRITE_MEMORY64 *mem =3D &pd->m64.u.WriteMemory; + uint32_t len; + target_ulong addr; + int err; + + len =3D MIN(ldl_p(&mem->TransferCount), pd->extra_size); + addr =3D ldtul_p(&mem->TargetBaseAddress); + err =3D cpu_memory_rw_debug(cs, addr, pd->extra, len, 1); + + if (err) { + len =3D 0; + pd->m64.ReturnStatus =3D STATUS_UNSUCCESSFUL; + + DPRINTF("read_write_memory: No physical page mapped: " FMT_ADDR "\= n", + addr); + } + + pd->extra_size =3D 0; + stl_p(&mem->ActualBytesWritten, len); +} + void kd_api_unsupported(CPUState *cs, PacketData *pd) { WINDBG_ERROR("Caught unimplemented api %s", kd_api_name(pd->m64.ApiNum= ber)); diff --git a/windbgstub.c b/windbgstub.c index 6ed93b8ce9..46400d9bad 100644 --- a/windbgstub.c +++ b/windbgstub.c @@ -149,6 +149,14 @@ static void windbg_process_manipulate_packet(WindbgSta= te *state) } =20 switch (data->m64.ApiNumber) { + case DbgKdReadVirtualMemoryApi: + kd_api_read_virtual_memory(cs, data); + break; + + case DbgKdWriteVirtualMemoryApi: + kd_api_write_virtual_memory(cs, data); + break; + default: kd_api_unsupported(cs, data); break;