From nobody Mon Feb 9 23:03:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 154409925065823.952257763891225; Thu, 6 Dec 2018 04:27:30 -0800 (PST) Received: from localhost ([::1]:40460 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUskW-0004Wt-Cp for importer@patchew.org; Thu, 06 Dec 2018 07:27:24 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUsKg-0000Ie-64 for qemu-devel@nongnu.org; Thu, 06 Dec 2018 07:00:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gUsKa-0005Rl-GP for qemu-devel@nongnu.org; Thu, 06 Dec 2018 07:00:42 -0500 Received: from mail.ispras.ru ([83.149.199.45]:60156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUsKa-0005QY-4Z for qemu-devel@nongnu.org; Thu, 06 Dec 2018 07:00:36 -0500 Received: from Misha-PC.lan02.inno (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id 6CC77540089; Thu, 6 Dec 2018 15:00:35 +0300 (MSK) From: Mikhail Abakumov To: qemu-devel@nongnu.org Date: Thu, 06 Dec 2018 15:00:30 +0300 Message-ID: <154409763050.5432.9603759721356480431.stgit@Misha-PC.lan02.inno> In-Reply-To: <154409751316.5432.3325938832238028060.stgit@Misha-PC.lan02.inno> References: <154409751316.5432.3325938832238028060.stgit@Misha-PC.lan02.inno> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [PATCH v3 20/39] windbg: implement windbg_process_manipulate_packet X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sw@weilnetz.de, lprosek@redhat.com, dovgaluk@ispras.ru, rkagan@virtuozzo.com, pbonzini@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Mikhail Abakumov Signed-off-by: Pavel Dovgalyuk --- include/exec/windbgstub-utils.h | 2 ++ windbgstub-utils.c | 7 +++++++ windbgstub.c | 27 +++++++++++++++++++++++++++ 3 files changed, 36 insertions(+) diff --git a/include/exec/windbgstub-utils.h b/include/exec/windbgstub-util= s.h index 794cb387b0..1c577ddd49 100644 --- a/include/exec/windbgstub-utils.h +++ b/include/exec/windbgstub-utils.h @@ -67,6 +67,8 @@ typedef struct PacketData { const char *kd_api_name(int id); const char *kd_pkt_type_name(int id); =20 +void kd_api_unsupported(CPUState *cs, PacketData *pd); + DBGKD_ANY_WAIT_STATE_CHANGE *kd_state_change_exc(CPUState *cs); DBGKD_ANY_WAIT_STATE_CHANGE *kd_state_change_ls(CPUState *cs); =20 diff --git a/windbgstub-utils.c b/windbgstub-utils.c index 6c5a86f667..1455693975 100644 --- a/windbgstub-utils.c +++ b/windbgstub-utils.c @@ -200,6 +200,13 @@ InitedAddr windbg_search_vmaddr(CPUState *cs, target_u= long start, return ret; } =20 +void kd_api_unsupported(CPUState *cs, PacketData *pd) +{ + WINDBG_ERROR("Caught unimplemented api %s", kd_api_name(pd->m64.ApiNum= ber)); + pd->m64.ReturnStatus =3D STATUS_UNSUCCESSFUL; + pd->extra_size =3D 0; +} + const char *kd_api_name(int id) { return (id >=3D DbgKdMinimumManipulate && id < DbgKdMaximumManipulate) diff --git a/windbgstub.c b/windbgstub.c index 8cbece40da..6ed93b8ce9 100644 --- a/windbgstub.c +++ b/windbgstub.c @@ -136,6 +136,33 @@ static void windbg_vm_stop(void) =20 static void windbg_process_manipulate_packet(WindbgState *state) { + CPUState *cs; + ParsingContext *ctx =3D &state->ctx; + PacketData *data =3D &ctx->data; + + data->extra_size =3D ctx->packet.ByteCount - sizeof(DBGKD_MANIPULATE_S= TATE64); + data->m64.ReturnStatus =3D STATUS_SUCCESS; + + cs =3D qemu_get_cpu(data->m64.Processor); + if (cs =3D=3D NULL) { + cs =3D qemu_get_cpu(0); + } + + switch (data->m64.ApiNumber) { + default: + kd_api_unsupported(cs, data); + break; + } + + if (data->m64.ReturnStatus =3D=3D STATUS_UNSUCCESSFUL) { + WINDBG_ERROR("Caught error at %s", kd_api_name(data->m64.ApiNumber= )); + } + + stl_p(&data->m64.ReturnStatus, data->m64.ReturnStatus); + + windbg_send_data_packet(state, data->buf, + data->extra_size + sizeof(DBGKD_MANIPULATE_STA= TE64), + ctx->packet.PacketType); } =20 static void windbg_process_data_packet(WindbgState *state)