From nobody Mon Feb 9 23:18:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543504269963567.9704347909395; Thu, 29 Nov 2018 07:11:09 -0800 (PST) Received: from localhost ([::1]:54710 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSNy8-0002se-Mw for importer@patchew.org; Thu, 29 Nov 2018 10:11:08 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSNKZ-00065Z-Rw for qemu-devel@nongnu.org; Thu, 29 Nov 2018 09:30:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSNKV-0001Fd-R1 for qemu-devel@nongnu.org; Thu, 29 Nov 2018 09:30:15 -0500 Received: from mail.ispras.ru ([83.149.199.45]:39898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSNKV-0001Du-EN for qemu-devel@nongnu.org; Thu, 29 Nov 2018 09:30:11 -0500 Received: from Misha-PC.lan02.inno (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id A78F55401AE; Thu, 29 Nov 2018 17:30:10 +0300 (MSK) From: Mikhail Abakumov To: qemu-devel@nongnu.org Date: Thu, 29 Nov 2018 17:30:08 +0300 Message-ID: <154350180810.8036.6259045508996849140.stgit@Misha-PC.lan02.inno> In-Reply-To: <154350164526.8036.12623669071583857903.stgit@Misha-PC.lan02.inno> References: <154350164526.8036.12623669071583857903.stgit@Misha-PC.lan02.inno> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [PATCH 28/39] windbg: implement kd_api_read_control_space and kd_api_write_control_space X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sw@weilnetz.de, lprosek@redhat.com, dovgaluk@ispras.ru, rkagan@virtuozzo.com, pbonzini@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Mikhail Abakumov Signed-off-by: Pavel Dovgalyuk --- include/exec/windbgstub-utils.h | 2 + target/i386/windbgstub.c | 81 +++++++++++++++++++++++++++++++++++= ++++ windbgstub.c | 8 ++++ 3 files changed, 91 insertions(+) diff --git a/include/exec/windbgstub-utils.h b/include/exec/windbgstub-util= s.h index 6936fd0ffb..2781a54044 100644 --- a/include/exec/windbgstub-utils.h +++ b/include/exec/windbgstub-utils.h @@ -71,6 +71,8 @@ void kd_api_read_virtual_memory(CPUState *cs, PacketData = *pd); void kd_api_write_virtual_memory(CPUState *cs, PacketData *pd); void kd_api_get_context(CPUState *cs, PacketData *pd); void kd_api_set_context(CPUState *cs, PacketData *pd); +void kd_api_read_control_space(CPUState *cs, PacketData *pd); +void kd_api_write_control_space(CPUState *cs, PacketData *pd); void kd_api_get_context_ex(CPUState *cs, PacketData *pd); void kd_api_set_context_ex(CPUState *cs, PacketData *pd); void kd_api_unsupported(CPUState *cs, PacketData *pd); diff --git a/target/i386/windbgstub.c b/target/i386/windbgstub.c index 946f5cdb6a..c982eff590 100644 --- a/target/i386/windbgstub.c +++ b/target/i386/windbgstub.c @@ -962,6 +962,87 @@ void kd_api_set_context(CPUState *cs, PacketData *pd) } } =20 +void kd_api_read_control_space(CPUState *cs, PacketData *pd) +{ + DBGKD_READ_MEMORY64 *mem =3D &pd->m64.u.ReadMemory; + target_ulong addr =3D ldtul_p(&mem->TargetBaseAddress); + uint32_t len =3D MIN(ldl_p(&mem->TransferCount), + PACKET_MAX_SIZE - sizeof(DBGKD_MANIPULATE_STATE64)); + int err =3D 0; + +#ifdef TARGET_X86_64 + + switch (addr) { + case AMD64_DEBUG_CONTROL_SPACE_KPCR: + addr =3D KPCR.addr; + len =3D sizeof(target_ulong); + err =3D cpu_memory_rw_debug(cs, addr, pd->extra, len, 0); + break; + + case AMD64_DEBUG_CONTROL_SPACE_KPRCB: + addr =3D VMEM_ADDR(cs, KPCR.addr + OFFSET_KPRCB); + len =3D sizeof(target_ulong); + err =3D cpu_memory_rw_debug(cs, addr, pd->extra, len, 0); + break; + + case AMD64_DEBUG_CONTROL_SPACE_KSPECIAL: + len =3D MIN(len, sizeof(CPU_KSPECIAL_REGISTERS)); + err =3D windbg_read_ks_regs(cs, pd->extra, len, 0, len); + break; + + case AMD64_DEBUG_CONTROL_SPACE_KTHREAD: + addr =3D VMEM_ADDR(cs, addr + OFFSET_KPRCB_CURRTHREAD); + len =3D sizeof(target_ulong); + err =3D cpu_memory_rw_debug(cs, addr, pd->extra, len, 0); + break; + } + +#else /* TARGET_I386 */ + + err =3D windbg_rw_context_ex(cs, pd->extra, len, addr, len, true); + +#endif /* TARGET_I386 */ + + if (err) { + len =3D 0; + pd->m64.ReturnStatus =3D STATUS_UNSUCCESSFUL; + } + + pd->extra_size =3D len; + stl_p(&mem->ActualBytesRead, len); +} + +void kd_api_write_control_space(CPUState *cs, PacketData *pd) +{ + DBGKD_WRITE_MEMORY64 *mem =3D &pd->m64.u.WriteMemory; + target_ulong addr =3D ldtul_p(&mem->TargetBaseAddress); + uint32_t len =3D MIN(ldl_p(&mem->TransferCount), pd->extra_size); + int err =3D 0; + +#ifdef TARGET_X86_64 + + if (addr =3D=3D AMD64_DEBUG_CONTROL_SPACE_KSPECIAL) { + len =3D MIN(len, sizeof(CPU_KSPECIAL_REGISTERS)); + err =3D windbg_write_ks_regs(cs, pd->extra, len, 0, len); + } else { + err =3D 1; + } + +#else /* TARGET_I386 */ + + err =3D windbg_rw_context_ex(cs, pd->extra, len, addr, len, false); + +#endif /* TARGET_I386 */ + + if (err) { + len =3D 0; + pd->m64.ReturnStatus =3D STATUS_UNSUCCESSFUL; + } + + pd->extra_size =3D 0; + stl_p(&mem->ActualBytesWritten, len); +} + void kd_api_get_context_ex(CPUState *cs, PacketData *pd) { DBGKD_CONTEXT_EX *ctx =3D &pd->m64.u.ContextEx; diff --git a/windbgstub.c b/windbgstub.c index e9d759cddf..328a04735f 100644 --- a/windbgstub.c +++ b/windbgstub.c @@ -165,6 +165,14 @@ static void windbg_process_manipulate_packet(WindbgSta= te *state) kd_api_set_context(cs, data); break; =20 + case DbgKdReadControlSpaceApi: + kd_api_read_control_space(cs, data); + break; + + case DbgKdWriteControlSpaceApi: + kd_api_write_control_space(cs, data); + break; + case DbgKdGetContextExApi: kd_api_get_context_ex(cs, data); break;