From nobody Mon Feb 9 23:03:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543504391445764.8800275703653; Thu, 29 Nov 2018 07:13:11 -0800 (PST) Received: from localhost ([::1]:54720 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSO06-0004ch-5f for importer@patchew.org; Thu, 29 Nov 2018 10:13:10 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53806) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSNKR-0005td-Cx for qemu-devel@nongnu.org; Thu, 29 Nov 2018 09:30:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSNKQ-00017G-4j for qemu-devel@nongnu.org; Thu, 29 Nov 2018 09:30:07 -0500 Received: from mail.ispras.ru ([83.149.199.45]:39868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSNKP-00016o-Nb for qemu-devel@nongnu.org; Thu, 29 Nov 2018 09:30:06 -0500 Received: from Misha-PC.lan02.inno (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id 004225401A6; Thu, 29 Nov 2018 17:30:04 +0300 (MSK) From: Mikhail Abakumov To: qemu-devel@nongnu.org Date: Thu, 29 Nov 2018 17:30:02 +0300 Message-ID: <154350180245.8036.10920220798523961282.stgit@Misha-PC.lan02.inno> In-Reply-To: <154350164526.8036.12623669071583857903.stgit@Misha-PC.lan02.inno> References: <154350164526.8036.12623669071583857903.stgit@Misha-PC.lan02.inno> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [PATCH 27/39] windbg: implement kd_api_get_context_ex and kd_api_set_context_ex X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sw@weilnetz.de, lprosek@redhat.com, dovgaluk@ispras.ru, rkagan@virtuozzo.com, pbonzini@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Mikhail Abakumov Signed-off-by: Pavel Dovgalyuk --- include/exec/windbgstub-utils.h | 2 + target/i386/windbgstub.c | 90 +++++++++++++++++++++++++++++++++++= +--- windbgstub.c | 8 +++ 3 files changed, 93 insertions(+), 7 deletions(-) diff --git a/include/exec/windbgstub-utils.h b/include/exec/windbgstub-util= s.h index a88e013de9..6936fd0ffb 100644 --- a/include/exec/windbgstub-utils.h +++ b/include/exec/windbgstub-utils.h @@ -71,6 +71,8 @@ void kd_api_read_virtual_memory(CPUState *cs, PacketData = *pd); void kd_api_write_virtual_memory(CPUState *cs, PacketData *pd); void kd_api_get_context(CPUState *cs, PacketData *pd); void kd_api_set_context(CPUState *cs, PacketData *pd); +void kd_api_get_context_ex(CPUState *cs, PacketData *pd); +void kd_api_set_context_ex(CPUState *cs, PacketData *pd); void kd_api_unsupported(CPUState *cs, PacketData *pd); =20 DBGKD_ANY_WAIT_STATE_CHANGE *kd_state_change_exc(CPUState *cs); diff --git a/target/i386/windbgstub.c b/target/i386/windbgstub.c index d08660c6fd..946f5cdb6a 100644 --- a/target/i386/windbgstub.c +++ b/target/i386/windbgstub.c @@ -884,18 +884,57 @@ static int fun_name(CPUState *cs, uint8_t *buf, int b= uf_size, \ return 0; = \ } =20 -__attribute__ ((unused)) /* unused yet */ GEN_WINDBG_CONTEXT_RW(windbg_read_context, false) - -__attribute__ ((unused)) /* unused yet */ GEN_WINDBG_CONTEXT_RW(windbg_write_context, true) - -__attribute__ ((unused)) /* unused yet */ GEN_WINDBG_KSPEC_REGS_RW(windbg_read_ks_regs, false) - -__attribute__ ((unused)) /* unused yet */ GEN_WINDBG_KSPEC_REGS_RW(windbg_write_ks_regs, true) =20 +static int windbg_rw_context_ex(CPUState *cs, uint8_t *buf, int buf_size, + int offset, int len, bool is_read) +{ + int context_len; + int ks_regs_len; + int err =3D -1; + + if (offset < sizeof(CPU_KPROCESSOR_STATE)) { + len =3D MIN(len, sizeof(CPU_KPROCESSOR_STATE) - offset); + + context_len =3D MAX(0, (int) (sizeof(CPU_CONTEXT) - offset)); + ks_regs_len =3D len - context_len; + + if (context_len > 0) { + if (is_read) { + err =3D windbg_read_context(cs, buf, context_len, offset, + context_len); + } else { + err =3D windbg_write_context(cs, buf, context_len, offset, + context_len); + } + + if (err) { + return err; + } + } + + if (ks_regs_len > 0) { + offset +=3D context_len - sizeof(CPU_CONTEXT); + if (is_read) { + err =3D windbg_read_ks_regs(cs, buf + context_len, ks_regs= _len, + offset, ks_regs_len); + } else { + err =3D windbg_write_ks_regs(cs, buf + context_len, ks_reg= s_len, + offset, ks_regs_len); + } + + if (err) { + return err; + } + } + } + + return err; +} + void kd_api_get_context(CPUState *cs, PacketData *pd) { int err; @@ -923,6 +962,43 @@ void kd_api_set_context(CPUState *cs, PacketData *pd) } } =20 +void kd_api_get_context_ex(CPUState *cs, PacketData *pd) +{ + DBGKD_CONTEXT_EX *ctx =3D &pd->m64.u.ContextEx; + uint32_t offset =3D ldl_p(&ctx->Offset); + uint32_t len =3D MIN(ldl_p(&ctx->ByteCount), + PACKET_MAX_SIZE - sizeof(DBGKD_MANIPULATE_STATE64)); + int err; + + err =3D windbg_rw_context_ex(cs, pd->extra, len, offset, len, true); + + if (err) { + len =3D 0; + pd->m64.ReturnStatus =3D STATUS_UNSUCCESSFUL; + } + + pd->extra_size =3D len; + stl_p(&ctx->BytesCopied, len); +} + +void kd_api_set_context_ex(CPUState *cs, PacketData *pd) +{ + DBGKD_CONTEXT_EX *ctx =3D &pd->m64.u.ContextEx; + uint32_t offset =3D ldl_p(&ctx->Offset); + uint32_t len =3D MIN(ldl_p(&ctx->ByteCount), pd->extra_size); + int err; + + err =3D windbg_rw_context_ex(cs, pd->extra, len, offset, len, false); + + if (err) { + len =3D 0; + pd->m64.ReturnStatus =3D STATUS_UNSUCCESSFUL; + } + + pd->extra_size =3D 0; + stl_p(&ctx->BytesCopied, len); +} + static bool find_KPCR(CPUState *cs) { X86CPU *cpu =3D X86_CPU(cs); diff --git a/windbgstub.c b/windbgstub.c index 70ebf3c0ad..e9d759cddf 100644 --- a/windbgstub.c +++ b/windbgstub.c @@ -165,6 +165,14 @@ static void windbg_process_manipulate_packet(WindbgSta= te *state) kd_api_set_context(cs, data); break; =20 + case DbgKdGetContextExApi: + kd_api_get_context_ex(cs, data); + break; + + case DbgKdSetContextExApi: + kd_api_set_context_ex(cs, data); + break; + default: kd_api_unsupported(cs, data); break;