From nobody Mon Feb 9 11:32:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543329898395659.9028941307422; Tue, 27 Nov 2018 06:44:58 -0800 (PST) Received: from localhost ([::1]:42810 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRebg-0003PF-El for importer@patchew.org; Tue, 27 Nov 2018 09:44:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gReTx-0003nm-AA for qemu-devel@nongnu.org; Tue, 27 Nov 2018 09:36:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gReTt-0001TD-Dz for qemu-devel@nongnu.org; Tue, 27 Nov 2018 09:36:57 -0500 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:35989) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gReTt-0001Qg-7a for qemu-devel@nongnu.org; Tue, 27 Nov 2018 09:36:53 -0500 Received: by mail-wr1-x42d.google.com with SMTP id t3so22937214wrr.3 for ; Tue, 27 Nov 2018 06:36:53 -0800 (PST) Received: from 640k.localdomain ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id n62sm2821869wmd.25.2018.11.27.06.36.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Nov 2018 06:36:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Nk6+a4DawL2N1QW/CZzr0Aj8iuE6PQzwt+0dEITLfWU=; b=tr0vRO4Xkjgvy2OkOWjl8c8jjtnOKr3simWQi1Bjw8+rHiLOp5cNhSlK4hY5OvMOeH N0k2n9+kew78UJA5GOSr1Px6m42hldrQyGqOHGiWm1/DsFUE8t1D7xVgR+/vHM4j5NDM ysoPsTkulEOfHHwxcT5S17zhThty1GUMPRDhj7ptafFeDBUUfns6FJBh64KBHDR7uM58 g8ETvfGbRw6uArmVocKe3yLOhTPm5WHxeaP8vISIq0clnCjur6Nc00Se6fee/HGe2Cb6 y24nR2Y6yyuIvrEQt2z9FQ3PAjvQ0GGv3kULoha/7I+vB3HhBgsYI2MWkYw0zHdXZyrW w7+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Nk6+a4DawL2N1QW/CZzr0Aj8iuE6PQzwt+0dEITLfWU=; b=rM/4WNbG7h3G9M9KEYXFS14pmyKHJgQ9KuKdB19pi5FFA2IpBpbGhnYka8m1hmlI2t 0uya5U0A74wEKrpkEnOh7+wKgTKVvB3RIm39FPtrka2JF7/SUyCErvuPYKmA3xv+IQCb b7Lt8z2P9AHBHyefS7pMbdcPnddUYvu6qy8NeeRUZ/iRyK4qjcJbB+KoeR82im3TIlbh ZUeZyKvlkzFTKtHU0PNgnp94/k5pplJKotuhhflEHk3ejVGmnIhfWyoVDIV0hhVIdCfo zXt6pKB0TyQF/46ZDfwtJKg/SXE24Ld9f4u1Rjwn350cIP+4c/IbVQ6i70JBadCSFgra o1cg== X-Gm-Message-State: AA+aEWYXh/pPta9abo34oOJhyVcZxcsQtOidPc9haPoUja+Ssxr+wrZW VgNWiQuGaKhhR0Gi/L/gKhzlcNEs X-Google-Smtp-Source: AFSGD/UrHbOYPPp+eISwQEkMpyVfHEf2597zody9fDrpwyPndjS75EkU3xn7zVVCZdUfpKmsonWhrQ== X-Received: by 2002:adf:9246:: with SMTP id 64mr12794856wrj.130.1543329411709; Tue, 27 Nov 2018 06:36:51 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 27 Nov 2018 15:36:28 +0100 Message-Id: <1543329397-48407-7-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1543329397-48407-1-git-send-email-pbonzini@redhat.com> References: <1543329397-48407-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42d Subject: [Qemu-devel] [PULL 06/15] vl: Improve error message when we can't load fw_cfg from file X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Li Qiang parse_fw_cfg() reports "can't load" without further details. Get the details from g_file_get_contents(), and include them in the error message. Signed-off-by: Li Qiang Message-Id: <1541051971-28584-1-git-send-email-liq3ea@gmail.com> Signed-off-by: Paolo Bonzini --- vl.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index d6fd95c..611d887 100644 --- a/vl.c +++ b/vl.c @@ -2250,8 +2250,10 @@ static int parse_fw_cfg(void *opaque, QemuOpts *opts= , Error **errp) size =3D strlen(str); /* NUL terminator NOT included in fw_cfg blo= b */ buf =3D g_memdup(str, size); } else { - if (!g_file_get_contents(file, &buf, &size, NULL)) { - error_setg(errp, "can't load %s", file); + GError *err =3D NULL; + if (!g_file_get_contents(file, &buf, &size, &err)) { + error_setg(errp, "can't load %s: %s", file, err->message); + g_error_free(err); return -1; } } --=20 1.8.3.1