From nobody Mon Feb 9 06:38:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543261378310825.7074708637281; Mon, 26 Nov 2018 11:42:58 -0800 (PST) Received: from localhost ([::1]:38442 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRMmW-0000tM-HH for importer@patchew.org; Mon, 26 Nov 2018 14:42:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRMkW-00087x-Am for qemu-devel@nongnu.org; Mon, 26 Nov 2018 14:40:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRMkS-0004fl-Rz for qemu-devel@nongnu.org; Mon, 26 Nov 2018 14:40:52 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:56081) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gRMkS-0004ch-JJ for qemu-devel@nongnu.org; Mon, 26 Nov 2018 14:40:48 -0500 Received: by mail-wm1-x32e.google.com with SMTP id y139so19403397wmc.5 for ; Mon, 26 Nov 2018 11:40:48 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id s139sm2412468wmd.3.2018.11.26.11.40.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Nov 2018 11:40:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=df7Bv7dtuHLicDy2wH6wy2eqdZWNF34GFUOfAVs9FY0=; b=qKMBzwXwiz2ycT52a1NGC7CtOy0zc9vvGgSmDwF+2U4k1VDTDn/Dv4/RBMa5OnN198 KfaYb+YUFn692zd/oH5bnawl1XXN2HAsgrF/RMc1YsuW/qsEx3Tccv69sWx2tYYuS5yH VsirtKrzlOS8NXz4buaKffcV/kmLNZM2RQQ4jGfen5UbWSAqtnOK/rAZ5HZI+ils4X28 ZkND0wj134z8idtvc/FURBB01aVSeUF81M/agSVc6v8q0p2x3TLcqsiWPHhytsTiSpKI xfyDjjZez0ZtnmmE90FK1m0TBXAtJSfUCdbMxUC3XSru112Pu8OmvfOdohNiuVHewoYQ 7wKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=df7Bv7dtuHLicDy2wH6wy2eqdZWNF34GFUOfAVs9FY0=; b=RefepmODB9XXFjZ8ZIGJ7saMmWFa8jyzyN7C3DLnUhoZAL4NIztT5PGx5CEnRM9vYz A5GPvMZLbrrMHjyvKNO9r0HR9mXmab86VNQkFEBcwpOyLPqirllLoz59jxiByhKMErEB RuA8n9MQ+djT7rrLehswz6tToQr3SORSe4gh6ZDScYKvzn4I+9gURcjx9Hjb2vC7uHPg Os3aHFogi9adrZzjr++0gloPnSlVxm+BUaph9CI2QvRN70nLFWfaln8aKdj6FhWg4gVK frsylZucIFDpciPb+jvqdUA0NbRDTEaIw+WDNFyoEj23UQi9VXqCHGgBZPbeFFjAEoZ6 Tl2w== X-Gm-Message-State: AGRZ1gIs9kwLlFcrT84qex2RQFZzMR5T1OYK1L+3STTN6HE3RPA6Y1Vm LomX0RFwTkjENoY2NFEzm/jjAe50 X-Google-Smtp-Source: AFSGD/VzM4jVqcJQP6e7CZmJlr99EPoFY1Du8SIWP8wT2onHoSSOwEecmEiYjEItzjTXtyJ/4JRb2w== X-Received: by 2002:a1c:5448:: with SMTP id p8mr25437365wmi.124.1543261246981; Mon, 26 Nov 2018 11:40:46 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 26 Nov 2018 20:40:27 +0100 Message-Id: <1543261235-2834-8-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1543261235-2834-1-git-send-email-pbonzini@redhat.com> References: <1543261235-2834-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32e Subject: [Qemu-devel] [PULL 07/15] vhost-user-bridge: fix recvmsg iovlen X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Marc-Andr=C3=A9 Lureau After iov_discard_front(), the iov may be smaller than its initial size. Fixes the heap-buffer-overflow spotted by ASAN: =3D=3D9036=3D=3DERROR: AddressSanitizer: heap-buffer-overflow on address 0x= 6060000001e0 at pc 0x7fe632eca3f0 bp 0x7ffddc4a05a0 sp 0x7ffddc49fd48 WRITE of size 32 at 0x6060000001e0 thread T0 #0 0x7fe632eca3ef (/lib64/libasan.so.5+0x773ef) #1 0x7fe632ecad23 in __interceptor_recvmsg (/lib64/libasan.so.5+0x77d23) #2 0x561e7491936b in vubr_backend_recv_cb /home/elmarco/src/qemu/tests/= vhost-user-bridge.c:333 #3 0x561e74917711 in dispatcher_wait /home/elmarco/src/qemu/tests/vhost= -user-bridge.c:160 #4 0x561e7491c3b5 in vubr_run /home/elmarco/src/qemu/tests/vhost-user-b= ridge.c:725 #5 0x561e7491c85c in main /home/elmarco/src/qemu/tests/vhost-user-bridg= e.c:806 #6 0x7fe631a6c412 in __libc_start_main (/lib64/libc.so.6+0x24412) #7 0x561e7491667d in _start (/home/elmarco/src/qemu/build/tests/vhost-u= ser-bridge+0x3967d) 0x6060000001e0 is located 0 bytes to the right of 64-byte region [0x6060000= 001a0,0x6060000001e0) allocated by thread T0 here: #0 0x7fe632f42848 in __interceptor_malloc (/lib64/libasan.so.5+0xef848) #1 0x561e7493acd8 in virtqueue_alloc_element /home/elmarco/src/qemu/con= trib/libvhost-user/libvhost-user.c:1848 #2 0x561e7493c2a8 in vu_queue_pop /home/elmarco/src/qemu/contrib/libvho= st-user/libvhost-user.c:1954 #3 0x561e749189bf in vubr_backend_recv_cb /home/elmarco/src/qemu/tests/= vhost-user-bridge.c:297 #4 0x561e74917711 in dispatcher_wait /home/elmarco/src/qemu/tests/vhost= -user-bridge.c:160 #5 0x561e7491c3b5 in vubr_run /home/elmarco/src/qemu/tests/vhost-user-b= ridge.c:725 #6 0x561e7491c85c in main /home/elmarco/src/qemu/tests/vhost-user-bridg= e.c:806 #7 0x7fe631a6c412 in __libc_start_main (/lib64/libc.so.6+0x24412) SUMMARY: AddressSanitizer: heap-buffer-overflow (/lib64/libasan.so.5+0x773e= f) Shadow bytes around the buggy address: 0x0c0c7fff7fe0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0c0c7fff7ff0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0c0c7fff8000: fa fa fa fa 00 00 00 00 00 00 05 fa fa fa fa fa 0x0c0c7fff8010: 00 00 00 00 00 00 00 00 fa fa fa fa fd fd fd fd 0x0c0c7fff8020: fd fd fd fd fa fa fa fa fd fd fd fd fd fd fd fd =3D>0x0c0c7fff8030: fa fa fa fa 00 00 00 00 00 00 00 00[fa]fa fa fa 0x0c0c7fff8040: fd fd fd fd fd fd fd fd fa fa fa fa fd fd fd fd 0x0c0c7fff8050: fd fd fd fd fa fa fa fa fd fd fd fd fd fd fd fd 0x0c0c7fff8060: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0c7fff8070: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0c7fff8080: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa Signed-off-by: Marc-Andr=C3=A9 Lureau Message-Id: <20181109173028.3372-1-marcandre.lureau@redhat.com> --- tests/vhost-user-bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c index 0884294..0cf8d0b 100644 --- a/tests/vhost-user-bridge.c +++ b/tests/vhost-user-bridge.c @@ -323,7 +323,7 @@ vubr_backend_recv_cb(int sock, void *ctx) .msg_name =3D (struct sockaddr *) &vubr->backend_udp_dest, .msg_namelen =3D sizeof(struct sockaddr_in), .msg_iov =3D sg, - .msg_iovlen =3D elem->in_num, + .msg_iovlen =3D num, .msg_flags =3D MSG_DONTWAIT, }; do { --=20 1.8.3.1