From nobody Mon Feb 9 14:36:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543261742159866.343394770667; Mon, 26 Nov 2018 11:49:02 -0800 (PST) Received: from localhost ([::1]:38471 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRMsO-0007K5-DC for importer@patchew.org; Mon, 26 Nov 2018 14:49:00 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRMkS-00084e-Db for qemu-devel@nongnu.org; Mon, 26 Nov 2018 14:40:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRMkR-0004ca-Bh for qemu-devel@nongnu.org; Mon, 26 Nov 2018 14:40:48 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:41072) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gRMkR-0004Z9-5H for qemu-devel@nongnu.org; Mon, 26 Nov 2018 14:40:47 -0500 Received: by mail-wr1-x42f.google.com with SMTP id x10so20232379wrs.8 for ; Mon, 26 Nov 2018 11:40:47 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id s139sm2412468wmd.3.2018.11.26.11.40.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Nov 2018 11:40:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Gkr28uI2RgDgNRbPBvblLh3yOdevJFmQk9xcSkxBEo8=; b=ADnFiv3a3D7gT5fAbJXOdOPWanMG7jBxLzvkyXHCiYIQEfqSBxf+Bfa70DpNh/sRM4 wdeyY2Qtbmqu4Zw2mLjtme7WoktFWAbTmTT8akqArGC+sJ3ve+7X3aXhfbyFC31Rq5V/ 6FYr18Pi49687Ls2pddik8rHe61TPrxlgZg5qFyENrkCgX0UvL+gghsKnXtMhatK0W0C 6W5LnCdF7nJevb4gKahvp1pcD/InpfKszeNF+AvdW+mIakjFKJi88ZpifLyhkZJ6GgSG i2X2YV639iPreYeN7mXnZ4cLgNXeHL496BHJenI1c7shMCmj4a2vz4EKqBkDTAhVxyyQ z0gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Gkr28uI2RgDgNRbPBvblLh3yOdevJFmQk9xcSkxBEo8=; b=sHFkVKIlRo4zIBu7dSw4Mdqc6QS+xzN9+Uh3wkzQeToFAGwMKnxia0xpwlGXIXw6Vw 0JV+RSOKkzUVEmFUWjQOQA42dPd0+O812B7fY+lhUf36Cfuw35DCkulPRmbccPv1XIXN GmWmBQFYEmTWYvZY4ibNDzuhJQwqKkrx/rKOWhTytVLrDe4aRJkD72r6bJNtvwKvNEGv qRl1x89oVY1wkN1Plh6ft6bmFDh7tNDZW3lW3FG9bf1h2WOHHYUHt/l61K47Nw/6N1Sm rZzT1e6CwK7GV8DXrswIdu8sJMhvrApwfU7yuX3HVbeX8VfWXFSwku4G4GHW8J+p8mak 4GlQ== X-Gm-Message-State: AA+aEWZ8nk6ExzfmmdUahWcHDuOHir/P6ag0o5s1Nc8CpBJ49oRCKEIL 8scB/7c39t2Oi9DZH6oUySIqBq5r X-Google-Smtp-Source: AFSGD/X+NLmQFrmzcnnYM1KzhGdX4idYZj+WoGec/xIyKjdQvhYYNb7B/ri/9BbICpJF/bv4uJCzQg== X-Received: by 2002:a5d:5089:: with SMTP id a9mr25478890wrt.327.1543261245307; Mon, 26 Nov 2018 11:40:45 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 26 Nov 2018 20:40:26 +0100 Message-Id: <1543261235-2834-7-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1543261235-2834-1-git-send-email-pbonzini@redhat.com> References: <1543261235-2834-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42f Subject: [Qemu-devel] [PULL 06/15] vl: Improve error message when we can't load fw_cfg from file X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Li Qiang parse_fw_cfg() reports "can't load" without further details. Get the details from g_file_get_contents(), and include them in the error message. Signed-off-by: Li Qiang Message-Id: <1541051971-28584-1-git-send-email-liq3ea@gmail.com> Signed-off-by: Paolo Bonzini --- vl.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index fa25d1a..32ab6e6 100644 --- a/vl.c +++ b/vl.c @@ -2244,8 +2244,10 @@ static int parse_fw_cfg(void *opaque, QemuOpts *opts= , Error **errp) size =3D strlen(str); /* NUL terminator NOT included in fw_cfg blo= b */ buf =3D g_memdup(str, size); } else { - if (!g_file_get_contents(file, &buf, &size, NULL)) { - error_setg(errp, "can't load %s", file); + GError *err =3D NULL; + if (!g_file_get_contents(file, &buf, &size, &err)) { + error_setg(errp, "can't load %s: %s", file, err->message); + g_error_free(err); return -1; } } --=20 1.8.3.1