And also the g_malloc doesn't need check return value,
remove it.
Cc: qemu-trivial@nongnu.org
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Li Qiang <liq3ea@gmail.com>
---
target/i386/hax-all.c | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
index d2e512856b..502ce6f0af 100644
--- a/target/i386/hax-all.c
+++ b/target/i386/hax-all.c
@@ -154,13 +154,7 @@ int hax_vcpu_create(int id)
return 0;
}
- vcpu = g_malloc(sizeof(struct hax_vcpu_state));
- if (!vcpu) {
- fprintf(stderr, "Failed to alloc vcpu state\n");
- return -ENOMEM;
- }
-
- memset(vcpu, 0, sizeof(struct hax_vcpu_state));
+ vcpu = g_new0(struct hax_vcpu_state, 1);
ret = hax_host_create_vcpu(hax_global.vm->fd, id);
if (ret) {
@@ -250,11 +244,8 @@ struct hax_vm *hax_vm_create(struct hax_state *hax)
return hax->vm;
}
- vm = g_malloc(sizeof(struct hax_vm));
- if (!vm) {
- return NULL;
- }
- memset(vm, 0, sizeof(struct hax_vm));
+ vm = g_new0(struct hax_vm, 1);
+
ret = hax_host_create_vm(hax, &vm_id);
if (ret) {
fprintf(stderr, "Failed to create vm %x\n", ret);
--
2.11.0
On 26/11/2018 10:56, Li Qiang wrote: > And also the g_malloc doesn't need check return value, > remove it. > > Cc: qemu-trivial@nongnu.org > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Reviewed-by: Markus Armbruster <armbru@redhat.com> > Signed-off-by: Li Qiang <liq3ea@gmail.com> > --- > target/i386/hax-all.c | 15 +++------------ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c > index d2e512856b..502ce6f0af 100644 > --- a/target/i386/hax-all.c > +++ b/target/i386/hax-all.c > @@ -154,13 +154,7 @@ int hax_vcpu_create(int id) > return 0; > } > > - vcpu = g_malloc(sizeof(struct hax_vcpu_state)); > - if (!vcpu) { > - fprintf(stderr, "Failed to alloc vcpu state\n"); > - return -ENOMEM; > - } > - > - memset(vcpu, 0, sizeof(struct hax_vcpu_state)); > + vcpu = g_new0(struct hax_vcpu_state, 1); > > ret = hax_host_create_vcpu(hax_global.vm->fd, id); > if (ret) { > @@ -250,11 +244,8 @@ struct hax_vm *hax_vm_create(struct hax_state *hax) > return hax->vm; > } > > - vm = g_malloc(sizeof(struct hax_vm)); > - if (!vm) { > - return NULL; > - } > - memset(vm, 0, sizeof(struct hax_vm)); > + vm = g_new0(struct hax_vm, 1); > + > ret = hax_host_create_vm(hax, &vm_id); > if (ret) { > fprintf(stderr, "Failed to create vm %x\n", ret); > Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Li Qiang <liq3ea@gmail.com> writes: > And also the g_malloc doesn't need check return value, > remove it. > > Cc: qemu-trivial@nongnu.org > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Reviewed-by: Markus Armbruster <armbru@redhat.com> > Signed-off-by: Li Qiang <liq3ea@gmail.com> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > --- > target/i386/hax-all.c | 15 +++------------ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c > index d2e512856b..502ce6f0af 100644 > --- a/target/i386/hax-all.c > +++ b/target/i386/hax-all.c > @@ -154,13 +154,7 @@ int hax_vcpu_create(int id) > return 0; > } > > - vcpu = g_malloc(sizeof(struct hax_vcpu_state)); > - if (!vcpu) { > - fprintf(stderr, "Failed to alloc vcpu state\n"); > - return -ENOMEM; > - } > - > - memset(vcpu, 0, sizeof(struct hax_vcpu_state)); > + vcpu = g_new0(struct hax_vcpu_state, 1); > > ret = hax_host_create_vcpu(hax_global.vm->fd, id); > if (ret) { > @@ -250,11 +244,8 @@ struct hax_vm *hax_vm_create(struct hax_state *hax) > return hax->vm; > } > > - vm = g_malloc(sizeof(struct hax_vm)); > - if (!vm) { > - return NULL; > - } > - memset(vm, 0, sizeof(struct hax_vm)); > + vm = g_new0(struct hax_vm, 1); > + > ret = hax_host_create_vm(hax, &vm_id); > if (ret) { > fprintf(stderr, "Failed to create vm %x\n", ret); -- Alex Bennée
On 26/11/2018 10:56, Li Qiang wrote: > And also the g_malloc doesn't need check return value, > remove it. > > Cc: qemu-trivial@nongnu.org > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Reviewed-by: Markus Armbruster <armbru@redhat.com> > Signed-off-by: Li Qiang <liq3ea@gmail.com> > --- > target/i386/hax-all.c | 15 +++------------ > 1 file changed, 3 insertions(+), 12 deletions(-) > Applied to my trivial-patches branch. Thanks, Laurent
© 2016 - 2024 Red Hat, Inc.