From nobody Mon Feb 9 17:37:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1541541234580992.6563978333154; Tue, 6 Nov 2018 13:53:54 -0800 (PST) Received: from localhost ([::1]:43934 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK9I9-0003xB-4P for importer@patchew.org; Tue, 06 Nov 2018 16:53:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK9DG-0006Xt-8I for qemu-devel@nongnu.org; Tue, 06 Nov 2018 16:48:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gK93S-0001BX-Te for qemu-devel@nongnu.org; Tue, 06 Nov 2018 16:38:36 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:46349) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gK93S-00008s-8S for qemu-devel@nongnu.org; Tue, 06 Nov 2018 16:38:34 -0500 Received: by mail-wr1-x436.google.com with SMTP id 74-v6so15189692wrb.13 for ; Tue, 06 Nov 2018 13:38:13 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id l186-v6sm3223526wma.13.2018.11.06.13.38.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 13:38:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Uw0478a/NZuYiRTAYy5+GpCx7zq4hCEZS8oy5z4+WYw=; b=G3BcM1SYUReCh9RpgMTKSJN3OawSxwZve/9abj8fXbYf88n4nJwEuWkwWftmyKRs+2 17y5rAgXuJgMN0sgKL2ZQzUC/OMYikQZkr4AZ/oGujTnCRwREPUVEEdQxy+RRrt1lyal nUTlo9++r6CKKZmJz6dSvbshCndl6cVcAIaTIK3tPI41IW2Oqa/S+F8A5FDVY6lBU1Al VqKn0MY3yOGQyUN8CHB032/RjMHXJc1nGhdOuDG2yOcq13e+QWt8xugN9e7WxfYEmLvR RcxS/oe5RU5UH/X/8NcABF9SxhntZKwOPpE0EFKb9RORzQMXmV1rphRuuCL7Z8JI4IOq HpWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Uw0478a/NZuYiRTAYy5+GpCx7zq4hCEZS8oy5z4+WYw=; b=tMp8kRi7pDbsw0jnEY2t3GvkxT6ZIC8UMKr1lNRykcJ9KZnokeMQbFZfC7rIFlQ/sb fZYvsf8D9tNPVy1m68A7ECGWaLgIGYYikjHyTLMem51L+MFNeYQSscUEz3RAFwnPzpk5 G4KNPKpIVdwcFLKMeTKlFRjh4Wz1MVwZMW/Y8lfLKcz350La3SlQ9nfF9HOovJ2QesKb CQdTyjfcA5ePtszxhKdET0Ru3ayxAxLHb2Kz+zCjNUNQKeMphugTyKaqGhrFYHaABciz yKd1TpqVg+g5RzjsRKglTNbwcAzHO/ZuI9MSpAtVF4W/9yVqMAbP8o8qblOp2q++tSg9 y4gw== X-Gm-Message-State: AGRZ1gL2WZ4bNGPgNlEevjaYjztKrW9H0MAUSQqeaHMqiU3sh4m/3c7u +JxLVtagdXC8Jo8v8THr1GWBkYUY X-Google-Smtp-Source: AJdET5d5chU5Q8AqJ03R90Ju8JHiyVI8np9SUMFJnPj0MSxkQAd6/SRDRgN+aghG66iB0RgoNHH+Ow== X-Received: by 2002:adf:b593:: with SMTP id c19-v6mr26331133wre.223.1541540292158; Tue, 06 Nov 2018 13:38:12 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 6 Nov 2018 22:37:52 +0100 Message-Id: <1541540283-45699-7-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1541540283-45699-1-git-send-email-pbonzini@redhat.com> References: <1541540283-45699-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::436 Subject: [Qemu-devel] [PULL 06/17] target/i386: Clear RF on SYSCALL instruction X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rudolf Marek , Roman Kapl Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Rudolf Marek Fix the SYSCALL instruction in 64-bit (long mode). The RF flag should be cleared in R11 as well as in the RFLAGS. Intel and AMD CPUs behave same. AMD has this documented in the APM vol 3. Signed-off-by: Roman Kapl Signed-off-by: Rudolf Marek Message-Id: <20181019122449.26387-1-rka@sysgo.com> Signed-off-by: Paolo Bonzini --- target/i386/seg_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/seg_helper.c b/target/i386/seg_helper.c index 33714bc..63e265c 100644 --- a/target/i386/seg_helper.c +++ b/target/i386/seg_helper.c @@ -991,11 +991,11 @@ void helper_syscall(CPUX86State *env, int next_eip_ad= dend) int code64; =20 env->regs[R_ECX] =3D env->eip + next_eip_addend; - env->regs[11] =3D cpu_compute_eflags(env); + env->regs[11] =3D cpu_compute_eflags(env) & ~RF_MASK; =20 code64 =3D env->hflags & HF_CS64_MASK; =20 - env->eflags &=3D ~env->fmask; + env->eflags &=3D ~(env->fmask | RF_MASK); cpu_load_eflags(env, env->eflags, 0); cpu_x86_load_seg_cache(env, R_CS, selector & 0xfffc, 0, 0xffffffff, --=20 1.8.3.1