From nobody Mon Feb 9 11:51:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1541541234969244.55342719710188; Tue, 6 Nov 2018 13:53:54 -0800 (PST) Received: from localhost ([::1]:43932 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK9I3-0003SR-BH for importer@patchew.org; Tue, 06 Nov 2018 16:53:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK9Cq-0002lF-3M for qemu-devel@nongnu.org; Tue, 06 Nov 2018 16:48:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gK93X-0001Uu-UC for qemu-devel@nongnu.org; Tue, 06 Nov 2018 16:38:43 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:53596) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gK93W-0000WI-Hx for qemu-devel@nongnu.org; Tue, 06 Nov 2018 16:38:39 -0500 Received: by mail-wm1-x32e.google.com with SMTP id f10-v6so85694wme.3 for ; Tue, 06 Nov 2018 13:38:22 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id l186-v6sm3223526wma.13.2018.11.06.13.38.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 13:38:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=zCPr4JzfsgrE6KwOgTmKxZIbDvG8Wrm2x67VsyGQQY4=; b=mQAdMvaFR34v2ySiCwYHl4+RF3hcd5h18Jm9Q49H5l5gkro4RC1Xdj26EEVKUhfYxW nyGPP74Ni9MsLcdadY1zTz47w6JGNX5ZL4wiavjkI05PjP/iwFi0oyDLSlxgw7gJFutX 43RrzOyYy2UwywC4lJCFXWgKrBXpszmrjUW3Ywpo9xpwM6/31IteCjUPtw4jbl5NNPt+ psZYWvto8uRdZ2iK4Ut32QofelBs/DO1xSJx+pc+kG3j2N7//IZAk444neqhiRIZootI 2UTph0fqh6+0hvWuzPo/AZpZ/wJdyeHR6k5rzfCmCJdco47EfG1IIdoD5oiR9zLSE5X5 YRvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=zCPr4JzfsgrE6KwOgTmKxZIbDvG8Wrm2x67VsyGQQY4=; b=d1AyBnYL/QEdlrCOR2Rs58L5BrYgINu8pgZqsyh6MnNlxCak21TvDbG6UEgqhKNwPP TJx9n27a+i4XLjY0Zc3nDb+khZX/lIX/pbcUxfmvRxROFdWxeJYSYC2qT7qL+SMeS3lD 7pEIp1gKhK42bMldT44ghgn2y+Kjy14wT7KmIYuDr5cprr/Dr9oL1wY3Ocpzp75l1PCv w5Lr7k4+hkSnBiGLRY3TKTeKuQclybFkhXdsk9v8TwAPFTuyvsXJYx1lxmiNKt7WuuBG wn2L5m0xaIG+a5y1fZOIwppeTrGAkOdqTdLqMx9Iq0sVfUh3ravIyEK+8mNWwSJofSck VK3A== X-Gm-Message-State: AGRZ1gI4jLPZBs6L/nOG+kUBnR1YaVb0NL4bd6QsqLB1ENrrdGcSEZx0 LrfebaEWInhaPMcW2kr8W37pvM4R X-Google-Smtp-Source: AJdET5eV6ePy1LLsw6JZkE/VyXHCoZTfJCT75/WJ3cBLPdQydX04fMnbB0ou0TLRiTo6yfIkVN5q9A== X-Received: by 2002:a1c:4d2:: with SMTP id 201-v6mr3238417wme.133.1541540301372; Tue, 06 Nov 2018 13:38:21 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 6 Nov 2018 22:37:59 +0100 Message-Id: <1541540283-45699-14-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1541540283-45699-1-git-send-email-pbonzini@redhat.com> References: <1541540283-45699-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32e Subject: [Qemu-devel] [PULL 13/17] scsi-generic: avoid out-of-bounds access to VPD page list X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" A device can report an excessive number of VPD pages when asked for a list; this can cause an out-of-bounds access to buf in scsi_generic_set_vpd_bl_emulation. It should not happen, but it is technically not incorrect so handle it: do not check any byte past the allocation length that was sent to the INQUIRY command. Reported-by: Max Reitz Reviewed-by: Max Reitz Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c index aebb7cd..c5497bb 100644 --- a/hw/scsi/scsi-generic.c +++ b/hw/scsi/scsi-generic.c @@ -538,7 +538,7 @@ static void scsi_generic_set_vpd_bl_emulation(SCSIDevic= e *s) } =20 page_len =3D buf[3]; - for (i =3D 4; i < page_len + 4; i++) { + for (i =3D 4; i < MIN(sizeof(buf), page_len + 4); i++) { if (buf[i] =3D=3D 0xb0) { s->needs_vpd_bl_emulation =3D false; return; --=20 1.8.3.1