From nobody Thu Nov 6 08:21:45 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1540577147222747.2975837788206; Fri, 26 Oct 2018 11:05:47 -0700 (PDT) Received: from localhost ([::1]:33666 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gG6UP-00011k-W7 for importer@patchew.org; Fri, 26 Oct 2018 14:05:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gG6TU-0000eo-Gn for qemu-devel@nongnu.org; Fri, 26 Oct 2018 14:04:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gG6TR-0007TK-AM for qemu-devel@nongnu.org; Fri, 26 Oct 2018 14:04:44 -0400 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]:35634) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gG6TR-0007QI-2E for qemu-devel@nongnu.org; Fri, 26 Oct 2018 14:04:41 -0400 Received: by mail-qt1-x841.google.com with SMTP id a10-v6so2250780qtp.2 for ; Fri, 26 Oct 2018 11:04:35 -0700 (PDT) Received: from ip-172-31-33-50.ec2.internal (ec2-34-206-44-154.compute-1.amazonaws.com. [34.206.44.154]) by smtp.gmail.com with ESMTPSA id w17-v6sm9398901qth.47.2018.10.26.11.04.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 26 Oct 2018 11:04:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=berkeley-edu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=SQMURp3JrhNzaTS5cMZ3S5pgIBHPfVr6ijIkazEaIZM=; b=OBgNvNM0EnTDl0XRxlG9ng3Z2WqprcmZYcYBhKomY+oMMIiTw7q1qHP9aItxtAMVr1 HoYp7If7d6zVI8bg1Ff9ldXd3UjDbyydjFVN+2OuseisiU3BTU5tQJB34vyCItGvTOsk bE9ooOKnVmWeLpyVdvxH9YdRr5gGL1CmaUagwJtAg9pEn24BF/KvVLqwZlSVXM5Q2tnM JaoiOFcd0O6HheyfQc4bLfcpO+ctaz+gCPYMBcpTNeLhwwoqu6Ti/iR3K9xqzcHXdyaF wEdzIAxDrdqcTHwEfgeAw1IB8qRQM7Aotf8PLF/xwDDQJ3JUIlJeyP1SNmMrsHBlDjJv 1I7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=SQMURp3JrhNzaTS5cMZ3S5pgIBHPfVr6ijIkazEaIZM=; b=G6mwzgXUK+eXiAqR32+ilD5qqpes3NMhl8V02mqzmGVG/307Mh0M2UDFXYFyN5B0QG /dptXqVXjzN2q/QiAOXdyMtwoBf7WeIRvpTa4bWKFyfc9QDt0sBfiaUdQk3yv6qZSWjA Pzji0wKYRES5ve1YotLyN4cKSPA3BnIVXRYtdGCvlO2p1oG4PqbTlOx/PrZ5aX8/SeEL AphHWTLB064Hf23D2+4EpRgTAWIx3WgjH1hqZwc0FqGJZ2OSIccNRx/KVmKVtJDTQ1Sz 45kfotqqNZIizGtt1DBrdK1da4p+iy+K640mH+PpaSFxmkbzjWljYVcVU8T/UU52EEq1 FxLA== X-Gm-Message-State: AGRZ1gJZX/g6PJdoza/vh717+zbNX5/igjF+79iwL/myzFTJrQ2r+TKx chXDxvRAzjw6POG7WIa25aJaPt5ESQI= X-Google-Smtp-Source: AJdET5eN0FFIFk/YGgM1yEodjD4jps+alohSvjV44+Wf2DhNJPwKjAw3Da+Anbd2hto2J231MGCkVg== X-Received: by 2002:aed:2e65:: with SMTP id j92-v6mr4262072qtd.339.1540577074549; Fri, 26 Oct 2018 11:04:34 -0700 (PDT) From: Dayeol Lee To: qemu-devel@nongnu.org Date: Fri, 26 Oct 2018 18:04:27 +0000 Message-Id: <1540577067-8235-1-git-send-email-dayeol@berkeley.edu> X-Mailer: git-send-email 2.7.4 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::841 Subject: [Qemu-devel] [PATCH] target/riscv/pmp.c: pmpcfg_csr_read returns bogus value on RV64 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dayeol Lee , Bastian Koppelmann , Michael Clark , Palmer Dabbelt , Sagar Karandikar Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" pmp_read_cfg() returns 8-bit value, which is combined together to form a si= ngle pmpcfg CSR.=20 The default promotion rules will result in an integer here ("i*8" is intege= r, which flows through) resulting in a 32-bit signed value on most hosts. That's bogus on RV64I, with the high bits of the CSR being wrong. Signed-off-by: Dayeol Lee Reviewed-by: Palmer Dabbelt Reviewed-by: Alistair Francis --- target/riscv/pmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/pmp.c b/target/riscv/pmp.c index c828950..3d3906a 100644 --- a/target/riscv/pmp.c +++ b/target/riscv/pmp.c @@ -330,7 +330,7 @@ target_ulong pmpcfg_csr_read(CPURISCVState *env, uint32= _t reg_index) { int i; target_ulong cfg_val =3D 0; - uint8_t val =3D 0; + target_ulong val =3D 0; =20 if(sizeof(target_ulong) =3D=3D 8) reg_index /=3D 2; --=20 2.7.4