[Qemu-devel] [PATCH] tests/migration-test: Disable s390x test when running with TCG

Thomas Huth posted 1 patch 5 years, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1539946806-695-1-git-send-email-thuth@redhat.com
Test docker-clang@ubuntu passed
Test checkpatch passed
Test asan passed
Test docker-mingw@fedora failed
Test docker-quick@centos7 passed
tests/migration-test.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
[Qemu-devel] [PATCH] tests/migration-test: Disable s390x test when running with TCG
Posted by Thomas Huth 5 years, 5 months ago
The migration test for s390x sometimes hangs when running with TCG,
similar to the problems that we have already observed with TCG for
the ppc64 guests. Thus disable the s390x test when we are not running
with KVM for now until the problem with TCG has been resolved.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/migration-test.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/tests/migration-test.c b/tests/migration-test.c
index b792025..06ca506 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -803,6 +803,22 @@ int main(int argc, char **argv)
         return 0;
     }
 
+    /*
+     * Similar to ppc64, s390x seems to be touchy with TCG, so disable it
+     * there until the problems are resolved
+     */
+    if (g_str_equal(qtest_get_arch(), "s390x")) {
+#if defined(HOST_S390X)
+        if (access("/dev/kvm", R_OK | W_OK)) {
+            g_test_message("Skipping test: kvm not available");
+            return 0;
+        }
+#else
+        g_test_message("Skipping test: Need s390x host to work properly");
+        return 0;
+#endif
+    }
+
     tmpfs = mkdtemp(template);
     if (!tmpfs) {
         g_test_message("mkdtemp on path (%s): %s\n", template, strerror(errno));
-- 
1.8.3.1


Re: [Qemu-devel] [PATCH] tests/migration-test: Disable s390x test when running with TCG
Posted by Laurent Vivier 5 years, 5 months ago
On 19/10/2018 13:00, Thomas Huth wrote:
> The migration test for s390x sometimes hangs when running with TCG,
> similar to the problems that we have already observed with TCG for
> the ppc64 guests. Thus disable the s390x test when we are not running
> with KVM for now until the problem with TCG has been resolved.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/migration-test.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/tests/migration-test.c b/tests/migration-test.c
> index b792025..06ca506 100644
> --- a/tests/migration-test.c
> +++ b/tests/migration-test.c
> @@ -803,6 +803,22 @@ int main(int argc, char **argv)
>          return 0;
>      }
>  
> +    /*
> +     * Similar to ppc64, s390x seems to be touchy with TCG, so disable it
> +     * there until the problems are resolved
> +     */
> +    if (g_str_equal(qtest_get_arch(), "s390x")) {
> +#if defined(HOST_S390X)
> +        if (access("/dev/kvm", R_OK | W_OK)) {
> +            g_test_message("Skipping test: kvm not available");
> +            return 0;
> +        }
> +#else
> +        g_test_message("Skipping test: Need s390x host to work properly");
> +        return 0;
> +#endif
> +    }
> +
>      tmpfs = mkdtemp(template);
>      if (!tmpfs) {
>          g_test_message("mkdtemp on path (%s): %s\n", template, strerror(errno));
> 

Reviewed-by: Laurent Vivier <lvivier@redhat.com>


Re: [Qemu-devel] [PATCH] tests/migration-test: Disable s390x test when running with TCG
Posted by Emilio G. Cota 5 years, 5 months ago
On Fri, Oct 19, 2018 at 13:14:57 +0200, Laurent Vivier wrote:
> On 19/10/2018 13:00, Thomas Huth wrote:
> > The migration test for s390x sometimes hangs when running with TCG,
> > similar to the problems that we have already observed with TCG for
> > the ppc64 guests. Thus disable the s390x test when we are not running
> > with KVM for now until the problem with TCG has been resolved.
> > 
> > Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Emilio G. Cota <cota@braap.org>

Thanks!

		E.