From nobody Thu Nov 6 06:13:32 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1539845149745984.8278904899001; Wed, 17 Oct 2018 23:45:49 -0700 (PDT) Received: from localhost ([::1]:40480 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gD23p-0005rP-Ow for importer@patchew.org; Thu, 18 Oct 2018 02:45:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gD22u-0005Yc-92 for qemu-devel@nongnu.org; Thu, 18 Oct 2018 02:44:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gD22q-0003eM-Sj for qemu-devel@nongnu.org; Thu, 18 Oct 2018 02:44:36 -0400 Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742]:46676) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gD22q-0003Yf-Jg for qemu-devel@nongnu.org; Thu, 18 Oct 2018 02:44:32 -0400 Received: by mail-qk1-x742.google.com with SMTP id q12-v6so18093914qkl.13 for ; Wed, 17 Oct 2018 23:44:31 -0700 (PDT) Received: from ip-172-31-33-50.ec2.internal (ec2-34-206-44-154.compute-1.amazonaws.com. [34.206.44.154]) by smtp.gmail.com with ESMTPSA id l3-v6sm22330062qtl.2.2018.10.17.23.44.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 17 Oct 2018 23:44:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=berkeley-edu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=Snyl/aDYPsUBitW9Z5zMCcuxPHjeF7cfLoMnsiuB4CY=; b=wZY1u+7Y3MJ204hoDwfuw7Yaue9+VJlTXqMkYkm8nFo4s+TE502L9HAXN2Ic9qtDWP bvRiCn5MPKxMir+jW7qMBW0PphWwUtDW5Xzjkomf9Fz7PDOpjX8R7tDNptscTfJIyrgJ 27yji8WKqfEQoN0qi5xpCPCXXwA8XfUe4DciB90ovbu7dBuCyg8iDLFqsgfw7jbxzUVv nVoLrr42e9XIAk1CZ5tw1CU6fi1qTorVSWGiTYRXtHnycNt6eNVyuRXhIwbHuu+mfPUx pewQMNlEBbtjvYV+X1ubXRaKlmgNuiW13aeIJe3HHT0fwb2cC9dVVfyCq13hUbgAuqAr 58fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Snyl/aDYPsUBitW9Z5zMCcuxPHjeF7cfLoMnsiuB4CY=; b=gno0tuEw37b09SPF9ywWT2tJ8kqSfgOn6crxhN8ZEWeSERmsuSHWYJwN9lsR2zic61 cr54myilIWFL7JkKzSNXRMra0e5Rq97o4PJCmhihIDstE9d930k5rR9dvX20h1MiFQYn aicWu5vwLVI894mxuTLDhioLzO/9biJYr/R0zCY9O06ouK59Wc1snqrj1GSqLrA7L6uC 6+OHgBzP7msBqdx976VFDcj7oGqGMc7JnlKTMkFG+Nw343f8A2sWXmn3RLUyI/P7KfM2 u5SpOqWFoJTqzxZ7eTN3SzKKUTpVfgnhKkpRoWQVSTj3em6eBc1pseq6X9XCnb+TfJzy K8HQ== X-Gm-Message-State: ABuFfojS4EUup7tAx9zggz4rdQ96Da9dqKSZhDm06riMl3VC08WucNyO uzNaHmN+xy0CTsYsnBbYKCffBFaYEgI= X-Google-Smtp-Source: ACcGV600L85dUsTGTZvy6Z+gLmjcWnpGIgMwTslUlzrBHlOTYCdZtqXoBBT1FuVtEdVgq73jlY06hQ== X-Received: by 2002:a37:634e:: with SMTP id x75-v6mr8895343qkb.122.1539845070829; Wed, 17 Oct 2018 23:44:30 -0700 (PDT) From: Dayeol Lee To: qemu-devel@nongnu.org Date: Thu, 18 Oct 2018 06:44:26 +0000 Message-Id: <1539845066-31635-1-git-send-email-dayeol@berkeley.edu> X-Mailer: git-send-email 2.7.4 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::742 Subject: [Qemu-devel] [PATCH] [PATCH] target/riscv/pmp.c: pmpcfg_csr_read return type demotion X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dayeol Lee , Bastian Koppelmann , Michael Clark , Palmer Dabbelt , Sagar Karandikar Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" There is a data type demotion bug in target/riscv/pmp.c When the target_ulong is 8 bytes, pmpcfg_csr_read returns only lower 4 bytes. Reviewed-by: Palmer Dabbelt --- target/riscv/pmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/pmp.c b/target/riscv/pmp.c index c828950..4b6c20e 100644 --- a/target/riscv/pmp.c +++ b/target/riscv/pmp.c @@ -337,7 +337,7 @@ target_ulong pmpcfg_csr_read(CPURISCVState *env, uint32= _t reg_index) =20 for (i =3D 0; i < sizeof(target_ulong); i++) { val =3D pmp_read_cfg(env, (reg_index * sizeof(target_ulong)) + i); - cfg_val |=3D (val << (i * 8)); + cfg_val |=3D ((target_ulong)val << ((target_ulong)i * 8)); } =20 PMP_DEBUG("hart " TARGET_FMT_ld ": reg%d, val: 0x" TARGET_FMT_lx, --=20 2.7.4