From nobody Thu Nov 6 01:09:06 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538296928246633.2916795149508; Sun, 30 Sep 2018 01:42:08 -0700 (PDT) Received: from localhost ([::1]:54367 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6XIk-0003k7-Tz for importer@patchew.org; Sun, 30 Sep 2018 04:42:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6WsI-0003BU-Bv for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:14:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6WsD-0001Ig-9c for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:14:43 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:42392) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g6WsC-00019n-OC for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:14:40 -0400 Received: by mail-wr1-x430.google.com with SMTP id b11-v6so10456373wru.9 for ; Sun, 30 Sep 2018 01:14:29 -0700 (PDT) Received: from 640k.lan (94-36-187-248.adsl-ull.clienti.tiscali.it. [94.36.187.248]) by smtp.gmail.com with ESMTPSA id u76-v6sm11369194wmd.10.2018.09.30.01.14.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 30 Sep 2018 01:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WHFQgFduHcRKu6qsQ2E1Bj0S/+bl8td6lirtweElo9o=; b=EsXieogDrc8o7vaPcr4ANupxGqOOylwM8Smaf2uvplYavcqiYA3VAQO1pz2l3u+Btl wNwOWq8R+G/Df83Di7UyO+xaa92anoafzqSuNdq8A9GOB8F1EesXiZlVvhf4QaDVrHw+ /cqS1mb8h3z/RhmO0TyRUrvJXRN4NDrii9Lpc/WlG81LQDYyLa1P6VYsRu4PDhu5f7Zm i/nU+fOdgUl8om0d9CoXaXZ7J3fSRdhie3Aia+wyrr/JQ4Oq/8Ls1yi7ofoSeLcqz1ek 6X5EUKOn0MVFyIqB9evU8NxKToMoRpPx2Xdxwk2cDUg/oK/4KkS36Tl6sXEN1xasf3ru L/3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=WHFQgFduHcRKu6qsQ2E1Bj0S/+bl8td6lirtweElo9o=; b=gF5xWwXR5yJifsm6pMh0/fK9ovLwCRuzfAUKV83SlGcAMFBAK4GI25U/57KZW+Q/ed XCu0DR00vHHhU/qpum9CJC5vMxfDVVwquRIFmiE9jQCmyAco/73dncNIrdnmbo9+PVI0 ByBOWEAmndGfyUKeEyb5vD3iWJRd6xkC0EKhctPb9FFdZ+u3WtCjNpmzhe3w8gBorgZA +e3j+SeernMXOd7i+cD1xfQS3T58rBM5ub8wFbk/Xdu9uIMwQ3BOn1rOxzrTL8efIql9 dRdOROOlZHHcGi4qGqf7Y+9iFsQxGVWMoBpEhYBpZgjUOStL0miYUIsKIYM1mNLAIpWj wdcA== X-Gm-Message-State: ABuFfogCkxm86DS1ky1ZQxR0KVYkupIQVV6UvEXalltY/OQXc4LDSL/E 7WqpsROdI8rsSaNjNLsabcO+ltBz X-Google-Smtp-Source: ACcGV61IsVDbQBaWNTszYSq1097OfamAiTf2D1vz6z3szP+eqEPgoQPwZKBMkPeVqCmZCSn+7fp+DQ== X-Received: by 2002:a5d:4a12:: with SMTP id m18-v6mr3719663wrq.278.1538295268509; Sun, 30 Sep 2018 01:14:28 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sun, 30 Sep 2018 10:13:04 +0200 Message-Id: <1538295197-23704-67-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1538295197-23704-1-git-send-email-pbonzini@redhat.com> References: <1538295197-23704-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::430 Subject: [Qemu-devel] [PULL 66/79] qom/object: add some interface asserts X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 From: Marc-Andr=C3=A9 Lureau An interface can't have any instance size or callback, or itself implement other interfaces (this is unsupported). Signed-off-by: Marc-Andr=C3=83=C2=A9 Lureau Message-Id: <20180912125303.29158-1-marcandre.lureau@redhat.com> Signed-off-by: Paolo Bonzini Signed-off-by: Marc-Andr=C3=A9 Lureau --- qom/object.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.c index 75d1d48..9222b23 100644 --- a/qom/object.c +++ b/qom/object.c @@ -286,7 +286,14 @@ static void type_initialize(TypeImpl *ti) if (ti->instance_size =3D=3D 0) { ti->abstract =3D true; } - + if (type_is_ancestor(ti, type_interface)) { + assert(ti->instance_size =3D=3D 0); + assert(ti->abstract); + assert(!ti->instance_init); + assert(!ti->instance_post_init); + assert(!ti->instance_finalize); + assert(!ti->num_interfaces); + } ti->class =3D g_malloc0(ti->class_size); =20 parent =3D type_get_parent(ti); --=20 1.8.3.1