From nobody Thu Nov 6 01:11:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538298692612779.8100679395443; Sun, 30 Sep 2018 02:11:32 -0700 (PDT) Received: from localhost ([::1]:54550 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6Xl9-0006HS-Cs for importer@patchew.org; Sun, 30 Sep 2018 05:11:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6WsC-00032G-0b for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:14:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6WsA-0001G1-VU for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:14:39 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:36582) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g6WsA-00018E-IK for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:14:38 -0400 Received: by mail-wm1-x344.google.com with SMTP id n23-v6so5750357wmc.1 for ; Sun, 30 Sep 2018 01:14:26 -0700 (PDT) Received: from 640k.lan (94-36-187-248.adsl-ull.clienti.tiscali.it. [94.36.187.248]) by smtp.gmail.com with ESMTPSA id u76-v6sm11369194wmd.10.2018.09.30.01.14.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 30 Sep 2018 01:14:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=YZ5yb5d6978UdlhlHuykirfYkjW6vizewR/a2G9fCUI=; b=OzbufgiUlNv5LjVouOwJHuj4Z7LfuL2jMDtUN8SAe4I33fTHa2vSpst4YFnhw45okr WKZi9hpTyYZN9Pj5eLoAhtFc5YeoJ8rV4A/t9pMalqjTTF9YPZc49utuvtMpSyjEZUHl Dge8dW78qsO0gJTBeZ+ykALBUi4bIyaXcTRj/hVeMdJ35U/LRT6c67difWgvjOJGxBmr uNyOuvogD3ivZNjiQ2oRQwpCIIPuPfXblSZHfB0nX4LgjMruslDogiz8D1ZacIOV7vQW zywJQuK2jFFbyVHiyq5feoC8PFDUyJxasKVdI3Ji8p0qrLy0Z0pNc3zYIuNqTT2v7OFT +gOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=YZ5yb5d6978UdlhlHuykirfYkjW6vizewR/a2G9fCUI=; b=lKeED2u5IU7xDvpWx+VnrpKrv2F9Cb22FZtkglj6vqaf1fmJdI0avgGdVpvivOkTag Tw/aFGML5wlH0bI4nLJeOrEsXgClcyYpKSilcJVpSDYfIHyhYHoZqbLkcUTTHSLr3a2B o8sUv70MC5u1/OeIB5JDxPu6eSx7vFvbQepCDAqZcweWhriVpZSu1lUnFAKhPV/EjWmL 344UfpftiOPU03VbttJ+ytr0FhnKCkRDa8QfTzF8oeJ3Z0dSM7pB6OPV1MBhb8gKuDng YYb2LtX0nk7QCORWbaCfnpUrVyfyM/QMNa3i82bEZKbtRrrNuZ+Si2RYupoLkLrRJW0B Jzxg== X-Gm-Message-State: ABuFfojZppEAEf1L5RFPM3tq9yC7XBuvO9XMLSW6MCe0K2D6ThDBEReU /uyC92mi1x80eHXBS7r5K96Wrcc2 X-Google-Smtp-Source: ACcGV61gnkywN55ZZdEF7KULIvA+m8a2C47AK2QBc8hcmiXqu+mWDmfDIih46ldPfrOscZj304dlPg== X-Received: by 2002:a1c:f016:: with SMTP id a22-v6mr5863051wmb.76.1538295265244; Sun, 30 Sep 2018 01:14:25 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sun, 30 Sep 2018 10:13:01 +0200 Message-Id: <1538295197-23704-64-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1538295197-23704-1-git-send-email-pbonzini@redhat.com> References: <1538295197-23704-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 Subject: [Qemu-devel] [PULL 63/79] scsi-block: Deprecate rotation_rate X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Fam Zheng This option is added together with scsi-disk but is never honoured, becuase we don't emulate the VPD page for scsi-block. We could intercept and inject the user specified value like for max xfer len, but it's probably not helpful since the intent of 070f80095ad was for random entropy aspects, not for performance. If emulated rotation rate is desired, scsi-hd is more suitable. Signed-off-by: Fam Zheng Message-Id: <20180917083138.3948-1-famz@redhat.com> Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-disk.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 5ae7baa..c43163c 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -2610,6 +2610,12 @@ static void scsi_block_realize(SCSIDevice *dev, Erro= r **errp) return; } =20 + if (s->rotation_rate) { + error_report_once("rotation_rate is specified for scsi-block but i= s " + "not implemented. This option is deprecated and = will " + "be removed in a future version"); + } + /* check we are using a driver managing SG_IO (version 3 and after) */ rc =3D blk_ioctl(s->qdev.conf.blk, SG_GET_VERSION_NUM, &sg_version); if (rc < 0) { --=20 1.8.3.1