From nobody Thu Nov 6 01:12:40 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538297440087792.2545448365863; Sun, 30 Sep 2018 01:50:40 -0700 (PDT) Received: from localhost ([::1]:54416 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6XR0-00045M-VS for importer@patchew.org; Sun, 30 Sep 2018 04:50:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6Ws8-0002xx-9v for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:14:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6Ws6-0001D0-Dv for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:14:36 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:45402) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g6Ws5-00017o-3d for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:14:34 -0400 Received: by mail-wr1-x442.google.com with SMTP id q5-v6so4000972wrw.12 for ; Sun, 30 Sep 2018 01:14:25 -0700 (PDT) Received: from 640k.lan (94-36-187-248.adsl-ull.clienti.tiscali.it. [94.36.187.248]) by smtp.gmail.com with ESMTPSA id u76-v6sm11369194wmd.10.2018.09.30.01.14.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 30 Sep 2018 01:14:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=oXrCrjCOpgrAT/6Ipj6thpWNnpBrPMEtpTYlt6YA3DQ=; b=XufrOpoZUjbYYg+zGYT5FFh7BDy9qfFNDBhRYMSbt2tsANT4i6rpp+gfpCfkVNgYMg SfxHQOdBiA4ZiAiRwJzShnvgGfZ/fI5P7WJZ8tz/Pq9AI40OkixIKkfqzNpoJtBmWZVE XfhHgli3ltiRS9ZUT+gJMt+KQUiXGS37J6RlabinPpmYPH7ShlRxZSAKEtcmDmwqdkE7 cCoTthY+OiWIgQmv4a5AaMrM8rwSvQWU5FqPDaBSdJFnCLUfSG4a0jRedRgQH/HkCZFd D96+IvjrD5xR22dwFxGNY0efO+96BaPdY833y6msaiEFnHE2KJwflmeMjucXkIIpO8e0 kgmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=oXrCrjCOpgrAT/6Ipj6thpWNnpBrPMEtpTYlt6YA3DQ=; b=Glm0UKP0ViNVKBZOGWv2TVNKcK8SN9siUbSbLUR0I+1lzy1LAQ7psNU9zuFQ76Xp35 5NdnzIjnR0YZs1jAk4m4QFGjuogZTeQIE7iV6IpWVlsL4VQvW9VCrnxHz7iR51YA4D0I jpiiI4jA+0SQr3SfRV1YO/zJDxS581mn6oYkbj71QWVM9JDb27ovSJfkJnw8UKcDgG78 Ras6zZ7sRtkpgk1nOkOoswOis6q3sUz/5cUfxZn11dh0AgUFQaBIDNdr5x4uIw7Xb1SL ZewLcchsXtlLy0KbG9Dl8/D9n1ZCu26Vtztg2kWRW/k2016MyeM84B8S1a0EmuDQmhR9 nE8Q== X-Gm-Message-State: ABuFfohcKiY+PIKBxVcNzjpvQ6iTc/YIlBwnkA9o9j/PU9TPu/TUq8Cr hI6Wvdmzr8Y82fk6lYxkFm0X3RK7 X-Google-Smtp-Source: ACcGV626X+WjESVxNZBLmZnMykjQetq0f83uvUZZyvKhJ/bc9U1NzMix6LpKlzm6MW4oAxvx3iY77A== X-Received: by 2002:adf:a144:: with SMTP id r4-v6mr3643561wrr.169.1538295264290; Sun, 30 Sep 2018 01:14:24 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sun, 30 Sep 2018 10:13:00 +0200 Message-Id: <1538295197-23704-63-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1538295197-23704-1-git-send-email-pbonzini@redhat.com> References: <1538295197-23704-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PULL 62/79] kvmclock: run KVM_KVMCLOCK_CTRL ioctl in vcpu thread X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yongji Xie , Yongji Xie , Chai Wen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Yongji Xie According to KVM API Documentation, we should only run vcpu ioctls from the same thread that was used to create the vcpu. This patch makes KVM_KVMCLOCK_CTRL ioctl consistent with the Documentation. No functional change. Signed-off-by: Yongji Xie Signed-off-by: Chai Wen Message-Id: <1531315364-2551-1-git-send-email-xieyongji@baidu.com> Signed-off-by: Paolo Bonzini Signed-off-by: Yongji Xie --- hw/i386/kvm/clock.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c index 0bf1c60..25ea783 100644 --- a/hw/i386/kvm/clock.c +++ b/hw/i386/kvm/clock.c @@ -147,6 +147,15 @@ static void kvm_update_clock(KVMClockState *s) s->clock_is_reliable =3D kvm_has_adjust_clock_stable(); } =20 +static void do_kvmclock_ctrl(CPUState *cpu, run_on_cpu_data data) +{ + int ret =3D kvm_vcpu_ioctl(cpu, KVM_KVMCLOCK_CTRL, 0); + + if (ret && ret !=3D -EINVAL) { + fprintf(stderr, "%s: %s\n", __func__, strerror(-ret)); + } +} + static void kvmclock_vm_state_change(void *opaque, int running, RunState state) { @@ -183,13 +192,7 @@ static void kvmclock_vm_state_change(void *opaque, int= running, return; } CPU_FOREACH(cpu) { - ret =3D kvm_vcpu_ioctl(cpu, KVM_KVMCLOCK_CTRL, 0); - if (ret) { - if (ret !=3D -EINVAL) { - fprintf(stderr, "%s: %s\n", __func__, strerror(-ret)); - } - return; - } + run_on_cpu(cpu, do_kvmclock_ctrl, RUN_ON_CPU_NULL); } } else { =20 --=20 1.8.3.1