From nobody Thu Nov 6 01:11:10 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538298372186974.4802952469151; Sun, 30 Sep 2018 02:06:12 -0700 (PDT) Received: from localhost ([::1]:54515 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6Xfz-0001gq-R0 for importer@patchew.org; Sun, 30 Sep 2018 05:06:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6Ws9-0002zm-QF for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:14:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6Ws8-0001Dg-8Q for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:14:37 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:52670) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g6Ws6-00010b-BG for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:14:35 -0400 Received: by mail-wm1-x335.google.com with SMTP id 189-v6so5492390wmw.2 for ; Sun, 30 Sep 2018 01:14:16 -0700 (PDT) Received: from 640k.lan (94-36-187-248.adsl-ull.clienti.tiscali.it. [94.36.187.248]) by smtp.gmail.com with ESMTPSA id u76-v6sm11369194wmd.10.2018.09.30.01.14.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 30 Sep 2018 01:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bNnBuQs6TGjJQ+LFv3wZcL7YDwkpNUcCTKJ2MHRpFe0=; b=AX/j6kRcN1ZtnH95wSnsq/ae57ScDjsS+0A22cFIVUT2RFmzMcmjwkdgP+cIqBy8Yw sTVE7n9Y/mG8t/ss+vxHVCKrLYLaoc+rs4fdM2x7mjm4xgaVBOtuAboYoxxPI9U4wc1w AuyDkLjqF763nRLGyJtycdfQ87OU3o0VryDWQz/X7ja1MaEFw7dwX+z5MmlvQR08m710 S6ONm9C+cYZwLjfRfgjmroHuPb7jr4Va29ifg9bH+JyV8SWrCISr5ZoESet05yBRDMek Y6o5zuG813yy3JD2BsANU7eIefebBs2vxwExqW5ks5i3D54EjItol2HCLVJbT4WNMo91 NBQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=bNnBuQs6TGjJQ+LFv3wZcL7YDwkpNUcCTKJ2MHRpFe0=; b=kQ8bdFrnnG0ryPrj+w4KDxf6TR3g2qeyDrwJurw2W2TvQ1x+djBqLvNK52vPd9tkfO qKKbmGdo2OZ0GFsxUdQln/SMfJCeDWnbXRQCHVRcUleKX7rD0rx27z5uRgf/MDdkLqTY 4mHBoFjNNz8HOmwopGm1XLxZX1HE3FkIoX9eJi7hnRlpWdzGmpU5YpK6cZwjPGDvGc/W h+fgaS1tmhHIuvHQK53l7gUyyS2dnnkeaiHWmf501q9AtcEf1kGTnnJ/OSO3YC7kkbA9 dTMS9Vv6Ed/xaT87tbG6VrBctJX8XmJARI7ogUuucZTXS+bxu8eH8Cv1eRjGWAMEh/dJ Pl7g== X-Gm-Message-State: ABuFfogyLHRl1B+2vIP3troAoNK7Gl1zDI7eFdbs/d1q/ZYlvTsOiYbB Q48rv6K+v1AYWuLHZPS+3OC1NS/B X-Google-Smtp-Source: ACcGV63SThLS/rnl2XKMluiMcBDJU7zIAoV9JA55WjwbHz5OxLYxL0Yz5W/h4jGTOmzAtLJZDaHFlg== X-Received: by 2002:a1c:8942:: with SMTP id l63-v6mr6240883wmd.66.1538295254917; Sun, 30 Sep 2018 01:14:14 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sun, 30 Sep 2018 10:12:51 +0200 Message-Id: <1538295197-23704-54-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1538295197-23704-1-git-send-email-pbonzini@redhat.com> References: <1538295197-23704-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::335 Subject: [Qemu-devel] [PULL 53/79] test-char: add socket reconnect test X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 From: Marc-Andr=C3=A9 Lureau This test exhibits a regression fixed by the previous reverts. Signed-off-by: Marc-Andr=C3=83=C2=A9 Lureau Message-Id: <20180817135224.22971-5-marcandre.lureau@redhat.com> Signed-off-by: Paolo Bonzini Signed-off-by: Marc-Andr=C3=A9 Lureau --- tests/test-char.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/tests/test-char.c b/tests/test-char.c index 2a2ff32..2670ff6 100644 --- a/tests/test-char.c +++ b/tests/test-char.c @@ -307,7 +307,7 @@ static int socket_can_read_hello(void *opaque) return 10; } =20 -static void char_socket_test_common(Chardev *chr) +static void char_socket_test_common(Chardev *chr, bool reconnect) { Chardev *chr_client; QObject *addr; @@ -327,7 +327,8 @@ static void char_socket_test_common(Chardev *chr) addr =3D object_property_get_qobject(OBJECT(chr), "addr", &error_abort= ); qdict =3D qobject_to(QDict, addr); port =3D qdict_get_str(qdict, "port"); - tmp =3D g_strdup_printf("tcp:127.0.0.1:%s", port); + tmp =3D g_strdup_printf("tcp:127.0.0.1:%s%s", port, + reconnect ? ",reconnect=3D1" : ""); qobject_unref(qdict); =20 qemu_chr_fe_init(&be, chr, &error_abort); @@ -368,7 +369,15 @@ static void char_socket_basic_test(void) { Chardev *chr =3D qemu_chr_new("server", "tcp:127.0.0.1:0,server,nowait= "); =20 - char_socket_test_common(chr); + char_socket_test_common(chr, false); +} + + +static void char_socket_reconnect_test(void) +{ + Chardev *chr =3D qemu_chr_new("server", "tcp:127.0.0.1:0,server,nowait= "); + + char_socket_test_common(chr, true); } =20 =20 @@ -400,7 +409,7 @@ static void char_socket_fdpass_test(void) =20 qemu_opts_del(opts); =20 - char_socket_test_common(chr); + char_socket_test_common(chr, false); } =20 =20 @@ -819,6 +828,7 @@ int main(int argc, char **argv) g_test_add_func("/char/file-fifo", char_file_fifo_test); #endif g_test_add_func("/char/socket/basic", char_socket_basic_test); + g_test_add_func("/char/socket/reconnect", char_socket_reconnect_test); g_test_add_func("/char/socket/fdpass", char_socket_fdpass_test); g_test_add_func("/char/udp", char_udp_test); #ifdef HAVE_CHARDEV_SERIAL --=20 1.8.3.1