From nobody Thu Nov 6 01:10:30 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538297606793722.4542655962833; Sun, 30 Sep 2018 01:53:26 -0700 (PDT) Received: from localhost ([::1]:54432 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6XTh-0007DN-OZ for importer@patchew.org; Sun, 30 Sep 2018 04:53:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41510) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6Wrd-0002Xt-Jc for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:14:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6Wrc-0000sH-4e for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:14:05 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:37378) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g6Wrb-0000qh-QB for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:14:04 -0400 Received: by mail-wm1-x341.google.com with SMTP id 185-v6so249271wmt.2 for ; Sun, 30 Sep 2018 01:14:03 -0700 (PDT) Received: from 640k.lan (94-36-187-248.adsl-ull.clienti.tiscali.it. [94.36.187.248]) by smtp.gmail.com with ESMTPSA id u76-v6sm11369194wmd.10.2018.09.30.01.14.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 30 Sep 2018 01:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=7cVSjEW5OjAc7293Qgnb9C3jAHOUul8aN/kG4RB490Q=; b=D2SwNASZTIzq7MUXtjpk+V99zoqc5oGucKiSDnDmBFAvSjF98JjFF3SG08MkmtEduy vpjaLcvAFiL8haWvB7k/GLVkkL4NGt20+qwZxxwUqkcQw2ebcdqqccQJCBMt9/ko4/c4 9gOiOF31LHNFrx+KDwSvroqMdIupdFduuZyHmnn3fCBtvYJB8Kr9i/8I/fVEplWbi4hz nyRiFsIxFwXvyE2MoP7U796jXsOfvsLXlDSPykSskzbGtN5bMwVOY132VxfO23VJC21h CgA/zVb4aReqKYgxtRlXDUV34cCli6Jtm/nk2mTvIJmb7kP7TwedvNGOtc+v2jZwCKnc Xiwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=7cVSjEW5OjAc7293Qgnb9C3jAHOUul8aN/kG4RB490Q=; b=X6mvG8p18Vd6fSzgxGxOsXk+QUB9VKcs/qRcq0jfKRlTSJnt/m9WjmIvg0U2RkfdOl YS1rkbGrZTZNqO6TfPQQyE7wPL2Sse0HSbahlOmd56zh5A/NQQGX3ao4H3zORtdREUap wx9ZJ1K4uOD94XzYc2ir8ldK91xY1FZ9dsnNfjTbjXEc1bZ9zDO9JxKI4ZSdNZ9bD4KW LBhQiKrm6c2jIW9jnLp3RwHC7Li7RKqW3+iePK6TEJWO/PfR3bATD+T4Rt2G91P5n7F8 wezKL3UFGB866N1stgt+hzKAIiSqYqxfsLCst3scpzvBLlD+LUkhQQuzncnmN9kohDDB QnJQ== X-Gm-Message-State: ABuFfoj9zpGlf1kRrmZyjx2jZ9IgiEQZ4LFQHEUW6VTrPxZdwPg4Dc/G ZVclLATocjBSEC/R1vrskWlnnFQy X-Google-Smtp-Source: ACcGV60vnRkXZrBWkEsa3oemIY0bNeEarkIArNqqyLPhSS63z+zYostjJ6+2PvV9lo+GHkwkaIVuHA== X-Received: by 2002:a1c:ed1a:: with SMTP id l26-v6mr6164980wmh.61.1538295242114; Sun, 30 Sep 2018 01:14:02 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sun, 30 Sep 2018 10:12:37 +0200 Message-Id: <1538295197-23704-40-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1538295197-23704-1-git-send-email-pbonzini@redhat.com> References: <1538295197-23704-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: [Qemu-devel] [PULL 39/79] replay: flush events when exiting X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pavel Dovgalyuk Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pavel Dovgalyuk This patch adds events processing when emulation finishes instead of just cleaning the queue. Now the bdrv coroutines will be in consistent state when emulator closes. It allows correct polling of the block layer at exit. Signed-off-by: Pavel Dovgalyuk Message-Id: <20180912081859.3228.79735.stgit@pasha-VirtualBox> Signed-off-by: Paolo Bonzini --- replay/replay-events.c | 14 +------------- replay/replay-internal.h | 2 -- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/replay/replay-events.c b/replay/replay-events.c index 707de38..0964a82 100644 --- a/replay/replay-events.c +++ b/replay/replay-events.c @@ -94,18 +94,6 @@ void replay_disable_events(void) } } =20 -void replay_clear_events(void) -{ - g_assert(replay_mutex_locked()); - - while (!QTAILQ_EMPTY(&events_list)) { - Event *event =3D QTAILQ_FIRST(&events_list); - QTAILQ_REMOVE(&events_list, event, events); - - g_free(event); - } -} - /*! Adds specified async event to the queue */ void replay_add_event(ReplayAsyncEventKind event_kind, void *opaque, @@ -308,7 +296,7 @@ void replay_init_events(void) void replay_finish_events(void) { events_enabled =3D false; - replay_clear_events(); + replay_flush_events(); } =20 bool replay_events_enabled(void) diff --git a/replay/replay-internal.h b/replay/replay-internal.h index ac4b27b..9b0fd91 100644 --- a/replay/replay-internal.h +++ b/replay/replay-internal.h @@ -142,8 +142,6 @@ void replay_init_events(void); void replay_finish_events(void); /*! Flushes events queue */ void replay_flush_events(void); -/*! Clears events list before loading new VM state */ -void replay_clear_events(void); /*! Returns true if there are any unsaved events in the queue */ bool replay_has_events(void); /*! Saves events from queue into the file */ --=20 1.8.3.1