From nobody Thu Nov 6 01:09:05 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 153829534938358.66444382781572; Sun, 30 Sep 2018 01:15:49 -0700 (PDT) Received: from localhost ([::1]:54212 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6Wt7-0003Rk-PY for importer@patchew.org; Sun, 30 Sep 2018 04:15:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6Wr2-00023J-H9 for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:13:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6Wqz-0008Hs-9p for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:13:28 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:40528) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g6Wqy-0008DR-Mj for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:13:25 -0400 Received: by mail-wr1-x444.google.com with SMTP id y8-v6so10477628wrh.7 for ; Sun, 30 Sep 2018 01:13:22 -0700 (PDT) Received: from 640k.lan (94-36-187-248.adsl-ull.clienti.tiscali.it. [94.36.187.248]) by smtp.gmail.com with ESMTPSA id u76-v6sm11369194wmd.10.2018.09.30.01.13.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 30 Sep 2018 01:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=jdeBiL3qzqKxD5AEVWF1Bzw02uJpmkoioxT70u3e2Ns=; b=R3jjvu3peqfYVa1vFPVXVxMEiB6LnqQ7q/w2iNvGK3gYyqKX5lx19wq5FxoxKNTY82 WfiUDj9M8ygIEWBBOti7ACA319yu8Z5IRwtuu/1NsOEk7vzooNS5qr6cdCR49OF7ywcO RbKy2df5o7Vj3MQVzd0PE0grWUj+ptQ/PgVQRhwILBjBvFjEfngr+6kWv6ZaY4DomMqT HaA8JifdDIocMGXqJzSnTK6/ugCf3QdGqT7UVKpT+vKA8yheikCARRTpK9frCRXWZkHc Y6DXGxrW8JjI9rVJhLF96lKK5Wm/uwy5ksXgPrXwoKcziH609Jlgl8MH99rPMCfOmXxS LnLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=jdeBiL3qzqKxD5AEVWF1Bzw02uJpmkoioxT70u3e2Ns=; b=ZK2ZkZOXmGJpq9hJRky/LXi3FOxcNEiRvslger5lreGiGI6RugRt0XCj6QkCS1N4iI MaMU5B9+An+8nJNZ3BYj8NkklitbwQH+c+PFjUAzs3z2rkL14Vufa/GV0yp2CQyo2RQS Xps9xdOyuJP93J5jJqrNE4F5ifMEEuocCYinoUyfyNX9+LDerXrNd2OhMRBngHYLoyPt pMtf0JhxH+MQIdeY+b7KUBpQYB8vZ/G98IeFZQhiARJeeKzpcX25fWZeu2cznORhZM6K erG2t/zCanU6YdiRzWKI5VxdWz4wKX4KlLdvKcs16Ug4bJhgLDO0l3MyC2GnFB1QIuBz oaeg== X-Gm-Message-State: ABuFfogXaDc/Ifyc/jO9iXStSAsESdDriPrjprRGMHDxj9XU37hv2NoM u5FhLt4FJ/TmmGcuqVOHephAtz/i X-Google-Smtp-Source: ACcGV62dRzmnh1C6zmgvhIFdUYDRk98YjX8bVA/yrVOw8GYTMXMTkkuaIzGWdqR+lB6oWijQCjF0jA== X-Received: by 2002:adf:9464:: with SMTP id 91-v6mr3802294wrq.200.1538295201353; Sun, 30 Sep 2018 01:13:21 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sun, 30 Sep 2018 10:12:00 +0200 Message-Id: <1538295197-23704-3-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1538295197-23704-1-git-send-email-pbonzini@redhat.com> References: <1538295197-23704-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PULL 02/79] qsp: hide indirect function calls from Coverity X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Coverity does not see anymore that qemu_mutex_lock is taking a lock. Hide all the QSP magic so that static analysis works again. Signed-off-by: Paolo Bonzini --- include/qemu/thread.h | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/include/qemu/thread.h b/include/qemu/thread.h index dacebcf..b2661b6 100644 --- a/include/qemu/thread.h +++ b/include/qemu/thread.h @@ -48,6 +48,22 @@ extern QemuCondWaitFunc qemu_cond_wait_func; #define qemu_mutex_trylock__raw(m) \ qemu_mutex_trylock_impl(m, __FILE__, __LINE__) =20 +#ifdef __COVERITY__ +/* + * Coverity is severely confused by the indirect function calls, + * hide them. + */ +#define qemu_mutex_lock(m) \ + qemu_mutex_lock_impl(m, __FILE__, __LINE__); +#define qemu_mutex_trylock(m) \ + qemu_mutex_trylock_impl(m, __FILE__, __LINE__); +#define qemu_rec_mutex_lock(m) \ + qemu_rec_mutex_lock_impl(m, __FILE__, __LINE__); +#define qemu_rec_mutex_trylock(m) \ + qemu_rec_mutex_trylock_impl(m, __FILE__, __LINE__); +#define qemu_cond_wait(c, m) \ + qemu_cond_wait_impl(c, m, __FILE__, __LINE__); +#else #define qemu_mutex_lock(m) ({ \ QemuMutexLockFunc _f =3D atomic_read(&qemu_mutex_lock_func); \ _f(m, __FILE__, __LINE__); \ @@ -73,6 +89,7 @@ extern QemuCondWaitFunc qemu_cond_wait_func; QemuCondWaitFunc _f =3D atomic_read(&qemu_cond_wait_func); \ _f(c, m, __FILE__, __LINE__); \ }) +#endif =20 #define qemu_mutex_unlock(mutex) \ qemu_mutex_unlock_impl(mutex, __FILE__, __LINE__) --=20 1.8.3.1