From nobody Thu Nov 6 01:10:28 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538296268893634.7092741433937; Sun, 30 Sep 2018 01:31:08 -0700 (PDT) Received: from localhost ([::1]:54301 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6X87-0001Hg-JH for importer@patchew.org; Sun, 30 Sep 2018 04:31:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6WrF-0002DS-Rk for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:13:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6WrF-0000JI-1h for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:13:41 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:37379) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g6WrE-0000I8-QD for qemu-devel@nongnu.org; Sun, 30 Sep 2018 04:13:40 -0400 Received: by mail-wm1-x344.google.com with SMTP id 185-v6so248881wmt.2 for ; Sun, 30 Sep 2018 01:13:40 -0700 (PDT) Received: from 640k.lan (94-36-187-248.adsl-ull.clienti.tiscali.it. [94.36.187.248]) by smtp.gmail.com with ESMTPSA id u76-v6sm11369194wmd.10.2018.09.30.01.13.38 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 30 Sep 2018 01:13:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=/A4udbWrKMFxS8s4tAM2pV34nq9v3KfQtUFzQMipFZ0=; b=MBCRrTyGMmtXJYUGtOq5fr67uPD3ho6ChG+4YxDTz2nTuQsaXCtZGHAokhKBsDsSGK jy3UCedKRgmJu+nJHshpsAH0MVZVx5qQOjm3SoXPvU06qDALF++u661wZUdA2/aqqbxy d9n6DQvto/M2uWvKhs1KTrvXFIqymJMopYAyTDyLCW4b/Fx9ddSlnXIMcjIe0TTH8vJB 0dPLXLFj24QWQP09KKgVbRYUULN1Olqsh9gmgTbzQxPp/T+1TJf/jjath1Rn+p/BACrT oXbe+qayDzuX4O/HQH1yDnKrVz/NbOPOxxt4NjCq2LM55OOZwq/gjQGEMBu3l1NAynvS n4Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=/A4udbWrKMFxS8s4tAM2pV34nq9v3KfQtUFzQMipFZ0=; b=khTh6wDxSK42HR9C4zkdQdmT7IymOkHIBchqr2xFRO5vdULeWjd7b7gU9sjR4bGoP5 GtFbtnY9vVXdahRUKByqx4GAB9qutCKGAxMJLG/6BckKgHX+XJL2W7J0de3dgqpDhR/F zvOBfxcauIB657P0gTp1V072PlpAaycyy8oNAcyR8j6FfAiYjgxax/5sJ9idIj+eRvC6 BQlO3Q1ctbS6vEX6H198O3IM5p56lqR8bTyd+54EeWBqXdbtqJWvM6Ly/dRQkf+F9uiO sgorlafZC6SVXUdIbM21w9NDBO4V1/PTyhEQiOqOqVqdsU90wPq2Z9hN6zErWs1ULX4D /LUw== X-Gm-Message-State: ABuFfojE8FNhoE6LJ5p9pDFu2SAx3jWcV5Q6EmB0Zg9J4C0WasVEBcxk 4OzSxuA3x/GV8RxrHUycqxZc4Ooz X-Google-Smtp-Source: ACcGV60BcDW9rW9fjOuLr8igvuFYS2g3Nc2FHIhUcKJrtcFUoTKscB9tGYsaIZQtf7y1ptMWwMFXnw== X-Received: by 2002:a1c:8313:: with SMTP id f19-v6mr5722994wmd.144.1538295219595; Sun, 30 Sep 2018 01:13:39 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sun, 30 Sep 2018 10:12:20 +0200 Message-Id: <1538295197-23704-23-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1538295197-23704-1-git-send-email-pbonzini@redhat.com> References: <1538295197-23704-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 Subject: [Qemu-devel] [PULL 22/79] serial: fix DLL writes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Commit 0147883450fe84bb8de2d4a58381881f4262ce9b tries to handle word-sized writes to DLL/DLH, but due to a typo, this patch is causing tracebacks in all Linux kernels running the PXA serial driver, due to an unexpected DLL register value. Here is the surrounding code from drivers/tty/serial/pxa.c: serial_out(up, UART_DLL, quot & 0xff); /* LS of divisor */ /* * work around Errata #75 according to Intel(R) PXA27x * Processor Family Specification Update (Nov 2005) */ dll =3D serial_in(up, UART_DLL); WARN_ON(dll !=3D (quot & 0xff)); // <-- warning Reported-by: Guenter Roeck Tested-by: Guenter Roeck Fixes: 0147883450fe84bb8de2d4a58381881f4262ce9b Signed-off-by: Paolo Bonzini --- hw/char/serial.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/serial.c b/hw/char/serial.c index 251f40f..02463e3 100644 --- a/hw/char/serial.c +++ b/hw/char/serial.c @@ -345,9 +345,9 @@ static void serial_ioport_write(void *opaque, hwaddr ad= dr, uint64_t val, default: case 0: if (s->lcr & UART_LCR_DLAB) { - if (size =3D=3D 2) { + if (size =3D=3D 1) { s->divider =3D (s->divider & 0xff00) | val; - } else if (size =3D=3D 4) { + } else { s->divider =3D val; } serial_update_parameters(s); --=20 1.8.3.1