From nobody Wed Nov 5 20:12:43 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1536949770481316.5234146011037; Fri, 14 Sep 2018 11:29:30 -0700 (PDT) Received: from localhost ([::1]:52873 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g0sqN-0000us-Om for importer@patchew.org; Fri, 14 Sep 2018 14:29:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g0sof-0008UA-2U for qemu-devel@nongnu.org; Fri, 14 Sep 2018 14:27:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g0sob-0003n6-Ie for qemu-devel@nongnu.org; Fri, 14 Sep 2018 14:27:41 -0400 Received: from mail-bn3nam01on0044.outbound.protection.outlook.com ([104.47.33.44]:18854 helo=NAM01-BN3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g0sob-0003m5-C8 for qemu-devel@nongnu.org; Fri, 14 Sep 2018 14:27:37 -0400 Received: from sbrijesh-desktop.amd.com (165.204.77.1) by DM6PR12MB2684.namprd12.prod.outlook.com (2603:10b6:5:4a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1122.16; Fri, 14 Sep 2018 18:27:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pcr4pJ7L/JjxSJ5HJ1kJ+uNXmkHqT4c9RPSKdAmTATA=; b=gC2W0YSBXDLFgZg6PUIwla5SjimDeeirREWYWetJlveI6TeVxPJCMewa7Y4LLLsCJZuNGdpyzTaVoXQYBe5LlVXZt4RwwDwy4Uv0jdKIxTQUAGx9D5ZK3vVf8pSKo89JjnZhOzsMd5qA7BeSGWMGP1X235pzA6v061yIBr77GAo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; From: Brijesh Singh To: qemu-devel@nongnu.org Date: Fri, 14 Sep 2018 13:27:03 -0500 Message-Id: <1536949623-23564-9-git-send-email-brijesh.singh@amd.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536949623-23564-1-git-send-email-brijesh.singh@amd.com> References: <1536949623-23564-1-git-send-email-brijesh.singh@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BYAPR01CA0001.prod.exchangelabs.com (2603:10b6:a02:80::14) To DM6PR12MB2684.namprd12.prod.outlook.com (2603:10b6:5:4a::33) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dff4c30d-98e6-410d-d199-08d61a6fbdbf X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DM6PR12MB2684; X-Microsoft-Exchange-Diagnostics: 1; DM6PR12MB2684; 3:jl4nzHkjGw3F2ovyPOY79vr6T2SPir0NFQwwrRGNUNwHsCfBAkL8mBua/nh/5CbdUtCcYHS4b5vDzlTuY/0oqpZCSOZ5aKvGsIuBqe+cAKytZJn+scA3Zn6otEosgUI9M8HjHYfz+wN+PCP7lI160bxWXJM+t5voLL8Wn8z3BvfoNBvjzaLFJKgm3XyvS6M63Os7oPQJgZlPWKQ3OrUqCqXPmt1QxHNRAD3cRUfpBXm8dzweiiEADls2wvRfd6e0; 25:Om7byMaBMjmcyBBXu/ey+SmUkxoeC2zpKC6dO306xejPDRSs9XcjiKd6/uM1IJfB3WPYK4JM8TzXxevLdx3QI9ijuPlbFJHkLc3vjZIQv1AcgzdIeuf4VHysJSaB4aE24h+keQy1olNYA9nMMGb1BcdSkAJUUtWelvu16R9c82I9O0nUEzKHXAi6zF4iz5xXlKaldt2skcCpZg2JY+EFWJkZq/UzRzJBTyLi/CCMjp1W70FujzDRMYIoG1vlUpAylPx1c97+inR+OuV0GurSIlBlwta4rbkkHLrJCdImuCqh+2nTvmR/l+MnfovrmOiO89ZUOehcSqOUM+cPc1fRLQ==; 31:uHu5aLUBTmY2zSba3mzIqoGKfxL3wBAhP5L0hO3XIlJjOESXxKe4/ThfjUq57qAyZKybRgUNO+dIAjMW/xxjHFsS0hMpgG2xe6o0T0Zc51KpOM2QtqfeJ3VMIuBnda/QAGgNqLLQQFECz3v6r3cnz1qfpRqsEmusFmlMFYXQpO1c/6Z23hgsJ+Efx6i8OYgqIczOeBwQsjON5ueEUgZLOpRvGmnllFnr9ZXnpu8MEC8= X-MS-TrafficTypeDiagnostic: DM6PR12MB2684: X-Microsoft-Exchange-Diagnostics: 1; DM6PR12MB2684; 20:ZQ1Xz+KyyBNYLxp0xNJifjohVv3clOXc5VBRroYG+0C7MnZflNbzwg/1sPv4CKE6KFIkDRs9dT5XbUhJRL64gKgkxxRbQ51kjGKbI2rGGVwRcKJKxKNF4HBM7j+JWX3/D83oxezRW5VR/lPmG5gMMea2O4gSvVLXcjajwOZw6bpOJ3HAnivZQFL7V2Mm4zcpL7sRFMlqmeAdgRVlD4j8gfqf80mPCHH++VP5iypHN/80mpH3DyC5rVdcrUiXo/JbWqR1h3Lj2jeOh7wSa79nW3PRL0yEiNLvcEFMrb0LObAgLi9bCLYEXai7eEs/ADn6hWYFlXnlMraVp+weVY42BcZZedqMJQfa/V6AL9AgZKZmP5GhfxS7+BX1gKREIFPjZR/BMTSEkHsqzDoUwj3vq7BjrvkoYrHhtvMQ9wofRAki/nBcoCm0/2gGnscmx0xsk48pEfbuT8Ok9rmVjCjyCT4Nls6yTqv+HYKDNRS1VZFJS3TMXk4kwtgQ1kvv67Ch; 4:0PR/ePcmXzT2ASCf7c7PawlQmNHcX2pSj0Duh1qHuBRw6Xch5V+Cu0lL+CIjhulTd3jqCDxE7FdRSYuX7Fapr3hrFoI7ihEVEwKaG4SrVRkX3RrsWgXnnZ5Iuz+oLyHsTqsHef+UWbCbk4221YGp8sHAysRtpfwwUo/fZtC4RqKQ86M1CCVyL/te9hrIo12HD41av1rNo3BVe4aEGdLkuz1/wOI/fEoqDFwrXBwsJ36B0ifqWl6/E+swX+EoCLDVRrhPdM/7iTw1yOBJAme3394M7u/W52ca5q+c4tP6cOC1dfbsFcOw4oxZIAUA/LmdVPDc6g3jWsBiUug1J2XAGH37mJfcQaHNOLvx4aCWFHCVXsuV46wcCAtc7/zybRdi X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(85827821059158)(767451399110)(211171220733660); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(823301075)(3002001)(10201501046)(3231311)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699050); SRVR:DM6PR12MB2684; BCL:0; PCL:0; RULEID:; SRVR:DM6PR12MB2684; X-Forefront-PRVS: 07954CC105 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(136003)(39860400002)(346002)(376002)(366004)(189003)(199004)(50466002)(66066001)(48376002)(2906002)(25786009)(446003)(16586007)(6486002)(76176011)(39060400002)(7736002)(68736007)(51416003)(7696005)(305945005)(316002)(6666003)(6916009)(47776003)(53936002)(52116002)(386003)(956004)(486006)(11346002)(5660300001)(54906003)(2616005)(8676002)(478600001)(36756003)(476003)(186003)(44832011)(105586002)(2361001)(3846002)(106356001)(26005)(81166006)(81156014)(8936002)(2351001)(53416004)(16526019)(50226002)(4326008)(97736004)(6116002)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR12MB2684; H:sbrijesh-desktop.amd.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM6PR12MB2684; 23:bvfZ/12i1DdLfe3au6b1Uudp5yfyqK2cZDeKyEHnM?= =?us-ascii?Q?llpAS3AqtvnAmpoeVjvk50h7Bq7NgiBjI/miZBUyAkPGwSXdPXr3u1A8fmN2?= =?us-ascii?Q?pKBR3l5LUI6mDwdZLQA/W4EmUKioGt+wSRZr3rjipK8nJE+flFeZUP+G9u+3?= =?us-ascii?Q?agQactguRPN0P/089rVXsJaGreVts9u2nxs1ydZTsl2pP1/si3fZXXY652C9?= =?us-ascii?Q?pl1RTLipRiUkgBpdXSPxQrSALhih/4KCVUkeNvsNwWWGX9njWyyGSuZ2BScR?= =?us-ascii?Q?69tsrYfuWM//9R0NmKzE6VIz4eqb6Qy21PBQlzj9y6kLkrGWuOAge9/7YXZl?= =?us-ascii?Q?TUP2G2eJVKH13VDlaAtSz6x8Y7dikfaPEovTz46OUEcKupDj1VJsz7CSLnO4?= =?us-ascii?Q?netHfpTY/VmYWjXZs5AiWk3DzQJciKvGu37yFQ1NYbXiSyWfl3EdtZu1qZu7?= =?us-ascii?Q?6JSRSDtr97nIxzDzALKqxF+lVwmar7kSQ/VxA400tCshxi0pNzJBytoI18CD?= =?us-ascii?Q?871v5dHamRmXJiTj47QEtfm0WrZqHLud930uH6+ofKc1J2SFvvzRpRI6mvop?= =?us-ascii?Q?NqA1+oFRbc7umJZfjVT22t6Q9lSphN1G9qrXTqhkHdh5EcXE0VodTwm9foXd?= =?us-ascii?Q?7PNM7J9ctqjFcFPOChFFVqeWTzv0Tw0bAoZUr5sxua0vlRLM9s9/v5tQnQLZ?= =?us-ascii?Q?klp+ICSm+6hnhqgy9REUqHzJ6ir6Wz+Je5A9Hkz608APoymkrgAYcFQxYf7D?= =?us-ascii?Q?sViy/9PHtt7yfd7Bu7NHt/yeZcG6wnKSmkeFaUC1rcpfhVLDpVPFyTT3eint?= =?us-ascii?Q?KPWqzv0TlyKPbiiJOcmABViIcntT4tukyN85pCOeycm35kDfCZwqdLFiuzmW?= =?us-ascii?Q?R7FOShPvNZ7i/aTrVbL9eNY4XAKbBkfhUTUWpH0qazGJuV/UOhG5eoapVoRP?= =?us-ascii?Q?XyCjR5uAaHONCl//+1WTWihY0/gF2WVDvY59cst1ZXbFmLseLkzdSy8/xnV5?= =?us-ascii?Q?jHIADki6vQm8r6RLXiCzZvH0XUi3K/UJvt+e+8rJMwl/aY6ZkSVRqcz/1Oip?= =?us-ascii?Q?cKhtYTrLwQ+KcyBjFQJnqksEdT2ZoHZbSOVnCIozck0tCCbf58l7fUYaaQfE?= =?us-ascii?Q?iz0lMtCt7zHbduXZ0ie0eMxOLkDjgMESDxme5BbtGJDvCkipjcAnsJHXVByp?= =?us-ascii?Q?6IWK0CdpS+MXm6nq6dv6IhHjWknIacjC1GsmNbKWnPD43Kgc0TMyEAbrvxwK?= =?us-ascii?Q?w371dD4zv/BWCgVmqGqKOp5SCIVXnyPaq/aFyu/?= X-Microsoft-Antispam-Message-Info: fiUpI6ZBU6FiXjayS6l8aGWrsMzfpetfN5O0+GvNbvuJDrdmcI5SeV5owukDcxDTWALBULUI44aszmT9w5tM7dF1kvx03yQKeQlKR851NelWOyCusBAmtuCkulzBntxACWw9hzbmE86a2YeRj/wBxMHnuWLTqj1cngbPTRhXx2tXh1pBjGvYRvcoQWuLi5PR6MOp8SUDVktwE/FRjqbrtoVZVtb3SYzBTfR3e0m1+rf7qsvIc/vOoxv73qPS07l3H2vKQRfRBakkgZvEy/9TSzRanyxi7f0VcLeQhV9OSzGHd0/pyr73p/iYjH1lxyQ8pQy7YItsoyewFnx5CZbB8++AhcScRMPo2Rgh2b/Zv2o= X-Microsoft-Exchange-Diagnostics: 1; DM6PR12MB2684; 6:l9XJOOCyur808I2rnHeThySwQm/FblUjZ8GmHTYMP+S3gWFVMnq5u+hb5N3nIu1C1/gf/u6UpvM46Zcz+4WZ1aFyWaZIaoZRxCjAKLrVjs/cdo7Uw5DybwNTvrGAyjrvwrL/qXTzQJeXB4PFL4vfm5vOIaI2xrhsaHNOC/R6iJ7CtlBqw+gPnOl5WFDjT1s4FZLII6gXWAj5w8Jpo6W/TzQPgFYMMXcFsiymagIdiSfGbO68cXnQ2qE1BO5lf0hM1w1G43wzwBJsDzAgMJjvQokyEPx3B+IMtvSzPYfsaSv54BRtXFr1NPhSPml9Mw1hjNNbHFoSM8/BeG2iPXNGv1R6wiCyIN/n90x6o/tlMskahAWv4jTuP9Pw07wLCDL3jYqBttt77UuKhQgpQhxWRVd0LuQJWxwrzjiGsAU9NtYDwEEx4P44Zy4X6hyAiWCgs2OV/yxNlPX2mZ/i9uLFcA==; 5:QEC1woYcp8lsFag0lfXxgE5xoMagt1PKriSpArAjHv5JNrQbpigJg+vejBlFgKzED1HLuvwoENzWVfjz88SinguV2znriZa8a9S9IaRhO/rrgkm7nJBP/I5qcsrxg+GyF/YL85h+bM2wVAteySTKwvJTNVmSMfJnI71yEdGzrpI=; 7:9/1sOEllZKsTIDo4JWDURLqTP2kxV9j5tNZt8RV6cpVOdbU/+YwDHacNvj1FRDZXbM+dJj51KVpge7e7fNljZWXxj36Oqg09xwBgsjKpC4lQYx8r7dT5BYY4YMdAeC1bYLwBuekJ6v1JSKy/4aDj2loSbTuS9xoMhta9yUvguwsOv5rht8ra1wMHDyFwfQsuS0LEkuvB784JaX8fa8Jm/MW9ps1gs6jUOtoLfd/ja4XNZTTXD0/bIdtmOaMG3PTl SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM6PR12MB2684; 20:9MPGKi1wfsMbc/0BhQwsh2AFTwgCAbCvQt+QsGZjlt4qvDqoxwm+7BbUaTgc8KTM0i8sj6ya9pJSALfK/n3zwPhhxbO1c++hfiPGElw3RZ5dmWKGOl0fgW4zcSggdAyTdxq3unINE9OCHJNi62F15mTSkplwiaIiLJ2fHG2Ze3wOFVc14FyrBW75Szd8fmUCso5pQR9q3S+QNQ8Q3O9xA39fPp5+Ej61RS05fj9sy3wBlWCehf7xTRcbDQiuvBaK X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2018 18:27:33.3701 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dff4c30d-98e6-410d-d199-08d61a6fbdbf X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2684 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.33.44 Subject: [Qemu-devel] [PATCH v2 8/8] x86_iommu/amd: Enable Guest virtual APIC support X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Lendacky , Brijesh Singh , Eduardo Habkost , "Michael S. Tsirkin" , Paolo Bonzini , Suravee Suthikulpanit , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Now that amd-iommu support interrupt remapping, enable the GASup in IVRS table and GASup in extended feature register to indicate that IOMMU support guest virtual APIC mode. GASup provides option to guest OS to make use of 128-bit IRTE. Note that the GAMSup is set to zero to indicate that amd-iommu does not support guest virtual APIC mode (aka AVIC) which would be used for the nested VMs. See Table 21 from IOMMU spec for interrupt virtualization controls Signed-off-by: Brijesh Singh Reviewed-by: Peter Xu Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: Tom Lendacky Cc: Suravee Suthikulpanit --- hw/i386/acpi-build.c | 3 ++- hw/i386/amd_iommu.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 0a19e25..41f523a 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -2567,7 +2567,8 @@ build_amd_iommu(GArray *table_data, BIOSLinker *linke= r) build_append_int_noprefix(table_data, (48UL << 30) | /* HATS */ (48UL << 28) | /* GATS */ - (1UL << 2), /* GTSup */ + (1UL << 2) | /* GTSup */ + (1UL << 6), /* GASup */ 4); /* * Type 1 device entry reporting all devices diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h index 6579469..1ac920e 100644 --- a/hw/i386/amd_iommu.h +++ b/hw/i386/amd_iommu.h @@ -177,7 +177,7 @@ /* extended feature support */ #define AMDVI_EXT_FEATURES (AMDVI_FEATURE_PREFETCH | AMDVI_FEATURE_PPR | \ AMDVI_FEATURE_IA | AMDVI_FEATURE_GT | AMDVI_FEATURE_HE | \ - AMDVI_GATS_MODE | AMDVI_HATS_MODE) + AMDVI_GATS_MODE | AMDVI_HATS_MODE | AMDVI_FEATURE_GA) =20 /* capabilities header */ #define AMDVI_CAPAB_FEATURES (AMDVI_CAPAB_FLAT_EXT | \ --=20 2.7.4